📝 fanquake opened a pull request: "build: let CMake determine the year"
(https://github.com/bitcoin/bitcoin/pull/32445)
Then we no-longer have to "bump" it.

💬 fanquake commented on pull request "depends: Avoid using helper variables in toolchain file":
(https://github.com/bitcoin/bitcoin/pull/31360#issuecomment-2862377129)
cc @purpleKarrot

🤔 hebasto reviewed a pull request: "crypto: disable ASan for sha256_sse4 with Clang"
(https://github.com/bitcoin/bitcoin/pull/32437#pullrequestreview-2824444216)
My Guix build:
```
aarch64
20608607794819e22c0bc02c920ba03a4edf98b902e278f1e2dcc9d92f2f485f guix-build-4e8ab5e00fa7/output/aarch64-linux-gnu/SHA256SUMS.part
f3268558a957a2b55191b14bdb9f7c23d60dc72a84ecbfe6b56a280f8f09fd1f guix-build-4e8ab5e00fa7/output/aarch64-linux-gnu/bitcoin-4e8ab5e00fa7-aarch64-linux-gnu-debug.tar.gz
791e1b3e81b358343dd5fafa53ab1d503e819d6935515277443dcfef4091c470 guix-build-4e8ab5e00fa7/output/aarch64-linux-gnu/bitcoin-4e8ab5e00fa7-aarch64-linux-gnu.tar.gz
1b689d1c
...

🤔 hebasto reviewed a pull request: "crypto: disable ASan for sha256_sse4 with Clang"
(https://github.com/bitcoin/bitcoin/pull/32437#pullrequestreview-2824452024)
Post-merge ACK 4e8ab5e00fa72016a7ec0e0505ca025d4e59e4d8.

💬 laanwj commented on pull request "lint: Remove string exclusion from locale check":
(https://github.com/bitcoin/bitcoin/pull/32434#discussion_r2079302392)
i was worried for a bit here but apparently this appears in a comment only.

💬 hebasto commented on issue "Depends toolchain doesn't contain enough info to build from depends on a fresh NixOS install":
(https://github.com/bitcoin/bitcoin/issues/32428#issuecomment-2862397599)
> > Building our own depends implies that we fully rely on them, ideally skipping all other search paths used by CMake's package, library, and header search mechanisms. Therefore, I believe we should retain as many restrictions as possible.
>
> We may do that with a [dependency provider](https://cmake.org/cmake/help/latest/command/cmake_language.html#set-dependency-provider). This will put `find_package()` completely under our control, so restricting CMake's builtin find logic becomes unnecessa
...

💬 laanwj commented on pull request "build: let CMake determine the year":
(https://github.com/bitcoin/bitcoin/pull/32445#issuecomment-2862408273)
Concept ACK but NACK on the implementation, as i understand this makes the build output depend on the system clock.

What about making the COPYRIGHT_YEAR depend on the last git commit?

🤔 i-am-yuvi reviewed a pull request: "Feature: Use different datadirs for different signets"
(https://github.com/bitcoin/bitcoin/pull/29838#pullrequestreview-2824481927)
re-ACK 69139049194e55a7fd99b7125b9afccb8585922d

💬 fanquake commented on pull request "build: let CMake determine the year":
(https://github.com/bitcoin/bitcoin/pull/32445#issuecomment-2862417346)
> What about making the COPYRIGHT_YEAR depend on the last git commit date in UTC?

I'm open to implementing this in any way, but if the logic for doing so, is going to end up being more than a few lines / add other requirements (i.e what happens if you're building from a tarball/no git etc), then maybe we shouldn't bother. Just wanted to -1 the number of things that need maintenance.

📝 fanquake converted_to_draft a pull request: "build: let CMake determine the year"
(https://github.com/bitcoin/bitcoin/pull/32445)
Then we no-longer have to "bump" it.

💬 hebasto commented on pull request "build: let CMake determine the year":
(https://github.com/bitcoin/bitcoin/pull/32445#discussion_r2079330128)
nit: Add `UTC` option to avoid using local time?

👍 hebasto approved a pull request: "build: let CMake determine the year"
(https://github.com/bitcoin/bitcoin/pull/32445#pullrequestreview-2824496328)
ACK f930f5e11024fd44a9f1c666d6eee3c9c19edfa0.

It would be useful to mention in the commit message / PR description a note from the CMake docs:
> If the `SOURCE_DATE_EPOCH` environment variable is set, its value will be used instead of the current time.

🚀 fanquake merged a pull request: "lint: Remove string exclusion from locale check"
(https://github.com/bitcoin/bitcoin/pull/32434)

👍 laanwj approved a pull request: "doc: swap "Docker image" for "container image""
(https://github.com/bitcoin/bitcoin/pull/32444#pullrequestreview-2824508134)
ACK 1372eb09c5d031315bc6cde34f7a15297e96f4cc

💬 laanwj commented on pull request "build: let CMake determine the year":
(https://github.com/bitcoin/bitcoin/pull/32445#issuecomment-2862438404)
> If the SOURCE_DATE_EPOCH environment variable is set, its value will be used instead of the current time.

Well that's some important context... Agree in that case.

👍 hebasto approved a pull request: "doc: swap "Docker image" for "container image""
(https://github.com/bitcoin/bitcoin/pull/32444#pullrequestreview-2824537049)
ACK 1372eb09c5d031315bc6cde34f7a15297e96f4cc.

💬 vasild commented on pull request "config: allow setting -proxy per network":
(https://github.com/bitcoin/bitcoin/pull/32425#issuecomment-2862468060)
> Maybe we should give a warning at least (and perhaps suggesting: `-proxy=0=cjdns`) because that (`-proxy=ip[:<port>] -onlynet=onion -cjdnsreachable`) would make CJDNS not to work (?).

That would make automatic outbound connections to Tor peers only. Still manual outbound and inbound connections would work and be possible to/from CJDNS peers. Maybe a warning in the lines of "Automatic outbound connections will only be made to Tor peers, if you want to include CJDNS, then use -onlynet=cjdns i
...

📝 fanquake opened a pull request: "build: simplify *ifaddr handling"
(https://github.com/bitcoin/bitcoin/pull/32446)
We really just want to skip this when building for Windows. So do that,
and remove the two header checks (we also already use both of these
headers, unguarded, in the !windows part of the codebase).

Squash the two *iffaddrs defines into one, as I haven't seen an
`iffaddrs.h` that implements one, but not the other.

👍 rkrux approved a pull request: "test: add test for decoding PSBT with MuSig2 PSBT key types (BIP 373)"
(https://github.com/bitcoin/bitcoin/pull/32305#pullrequestreview-2824580145)
tACK 4b24186

```
git range-diff 23ee07d...4b24186
```

💬 fanquake commented on pull request "cmake: Respect user-provided configuration-specific flags":
(https://github.com/bitcoin/bitcoin/pull/32356#issuecomment-2862498362)
@ryanofsky / @theuni want to circle back?

I think we'll also backport this for `29.x`.