💬 Eunovo commented on pull request "Wallet: Fix Non-Ranged Descriptors with Range [0,0] Trigger Unexpected Wallet Errors in AddWalletDescriptor":
(https://github.com/bitcoin/bitcoin/pull/32344#discussion_r2078052670)
Decided to simplify the test. See https://github.com/bitcoin/bitcoin/pull/32344/commits/97d383af6d54b463da64f45680a146d7e93eb146

💬 Eunovo commented on pull request "Wallet: Fix Non-Ranged Descriptors with Range [0,0] Trigger Unexpected Wallet Errors in AddWalletDescriptor":
(https://github.com/bitcoin/bitcoin/pull/32344#discussion_r2078053908)
I wasn't satisfied with how this would look, so I left it as-is.

🤔 pablomartin4btc reviewed a pull request: "qt, docs: Unify term "clipboard""
(https://github.com/bitcoin-core/gui/pull/871#pullrequestreview-2822542209)
ACK 3bbdbc0a5e1b409969cedaf249d1d01dea9bcf73

🤔 pablomartin4btc reviewed a pull request: "refactor: Removals after bdb removal"
(https://github.com/bitcoin/bitcoin/pull/32438#pullrequestreview-2822610785)
maybe also this one:

https://github.com/bitcoin/bitcoin/blob/fa23a6f75ee69abb626b6dec19dbb5a05f457de0/src/wallet/wallet.cpp#L385-L389

this one:

https://github.com/bitcoin/bitcoin/blob/fa23a6f75ee69abb626b6dec19dbb5a05f457de0/src/wallet/wallet.cpp#L480-L483

and this one:

https://github.com/bitcoin/bitcoin/blob/fa23a6f75ee69abb626b6dec19dbb5a05f457de0/src/wallet/wallet.cpp#L290-L293

💬 theStack commented on pull request "test: add test for decoding PSBT with MuSig2 PSBT key types (BIP 373)":
(https://github.com/bitcoin/bitcoin/pull/32305#issuecomment-2859499477)
Force-pushed again, fixing a small bug in an assertion (kudos to LLM linter for detecting this 👌 )
```ranged-diff
-+ assert "aggregate_pubkey" in in_pubnonce
++ assert "aggregate_pubkey" in in_partialsig
+ assert_equal(in_partialsig["aggregate_pubkey"], in_fake_agg_pubkey.hex())
```

💬 w0xlt commented on pull request "docs: Improve `keypoolrefill` RPC docs":
(https://github.com/bitcoin/bitcoin/pull/32429#discussion_r2078166392)
Done in https://github.com/bitcoin/bitcoin/pull/32429/commits/ff35a4b021e12ae33e28c01ffeeb2c1916f7a487

💬 w0xlt commented on pull request "docs: Improve `keypoolrefill` RPC docs":
(https://github.com/bitcoin/bitcoin/pull/32429#discussion_r2078166574)
Done in https://github.com/bitcoin/bitcoin/pull/32429/commits/ff35a4b021e12ae33e28c01ffeeb2c1916f7a487

💬 davidgumberg commented on pull request "test: remove bdb assert in tool_wallet.py":
(https://github.com/bitcoin/bitcoin/pull/32440#issuecomment-2859589494)
crACK https://github.com/bitcoin/bitcoin/pull/32440/commits/4b6dd9790b667455ad7de58c67b3f7c9bc50657c

👍 brunoerg approved a pull request: "docs: Improve `keypoolrefill` RPC docs"
(https://github.com/bitcoin/bitcoin/pull/32429#pullrequestreview-2822682329)
code review ACK ff35a4b021e12ae33e28c01ffeeb2c1916f7a487

🤔 w0xlt reviewed a pull request: "lint: Remove string exclusion from locale check"
(https://github.com/bitcoin/bitcoin/pull/32434#pullrequestreview-2822712091)
ACK https://github.com/bitcoin/bitcoin/pull/32434/commits/fa24fdcb7f474e6959ae4d8fe9759d365c6c021b

💬 NicolaLS commented on pull request "doc: Improve `dependencies.md`":
(https://github.com/bitcoin/bitcoin/pull/31895#issuecomment-2859720907)
Rebased and dropped the two commits that bumped sqlite/zmq in favor of removing the "Version used" column from the tables entirely (see cb623692a6089c39560a637a2bf064d54aebb4d4).

This commit also removed _"Version Used" refers to the release binaries._ not sure if this should get replaced with something else ? (not necessary imo.)

🤔 w0xlt reviewed a pull request: "test: refactor: negate signature-s using libsecp256k1"
(https://github.com/bitcoin/bitcoin/pull/32436#pullrequestreview-2822735624)
ACK https://github.com/bitcoin/bitcoin/pull/32436/commits/bfb7b8876035774eddb200d741aa6a86859069b3

🤔 w0xlt reviewed a pull request: "refactor: Removals after bdb removal"
(https://github.com/bitcoin/bitcoin/pull/32438#pullrequestreview-2822741478)
Approach ACK

🤔 w0xlt reviewed a pull request: "test: remove bdb assert in tool_wallet.py"
(https://github.com/bitcoin/bitcoin/pull/32440#pullrequestreview-2822744996)
ACK https://github.com/bitcoin/bitcoin/pull/32440/commits/4b6dd9790b667455ad7de58c67b3f7c9bc50657c

💬 1440000bytes commented on pull request "Remove arbitrary limits on OP_Return (datacarrier) outputs":
(https://github.com/bitcoin/bitcoin/pull/32359#issuecomment-2859741415)
> I am not okay with the software taking away my ability to decide for myself. If this is merged I will seek alternative software for my node.

Users cannot configure anything beyond limits for one output at this point. They cannot allow/disable multiple outputs in same transaction.

See: https://github.com/bitcoin/bitcoin/pull/32406

👍 brunoerg approved a pull request: "test: remove bdb assert in tool_wallet.py"
(https://github.com/bitcoin/bitcoin/pull/32440#pullrequestreview-2822763769)
code review ACK 4b6dd9790b667455ad7de58c67b3f7c9bc50657c

💬 NicolaLS commented on pull request "doc: Improve `dependencies.md`":
(https://github.com/bitcoin/bitcoin/pull/31895#discussion_r2078224849)
Removed the sqlite/zmq update commits in favor of new: cb623692a6089c39560a637a2bf064d54aebb4d4

See https://github.com/bitcoin/bitcoin/pull/31895#issuecomment-2859720907

💬 1440000bytes commented on pull request "Remove arbitrary limits on OP_Return (datacarrier) outputs":
(https://github.com/bitcoin/bitcoin/pull/32359#issuecomment-2859758106)
I was thinking of ways to use multiple outputs for coinjoin. I found some that I will share in a blog post.

👍 theStack approved a pull request: "test: remove bdb assert in tool_wallet.py"
(https://github.com/bitcoin/bitcoin/pull/32440#pullrequestreview-2822777653)
ACK 4b6dd9790b667455ad7de58c67b3f7c9bc50657c

If you want, could also remove `assert_dump` which is not used anymore since c847dee1488a294c9a9632a00ba1134b21e41947

💬 brunoerg commented on pull request "test: added fuzz coverage for consensus/merkle.cpp":
(https://github.com/bitcoin/bitcoin/pull/32243#discussion_r2078229527)
`/ci_container_base/src/test/fuzz/merkle.cpp:103:96: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'size_t' (aka 'unsigned long')`. `num_txs` can be zero, so it's causing the overflow here.