💬 pinheadmz commented on pull request "Extend signetchallenge to set target block spacing":
(https://github.com/bitcoin/bitcoin/pull/29365#issuecomment-2847932450)
Crashed with long time spacing (are you sure you need 2^64 seconds?)

`build/bin/bitcoind -signet -signetchallenge=6a4c09011effff00000000004c0151 -debug -debugexclude=libevent`

`bitcoin-cli -signet -generate`

log:
```

2025-05-02T19:18:23Z [http] Received a POST request for / from 127.0.0.1:39282
2025-05-02T19:18:23Z [rpc] ThreadRPCServer method=getnewaddress user=__cookie__
2025-05-02T19:18:24Z [http] Received a POST request for / from 127.0.0.1:39284
2025-05-02T19:18:24Z [rpc] Th
...

💬 laanwj commented on pull request "cmake: Add application manifests when cross-compiling for Windows":
(https://github.com/bitcoin/bitcoin/pull/32396#issuecomment-2847960905)
Concept ACK

💬 mzumsande commented on pull request "test: allow all functional tests to be run or skipped with --usecli":
(https://github.com/bitcoin/bitcoin/pull/32290#issuecomment-2847976226)
Also added a commmit to fix the too-large args (https://github.com/bitcoin/bitcoin/pull/32399#issuecomment-2846837427).

📝 hebasto opened a pull request: "fuzz: Suppress abort message on Windows"
(https://github.com/bitcoin/bitcoin/pull/32409)
This PR ensures that the `fuzz.exe` binary is non-interactive, which is essential for CI tests.

Here are CI jobs for the "Debug" configuration:
- on the master branch: https://github.com/maflcko/bitcoin-core-with-ci/actions/runs/14759346479/job/41435857332
- with this PR: https://github.com/hebasto/bitcoin-core-nightly/actions/runs/14801894543/job/41562322239

Address this [comment](https://github.com/bitcoin/bitcoin/issues/32341#issuecomment-2842716175).

💬 furszy commented on pull request "Refactor BnB tests":
(https://github.com/bitcoin/bitcoin/pull/29532#discussion_r2072086633)
As the `is_eff_value` arg is always true for all the tests. What about removing it?.
Also, you are expecting `group.GetSelectionAmount()` to be equal to `tx.vout[0].nValue` with this parameter right?. I'm unsure that will always be the case.
As a test, you could try adding an assertion at the end of this function. I have a hunch it will crash.

💬 hebasto commented on pull request "cmake: Add application manifests when cross-compiling for Windows":
(https://github.com/bitcoin/bitcoin/pull/32396#issuecomment-2848017666)
My Guix build:
```
50de79d47cf8e15acd94d189a88423a89003e287c0e30978d45cb13a478a8a7c guix-build-665b2ba99955/output/dist-archive/bitcoin-665b2ba99955.tar.gz
edae04ce1b66195e3afb9fcdd399719e20085c0d42e55f30a17fd8d1b972b798 guix-build-665b2ba99955/output/x86_64-w64-mingw32/SHA256SUMS.part
33dfd8539f6dae306a7ee3f8ff2c6e4eafe8d7740a76629767fb4f4601c9c61c guix-build-665b2ba99955/output/x86_64-w64-mingw32/bitcoin-665b2ba99955-win64-codesigning.tar.gz
9acd0edc19836d7aeed0e776d69795b8d27f78df3c12
...

💬 achow101 commented on pull request "test: remove Boost SIGCHLD workaround.":
(https://github.com/bitcoin/bitcoin/pull/32403#issuecomment-2848082546)
ACK 3add6ab9adcd722d57c6d488581358ae9b377f1a

💬 andrewtoth commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#issuecomment-2848103940)
> Why is there no sign of periodic flushing during reindex?

Indeed, it seems we do not get to [this line](https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L3595) during reindex-chainstate. Will have to investigate. Periodically flushing during reindex-chainstate would be useful.

> Why did the reported utxo size increase during IBD after the change?

There is less opportunity for utxo cut-through after this change. So, some utxos that would previously have been deleted ar
...

💬 mzumsande commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#issuecomment-2848120687)
> Indeed, it seems we do not get to [this line](https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L3595) during reindex-chainstate.

It makes sense: `reindex-chainstate` is nothing more than [one call](https://github.com/bitcoin/bitcoin/blob/5b8046a6e893b7fad5a93631e6d1e70db31878af/src/node/blockstorage.cpp#L1251) to `ActivateBestChain()` (which will connect all connectable blocks). Since we only flush at the end of the function, we cannot flush more than once currently.

🚀 achow101 merged a pull request: "test: remove Boost SIGCHLD workaround."
(https://github.com/bitcoin/bitcoin/pull/32403)

💬 ryanofsky commented on pull request "[DRAFT] ipc: add windows support":
(https://github.com/bitcoin/bitcoin/pull/32387#issuecomment-2848129853)
Updated 27328195136754babe8d8f5d99f4f0b6a5ab2e55 -> f215e742045401ab386f0cd67d06b358558ecf89 ([`pr/ipc-win.4`](https://github.com/ryanofsky/bitcoin/commits/pr/ipc-win.4) -> [`pr/ipc-win.5`](https://github.com/ryanofsky/bitcoin/commits/pr/ipc-win.5), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/ipc-win.4..pr/ipc-win.5)) fixing many windows bugs.

With this update, IPC code is mostly working on windows: `mpexample` and `mptest` programs work, `test_bitcoin` IPC calls over socketpair
...

🤔 w0xlt reviewed a pull request: "Refactor BnB tests"
(https://github.com/bitcoin/bitcoin/pull/29532#pullrequestreview-2812922420)
ACK https://github.com/bitcoin/bitcoin/pull/29532/commits/85368aafa0d1772626d5f615e272b1c1a580b42f

💬 donaldevine commented on something "":
(https://github.com/bitcoin/bitcoin/commit/3ba7449f6c335026b752366c53f9c309f09e6c64#commitcomment-156304878)
Allowing multiple OP_RETURN Outputs in a single transaction will have serious implications for Node Resources including higher memory requirements during transaction validation and more complex relay policies. Allowing multiple OP_RETURN outputs represents a relaxation of data storage policies that will have massive downstream effects. NACK

💬 kevkevinpal commented on pull request "tests: Added progress tracker when running fuzz test_runner.py":
(https://github.com/bitcoin/bitcoin/pull/32354#discussion_r2072235911)
Do you think the summary would still be useful if you're running `--loglevel=DEBUG`?

I could put an if block around it so we still get the summary for debug mode at the end.

I agree though for `logging.info` and above it seems pretty redundant

💬 kevkevinpal commented on pull request "tests: Added progress tracker when running fuzz test_runner.py":
(https://github.com/bitcoin/bitcoin/pull/32354#discussion_r2072240638)
no there is not, pushed [c54df63](https://github.com/bitcoin/bitcoin/pull/32354/commits/c54df63f7d5047bf8efc345f102942cbb86fb019)

💬 kevkevinpal commented on pull request "tests: Added progress tracker when running fuzz test_runner.py":
(https://github.com/bitcoin/bitcoin/pull/32354#discussion_r2072240720)
I just made into a debug log in [c54df63](https://github.com/bitcoin/bitcoin/pull/32354/commits/c54df63f7d5047bf8efc345f102942cbb86fb019)

💬 achow101 commented on pull request "qt, wallet: Convert uint256 to Txid":
(https://github.com/bitcoin/bitcoin/pull/32238#issuecomment-2848316721)
ACK 65fcfbb2b38bef20a58daa6c828c51890180611d

💬 achow101 commented on pull request "wallet: Translate [default wallet] string in progress messages":
(https://github.com/bitcoin/bitcoin/pull/31296#issuecomment-2848318178)
ACK a46ec1dece8d8a1b16ff1fc3d2932bca130bf67f

💬 achow101 commented on pull request "rpc: Support v3 raw transactions creation":
(https://github.com/bitcoin/bitcoin/pull/31936#issuecomment-2848323697)
Approach NACK

While I agree that we should support v3 transactions, I think this implementation is incomplete without any v3 support in the wallet's coin selection. As it is now, this appears to enable a massive footgun - users can use `createrawtransaction` to create a v3 transaction, fund it with `fundrawtransaction`, and then wind up with a v3 transaction that they cannot broadcast. This is because the topological restrictions of v3 transactions are not being taken into account during coin
...

💬 starius commented on pull request "Extend signetchallenge to set target block spacing":
(https://github.com/bitcoin/bitcoin/pull/29365#issuecomment-2848379263)
> Crashed with long time spacing (are you sure you need 2^64 seconds?)
>
> `build/bin/bitcoind -signet -signetchallenge=6a4c09011effff00000000004c0151 -debug -debugexclude=libevent`
>
> `bitcoin-cli -signet -generate`
>
> log:
>
> ```
>
> 2025-05-02T19:18:23Z [http] Received a POST request for / from 127.0.0.1:39282
> 2025-05-02T19:18:23Z [rpc] ThreadRPCServer method=getnewaddress user=__cookie__
> 2025-05-02T19:18:24Z [http] Received a POST request for / from 127.0.0.1:39284
>
...