💬 ryanofsky commented on pull request "[DRAFT] ipc: add windows support":
(https://github.com/bitcoin/bitcoin/pull/32387#issuecomment-2843318872)
Updated 87432b6a4325e09a13c912d77b386daa3832b34d -> 0a35e21103b7fed6e46c809e9029446277b6f6ee ([`pr/ipc-win.2`](https://github.com/ryanofsky/bitcoin/commits/pr/ipc-win.2) -> [`pr/ipc-win.3`](https://github.com/ryanofsky/bitcoin/commits/pr/ipc-win.3), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/ipc-win.2..pr/ipc-win.3)) to fix test CI failure https://cirrus-ci.com/task/5583224107171840

---

re: https://github.com/bitcoin/bitcoin/pull/32387#issuecomment-2843024844

Agree change
...

🤔 w0xlt reviewed a pull request: "descriptors: MuSig2"
(https://github.com/bitcoin/bitcoin/pull/31244#pullrequestreview-2808489885)
Concept ACK.

💬 mzumsande commented on pull request "test: allow all functional tests to be run or skipped with --usecli":
(https://github.com/bitcoin/bitcoin/pull/32290#discussion_r2069519376)
renamed to `convert_to_json_for_cli`

💬 mzumsande commented on pull request "test: allow all functional tests to be run or skipped with --usecli":
(https://github.com/bitcoin/bitcoin/pull/32290#issuecomment-2843416255)
> If this ends up fixing all issues, should add `--usecli` to atleast one CI, so we catch regressions?

I have added `--usecli` to one CI job now (multiprocess, i686, DEBUG)

🤔 w0xlt reviewed a pull request: "wallet: Keep track of the wallet's own transaction outputs in memory"
(https://github.com/bitcoin/bitcoin/pull/27286#pullrequestreview-2808627212)
ACK https://github.com/bitcoin/bitcoin/pull/27286/commits/26014804bb792bde141baf3e9d9ac30b6a27c988

💬 hebasto commented on issue "build: x86 afl++ ASan build broken "error: inline assembly requires more registers than available"":
(https://github.com/bitcoin/bitcoin/issues/31913#issuecomment-2843487857)
@davidgumberg

> > Could someone provide configuration options and a line from the verbose build to show what exactly is broken?
>
> Reproduced as follows:

Thank you!

Could you please try the following patch:
```diff
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 99490f742a..47d50b6ba7 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -192,9 +192,9 @@ set(APPEND_CXXFLAGS "" CACHE STRING "(Objective) C++ compiler flags that are app
set(APPEND_LDFLAGS "" CACHE STRING "Linker flags that
...

💬 andrewtoth commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#discussion_r2069552602)
Done - moved to after the write.

https://github.com/bitcoin/bitcoin/compare/b7f3b6fd96ca2d5d1f9538affef682f778bd07e8..2aadd877f0db599d67d7ca74b8173b0148c9e098.

💬 achow101 commented on pull request "Wallet: Fix Non-Ranged Descriptors with Range [0,0] Trigger Unexpected Wallet Errors in AddWalletDescriptor":
(https://github.com/bitcoin/bitcoin/pull/32344#issuecomment-2843503818)
ACK fa0993462b3bc8db40c1a6ea2e7f5fd4a22353a6

💬 davidgumberg commented on issue "test: functional test failures under -DENABLE_WALLET=OFF":
(https://github.com/bitcoin/bitcoin/issues/32347#issuecomment-2843508491)
I couldn't reproduce this on x86_64 linux, could you share the `build/test/config.ini` file?

AFAICT, none of these lines that result in a crash should be running when `is_wallet_compiled() == false`, and that's based on the contents of config.ini:

https://github.com/bitcoin/bitcoin/blob/68ac9f116c0228a277f18f60ba2278b56356e6ac/test/functional/test_framework/test_framework.py#L268-L270

https://github.com/bitcoin/bitcoin/blob/68ac9f116c0228a277f18f60ba2278b56356e6ac/test/functional/test_framewo
...

💬 davidgumberg commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#discussion_r2069567781)
`nNow` is still getting set above before the write

💬 andrewtoth commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#discussion_r2069580172)
Indeed - fixed!

💬 achow101 commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#issuecomment-2843597954)
ACK e976bd3045010ee217aa0f2dca4c962aabb789d5

💬 ADAMSALAMA6667 commented on issue "Cannot import descriptors with label and internal:false":
(https://github.com/bitcoin/bitcoin/issues/32376#issuecomment-2843684526)
[]()****

💬 w0xlt commented on issue "An "output descriptor" should not have many different checksums":
(https://github.com/bitcoin/bitcoin/issues/30632#issuecomment-2843736550)
Can this issue be closed ?

✅ achow101 closed an issue: "An "output descriptor" should not have many different checksums"
(https://github.com/bitcoin/bitcoin/issues/30632)

💬 ajtowns commented on pull request "policy: allow more than one OP_RETURN outputs per tx":
(https://github.com/bitcoin/bitcoin/pull/32381#issuecomment-2843801037)
> My intention with this PR was to have a first step that is consensual among regular contributors,

The minimal change would just be to bump the default value of datacarrier, afaics.

💬 w0xlt commented on issue "`keypoolrefill` doesn't fill keypool to specified parameter":
(https://github.com/bitcoin/bitcoin/issues/29924#issuecomment-2843818428)
Yes, by default, descriptor wallets start with 4 `ScriptPubKeyManager` (WPKH, TR, PKH, and SH(WPKH())), each with a size of 1,000. Therefore, the initial value is 4,000.

Incrementing the key pool with 4,001 keys gives 4001 * 4 = 16,004.

💬 davidgumberg commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#issuecomment-2843857723)
utACK https://github.com/bitcoin/bitcoin/commit/e976bd3045010ee217aa0f2dca4c962aabb789d5

This will likely slow down IBD by a small amount for those running large dbcache values close to or greater than the old maximum (~16GB) because we lose some write "cut-through"[^1] but I seriously doubt there are that many people allocating >16GB to their DBCache, and I don't think sparing those users ~10 minutes during IBD is worth having every node on the network have a medium sized stall to flush ever
...

💬 davidgumberg commented on issue "build: x86 afl++ ASan build broken "error: inline assembly requires more registers than available"":
(https://github.com/bitcoin/bitcoin/issues/31913#issuecomment-2843872570)
> Could you please try the following patch:
>
> [...]

It failed with this build command:

```
26.64 /AFLplusplus/afl-clang-fast++ -pipe -std=c++20 -O2 -g -fstack-protector-all -fcf-protection=full -fstack-clash-pro
tection -Wl,-z,relro -Wl,-z,now -Wl,-z,separate-code -fsanitize=address -fPIE -pie -fcf-protection=none CMakeFiles/bitco
ind.dir/bitcoind.cpp.o CMakeFiles/bitcoind.dir/init/bitcoind.cpp.o -o ../bin/bitcoind ../lib/libbitcoin_node.a ../lib/l
ibbitcoin_wallet.a libleveldb.a libcrc32c
...

🤔 monlovesmango reviewed a pull request: "Refactor BnB tests"
(https://github.com/bitcoin/bitcoin/pull/29532#pullrequestreview-2809059556)
ACK dbf1f2663b1afbe03d6b1855f83db604bc79979e

I like how it now covers a variety of fee rates.