💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060519499)
They are removed in #28710

💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060520098)
Added a commit to #28710 to remove

💬 achow101 commented on pull request "wallet: Disable creating and loading legacy wallets":
(https://github.com/bitcoin/bitcoin/pull/31250#discussion_r2060520569)
added a commit to #28710 to remove

💬 achow101 commented on pull request "Remove the legacy wallet and BDB dependency":
(https://github.com/bitcoin/bitcoin/pull/28710#issuecomment-2830837640)
Rebased and added a couple commits for followups from #31250

👋 achow101's pull request is ready for review: "Remove the legacy wallet and BDB dependency"
(https://github.com/bitcoin/bitcoin/pull/28710)

💬 fanquake commented on pull request "Remove the legacy wallet and BDB dependency":
(https://github.com/bitcoin/bitcoin/pull/28710#discussion_r2060528559)
`clang_cxx_11.patch` also needs deleting.

💬 fanquake commented on pull request "Remove the legacy wallet and BDB dependency":
(https://github.com/bitcoin/bitcoin/pull/28710#issuecomment-2830856375)
There's also a `libdb++-dev` instance in `workflows/ci.yml` & `deadlock:libdb` in tsan suppressions.

📝 monlovesmango opened a pull request: "doc: Fix fuzz test_runner.py path"
(https://github.com/bitcoin/bitcoin/pull/32353)
This commit fixes the path listed in the documentation for the fuzz testing test_runner.py. Previously the --help option worked but running fuzz tests from the documented path did not.

💬 darosior commented on pull request "miner: timelock the coinbase to the mined block's height":
(https://github.com/bitcoin/bitcoin/pull/32155#issuecomment-2830913121)
> I think you lost the comment announced here: [#32155 (comment)](https://github.com/bitcoin/bitcoin/pull/32155#discussion_r2056629920)
>
> Other than it looks good.

I did not: https://github.com/bitcoin/bitcoin/pull/32155/commits/67267b147f8c48e0775602395fba9db0105dccf4#diff-6b810fb346def9cc80a9d9ab75184dd9f41c4ac63493135a7bdfcb98f75b1ce8R39

> Failure in `interface_usdt_coinselection` seems to be an instance of #32322.

Yes. Rebased on master to avoid the unrelated CI failure after i
...

💬 l0rinc commented on pull request "[IBD] multi-byte block obfuscation":
(https://github.com/bitcoin/bitcoin/pull/31144#issuecomment-2830957054)
For now I've reverted the assert that checks the deserialized key size, since I couldn't reproduce the fuzz failure locally (or when I could, even master failed for the same command).
Will continue trying, but without the assert it's closer to the previous state, so it should be fine as it is as well.

💬 jesterhodl commented on pull request "[29.x] qt: 29.1 translations update":
(https://github.com/bitcoin/bitcoin/pull/32352#issuecomment-2830993573)
So I rerun the script and found some more issues and updated Transifex.
v29 is not translated 100% yet from what I see, but at least the worst offenders: spam, typos, gross errors should be fixed now.

💬 kevkevinpal commented on pull request "doc: Fix fuzz test_runner.py path":
(https://github.com/bitcoin/bitcoin/pull/32353#issuecomment-2830999023)
ACK [61f238e](https://github.com/bitcoin/bitcoin/pull/32353/commits/61f238e84ac6d24d8f420c2eabcbb2980d7fcb1e)

---

This is the error I get if I try running `test_runner.py` from the non build dir
```
./test/fuzz/test_runner.py ../qa-assets/fuzz_corpora
Traceback (most recent call last):
File "/mnt/shared_drive/DEVDIR/bitcoin/./test/fuzz/test_runner.py", line 407, in <module>
main()
File "/mnt/shared_drive/DEVDIR/bitcoin/./test/fuzz/test_runner.py", line 102, in main
confi
...

💬 ryanofsky commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#issuecomment-2831035109)
Updated e8372fa3a606d35146c72fc61663e17c67a4621a -> a56468ab0bf2154159919a2c3feba9974486d10e ([`pr/ipc-stop.1`](https://github.com/ryanofsky/bitcoin/commits/pr/ipc-stop.1) -> [`pr/ipc-stop.2`](https://github.com/ryanofsky/bitcoin/commits/pr/ipc-stop.2), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/ipc-stop.1..pr/ipc-stop.2)) to fix draftbot typos and CI failures, though I could not reproduce the previous releases AppInitMain failure in local CI so it could still be broken

💬 hebasto commented on pull request "[29.x] qt: 29.1 translations update":
(https://github.com/bitcoin/bitcoin/pull/32352#issuecomment-2831070314)
> So I rerun the script and found some more issues and updated Transifex. v29 is not translated 100% yet from what I see, but at least the worst offenders: spam, typos, gross errors should be fixed now.

Thank you! Updated.

👍 hebasto approved a pull request: "Replace stray tfm::format to cerr with qWarning"
(https://github.com/bitcoin-core/gui/pull/868#pullrequestreview-2794899658)
ACK edd46566bd66cea7d7f4116429fe1c11d2187ba2, I have reviewed the code and it looks OK.

💬 Sjors commented on pull request "miner: timelock the coinbase to the mined block's height":
(https://github.com/bitcoin/bitcoin/pull/32155#issuecomment-2831098171)
Code review ACK a58cb3b1c12c8cb75a87375c50f94c4605bb805d

I'm a bit reluctant to have this merged while BIP54 is in limbo (https://github.com/bitcoin/bips/pull/1800).

Additionally I think it's worth waiting a few weeks (?) to see if someone responds to https://delvingbitcoin.org/t/great-consensus-cleanup-revival/710/85 about the use of `nLockTime` as an extranonce.

Let's add this to the v30 milestone though. Unless by that time someone advocates a different approach, it's better to just
...

🤔 darosior reviewed a pull request: "test: avoid stack overflow in `FindChallenges` via manual iteration"
(https://github.com/bitcoin/bitcoin/pull/32351#pullrequestreview-2794937685)
Concept ACK. Should this marked as Fixes https://github.com/bitcoin/bitcoin/issues/32341?

💬 hebasto commented on pull request "build: Fix `macdeployqtplus` after switching to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/32287#discussion_r2060709771)
Thanks! Adjusted.

✅ glozow closed a pull request: "Package Relay 1/3: Introduce TxDownloadManager and improve orphan-handling"
(https://github.com/bitcoin/bitcoin/pull/28031)

💬 glozow commented on pull request "Package Relay 1/3: Introduce TxDownloadManager and improve orphan-handling":
(https://github.com/bitcoin/bitcoin/pull/28031#issuecomment-2831177590)
Closing because this is pretty completed (yay!). TxDownloadManager was added in #30110, and the multi-announcer orphan handling was added in #31397. We just need the last 2 commits to make txdownloadman internally thread-safe, but I believe we have somebody working on it.