📝 maflcko reopened a pull request: "wallet: Disable creating and loading legacy wallets"
(https://github.com/bitcoin/bitcoin/pull/31250)
To prepare for the deletion of legacy wallet code, disable creating or loading new legacy wallets.

Tests for the legacy wallet specifically are deleted.

Split from https://github.com/bitcoin/bitcoin/pull/28710

🤔 pablomartin4btc reviewed a pull request: "fuzz: wallet: add target for spkm migration"
(https://github.com/bitcoin/bitcoin/pull/29694#pullrequestreview-2793362842)
You are skipping the backup restore in commit: "_wallet: skip backup restoration when using in-memory dbs_"; shouldn't the backup itself be skipped too when `in_memory`?

💬 pablomartin4btc commented on pull request "fuzz: wallet: add target for spkm migration":
(https://github.com/bitcoin/bitcoin/pull/29694#discussion_r2059789644)
I think if you add the condition there, there are other stuff that's missing and I think they need to be done which are:
- the for after `// Unload the wallets`;
- the lines after `// Verify that there is no dangling wallet`

💬 fanquake commented on pull request "Fix missing error check in `set_clo_on_exec` for FD_CLOEXEC handling":
(https://github.com/bitcoin/bitcoin/pull/32342#issuecomment-2829768875)
This should probably be going upstream (https://github.com/arun11299/cpp-subprocess). cc @hebasto.

⚠️ fanquake reopened an issue: "ctest -C Debug fails on vs2022 (miniscript_tests (SEGFAULT))"
(https://github.com/bitcoin/bitcoin/issues/32341)
cmd: `ctest --output-on-failure --stop-on-failure -j $NUMBER_OF_PROCESSORS -C Debug`

output:

```
88% tests passed, 1 tests failed out of 8

Total Test time (real) = 98.97 sec

The following tests FAILED:
8 - test_bitcoin-qt (Exit code 0xc0000135
)
Errors while running CTest
```

log: https://github.com/bitcoin/bitcoin/actions/runs/14646596997/job/41102269274?pr=32339#step:11:78

ref: https://github.com/bitcoin/bitcoin/pull/32339

💬 fanquake commented on issue "ctest -C Debug fails on vs2022 (miniscript_tests (SEGFAULT))":
(https://github.com/bitcoin/bitcoin/issues/32341#issuecomment-2829770735)
Re-opening, given it looks like there are at least two cmake/windows bugs here?

👍 fanquake approved a pull request: "depends: Fix cross-compiling on macOS"
(https://github.com/bitcoin/bitcoin/pull/32215#pullrequestreview-2793452071)
ACK d0cce4172c041fc9b2910b360fe496b1102b19d2

💬 fanquake commented on issue "cmake inconsistently overriding `-O3` (sometimes)":
(https://github.com/bitcoin/bitcoin/issues/31491#issuecomment-2829832622)
@hebasto can you followup with all the questions asked in this thread:

https://github.com/bitcoin/bitcoin/issues/31491#issuecomment-2573089576

https://github.com/bitcoin/bitcoin/issues/31491#issuecomment-2573886240

It'd be good to get some clarification on which behaviour is meant to work.

✅ fanquake closed an issue: "build: cross-compiling for `x86_64-apple-darwin` from `arm64-apple-darwin` broken"
(https://github.com/bitcoin/bitcoin/issues/32208)

🚀 fanquake merged a pull request: "depends: Fix cross-compiling on macOS"
(https://github.com/bitcoin/bitcoin/pull/32215)

⚠️ fanquake opened an issue: "build: Windows cross Qt broken on macOS host"
(https://github.com/bitcoin/bitcoin/issues/32346)
```bash
make -C depends HOST=x86_64-w64-mingw32
<snip>
-- Configure summary:

Building for: win32-g++ (x86_64, CPU features: )
Compiler: gcc 14.2.0
Build options:
Mode ................................... release
Optimize release build for size ........ no
Fully optimize release builds (-O3) .... no
Building shared libraries .............. no
Unity Build ............................ no
Relocatable ............................ no
Using precompiled headers .............. yes
Using L
...

💬 fanquake commented on pull request "guix: Remove unused `file` package":
(https://github.com/bitcoin/bitcoin/pull/32242#issuecomment-2829937944)
Guix Build:
```bash
feeb8da87994724878ac8a62a6e9bfb9b1ece855f336327c900214d84d0a2bb9 guix-build-513e2020a9ac/output/aarch64-linux-gnu/SHA256SUMS.part
216b287ffbff054a14e60e14b3376acb8cd41dd224223ecd508bd46efad020ba guix-build-513e2020a9ac/output/aarch64-linux-gnu/bitcoin-513e2020a9ac-aarch64-linux-gnu-debug.tar.gz
3e68be5a329cbf5f389ca0dde51c1b1dd16b63ec26f42b8aa97dbd455ee3f30e guix-build-513e2020a9ac/output/aarch64-linux-gnu/bitcoin-513e2020a9ac-aarch64-linux-gnu.tar.gz
da2d239a78e7ceaa
...

👍 fanquake approved a pull request: "guix: Remove unused `file` package"
(https://github.com/bitcoin/bitcoin/pull/32242#pullrequestreview-2793602829)
ACK 513e2020a9acdd366d4933780b331f97bac85597

🚀 fanquake merged a pull request: "guix: Remove unused `file` package"
(https://github.com/bitcoin/bitcoin/pull/32242)

💬 maflcko commented on issue "cmake inconsistently overriding `-O3` (sometimes)":
(https://github.com/bitcoin/bitcoin/issues/31491#issuecomment-2829957978)
I guess it could make sense to append `-O2` in the case of `-DCMAKE_BUILD_TYPE=RelWithDebInfo` reported in OP as well, to avoid the unexpected `-O3` there? (The output reading a bit odd seems like a style issue that can be ignored for now)

⚠️ fanquake opened an issue: "test: functional test failures under -DENABLE_WALLET=OFF"
(https://github.com/bitcoin/bitcoin/issues/32347)
```bash
make -C depends/
cmake -B build --toolchain /root/bitcoin/depends/aarch64-unknown-linux-gnu/toolchain.cmake -DENABLE_WALLET=OFF
cmake --build build
./build/test/functional/test_runner.py
<snip>
wallet_watchonly.py --legacy-wallet | ○ Skipped | 1 s
wallet_watchonly.py --usecli --legacy-wallet | ○ Skipped | 0 s
feature_rbf.py | ✖ Failed | 10 s
interface_bitcoin_cli.py --legacy-wa
...

💬 hodlinator commented on pull request "qa: Verify clean shutdown on startup failure":
(https://github.com/bitcoin/bitcoin/pull/30660#discussion_r2059950855)
(We had a call and I will experiment with passing down the full `sys.argv` to the child processes (with some tweaking for tmpdir). Will also see if I can add a test-class which intentionally exercises the failure case of `...count("Traceback")) != 1` and other checks in `_verify_startup_failure` without making things too convoluted, as it will ensure the test tester is robust going forward).

💬 hodlinator commented on pull request "[IBD] multi-byte block obfuscation":
(https://github.com/bitcoin/bitcoin/pull/31144#issuecomment-2829997330)
Just letting the thread know that we've cleared up our miscommunication regarding https://github.com/bitcoin/bitcoin/pull/31144#pullrequestreview-2788618744. The combination of my prior suggestion failing CI and @l0rinc's cautioning to make sure my further suggestions pass CI seem to be an unlucky coincidence within a very short time-frame. We should strive towards assuming good-faith when communicating over text, but on some days frustrations can get the best of me.

💬 fanquake commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#issuecomment-2830017198)
https://github.com/bitcoin/bitcoin/actions/runs/14651550530/job/41119318297?pr=32345#step:5:966:
```bash
Assertion failed: fRPCInWarmup, file ./rpc/server.cpp, line 329
Error: Process completed with exit code 3.
```

https://cirrus-ci.com/task/5477140512112640?logs=ci#L5037:
```bash
[17:33:37.941] ./test/node_init_tests.cpp(41): error: in "node_init_tests/init_test": check AppInitMain(m_node) has failed
[17:33:37.941] Error: Cannot resolve -bind address: ''
[17:33:37.954] ./test/node_i
...

💬 maflcko commented on issue "test: functional test failures under -DENABLE_WALLET=OFF":
(https://github.com/bitcoin/bitcoin/issues/32347#issuecomment-2830043656)
The no wallet CI task passes: https://cirrus-ci.com/task/5884997988515840?logs=ci#L3274

What is the configure summary?