💬 l0rinc commented on pull request "[IBD] batch block reads/writes during `AutoFile` serialization":
(https://github.com/bitcoin/bitcoin/pull/31551#discussion_r2047794060)
It's an intermediary commit, the final code contains a flush only: https://github.com/bitcoin/bitcoin/pull/31551/files#diff-114c2880ec1ff2c5293ac65ceda0637bf92c05745b74b58410585a549464a33fR963

💬 TheCharlatan commented on pull request "[IBD] batch block reads/writes during `AutoFile` serialization":
(https://github.com/bitcoin/bitcoin/pull/31551#discussion_r2047820984)
So why is it added at all?

💬 l0rinc commented on pull request "[IBD] batch block reads/writes during `AutoFile` serialization":
(https://github.com/bitcoin/bitcoin/pull/31551#discussion_r2047822974)
To make the commit self-contained, as described in:
>I'll handle the close here temporarily (the last commit reverts it, but at least this commit is more complete) and will let [#29307 (files)](https://github.com/bitcoin/bitcoin/pull/29307/files#diff-114c2880ec1ff2c5293ac65ceda0637bf92c05745b74b58410585a549464a33f) handle the existing ones.

🚀 achow101 merged a pull request: "[IBD] batch block reads/writes during `AutoFile` serialization"
(https://github.com/bitcoin/bitcoin/pull/31551)

💬 theuni commented on pull request "net: replace manual reference counting of CNode with shared_ptr":
(https://github.com/bitcoin/bitcoin/pull/32015#issuecomment-2810940584)
I've been working on some experiments and tests for this again today, but unfortunately I didn't have time to get finished.

I'll be away until Tuesday, but I'll resume here next week. Sorry for the delay :(

💬 mahdibx commented on issue "Does not use bind to local address for outgoing connections":
(https://github.com/bitcoin/bitcoin/issues/6476#issuecomment-2810953661)
Also, as the score is set by address, having multiple outgoing addresses means that the score of your node will be all over the place depending on which address other nodes knows you by. I think it's reasonable to add an option to set the outgoing ipv6 address.

💬 achow101 commented on pull request "wallet: removed duplicate call to GetDescriptorScriptPubKeyMan":
(https://github.com/bitcoin/bitcoin/pull/32023#issuecomment-2811013410)
55b931934a34bab11446e8eed7bdaef92bb056de

💬 achow101 commented on pull request "wallet: allow label for non-ranged external descriptor & disallow label for ranged descriptors":
(https://github.com/bitcoin/bitcoin/pull/31514#issuecomment-2811023744)
ACK dda90a96bd01e34f4a564fbd15f1948f1c22ff58

Nice find!

💬 achow101 commented on pull request "test: Handle empty string returned by CLI as None in RPC tests":
(https://github.com/bitcoin/bitcoin/pull/32286#issuecomment-2811062273)
ACK a4041c77f0e20d004524868e70ff12508832c9eb

💬 achow101 commented on pull request "test: Add test coverage for rpcwhitelistdefault when unset":
(https://github.com/bitcoin/bitcoin/pull/32079#issuecomment-2811069030)
ACK 2929da1dd592da79e0afa6834a82c1bc54fbcf18

💬 achow101 commented on pull request "doc: Fix and clarify description of ZMQ message format":
(https://github.com/bitcoin/bitcoin/pull/31862#issuecomment-2811076715)
ACK 7a93544cdcc2874a18a8b6d528a75e84ac007880

✅ achow101 closed an issue: "test: functional test failures under `--usecli`"
(https://github.com/bitcoin/bitcoin/issues/32264)

🚀 achow101 merged a pull request: "test: Handle empty string returned by CLI as None in RPC tests"
(https://github.com/bitcoin/bitcoin/pull/32286)

⚠️ achow101 reopened an issue: "test: functional test failures under `--usecli`"
(https://github.com/bitcoin/bitcoin/issues/32264)
Ubuntu 24.04.2 LTS
Python 3.12.3
master @ 817edfb21e4fa96289d69d4e1dbabb6b9ef9d8f5
```bash
cmake -B build
cmake --build build
./build/test/functional/test_runner.py --usecli
```

```bash
feature_assumeutxo.py | ✖ Failed | 11 s
feature_bip68_sequence.py | ✖ Failed | 58 s
feature_fastprune.py | ✖ Failed | 1 s
feature_fee_estimation.py
...

🚀 achow101 merged a pull request: "test: Add test coverage for rpcwhitelistdefault when unset"
(https://github.com/bitcoin/bitcoin/pull/32079)

✅ achow101 closed an issue: "doc/zmq: Note about endianness does not match reality"
(https://github.com/bitcoin/bitcoin/issues/31856)

🚀 achow101 merged a pull request: "doc: Fix and clarify description of ZMQ message format"
(https://github.com/bitcoin/bitcoin/pull/31862)

💬 davidgumberg commented on pull request "wallet: Fix relative path backup during migration.":
(https://github.com/bitcoin/bitcoin/pull/32273#issuecomment-2811266661)
> Can you add a test for for failing to migrate a wallet specified by relative path? It's possible that restoration won't work as we expect it to.

Added a test that the 'automatic' restoration from a backup after a failed migration works, and added a test that restoring a backup made from an external relative wallet works.

> Also IIUC, there wasn't an issue with relative paths generally like "a/b/c", only an issue with relative paths containing `..` pointing outside of the wallets director
...

💬 davidgumberg commented on pull request "bench: Fix WalletMigration benchmark":
(https://github.com/bitcoin/bitcoin/pull/32281#discussion_r2047985458)
For context on my comment in https://github.com/bitcoin/bitcoin/issues/32277#issuecomment-2807698798, `SetAddressBook()` includes a [write](https://github.com/bitcoin/bitcoin/blob/e66e30c9e5383a467789574e61114b57536193b9/src/wallet/wallet.cpp#L2496-L2500) to the database, and so does [`AddToWallet(tx)`](https://github.com/bitcoin/bitcoin/blob/e66e30c9e5383a467789574e61114b57536193b9/src/wallet/wallet.cpp#L1160)

This is the reason why some records were persisted, but none that were strictly
...

💬 w0xlt commented on pull request "Refactor BnB tests":
(https://github.com/bitcoin/bitcoin/pull/29532#discussion_r2047995904)
nit: Since `coinselection_tests.cpp` is introduced in the first commit, this change may be there as well.