💬 0xB10C commented on pull request "doc: Remove unused NO_BLOOM_VERSION constant":
(https://github.com/bitcoin/bitcoin/pull/27657#issuecomment-1547444768)
ACK facbcd3

💬 ajtowns commented on pull request "net processing: avoid serving non-announced txs as a result of a MEMPOOL message":
(https://github.com/bitcoin/bitcoin/pull/27602#discussion_r1193531102)
The scenario here is:

* issue MEMPOOL with a large , returning 6000 txs from the mempool, all of which are added to the bloom filter, which then causes the first ~750 or more to be removed from the rolling bloom filter as it rolls over
* request one of those txs via GETDATA, which then fails if the tx hasn't been in the mempool for more than 2 minutes

In normal relay, over the course of two minutes we'd only advertise ~840 txs (~2100 for an outbound), and only add the txs to the bloom
...

💬 MarcoFalke commented on pull request "net processing: avoid serving non-announced txs as a result of a MEMPOOL message":
(https://github.com/bitcoin/bitcoin/pull/27602#discussion_r1193547718)
Whoops. I was incorrectly assuming that a reply to a `mempool` message was rate-limited and size-limited. (Which on a second thought, probably doesn't make sense to do). So a single reply can hold up to 50'000 inv entries, which will certainly overflow. Sorry for the distraction.

💬 kroese commented on issue "v25.0 testing":
(https://github.com/bitcoin/bitcoin/issues/27621#issuecomment-1547489470)
I have run into an issue where I cannot verify the signatures for test releases (like v24rc3 or v25rc2). When I execute:

`gpg --verify SHA256SUMS.asc SHA256SUMS`

It returns exitcode 2, while on the final releases it works fine.

What could be causing this behaviour? Or is it to be expected that test releases are not signed?

⚠️ GregTonoski opened an issue: ""Create Unsigned" should not show the message: "The amount exceeds you balance" without suggesting alternatives"
(https://github.com/bitcoin/bitcoin/issues/27659)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

"The amount exceeds you balance." error message after clicking "Create Unsigned" button even though there are funds on an address.



### Expected behaviour

A message about steps to workaround or solve the issue, e.g. "Balance must be above 0 in order to create PSBT. Do you want to s
...

💬 MarcoFalke commented on pull request "net processing: avoid serving non-announced txs as a result of a MEMPOOL message":
(https://github.com/bitcoin/bitcoin/pull/27602#discussion_r1193582239)
Side note: The 50k max inv size also seems to overflow, which is probably another source for false negatives, depending on the use case.

<img src=https://user-images.githubusercontent.com/19157360/235448790-6a1448bd-64b3-4c41-89d3-1ca5bf0cf76d.png></img>

Image stolen from the comment https://github.com/bitcoin/bitcoin/pull/27426#issuecomment-1529678174 by 0xB10C .

📝 fanquake opened a pull request: "[24.1] Final Changes"
(https://github.com/bitcoin/bitcoin/pull/27660)
Final changes for `v24.1`.
PR for bitcoincore.org is here: https://github.com/bitcoin-core/bitcoincore.org/pull/968.

👍 hebasto approved a pull request: "[24.1] Final Changes"
(https://github.com/bitcoin/bitcoin/pull/27660#pullrequestreview-1426164333)
ACK 89a5a416deac060fed8c21d4381c8f59da4f4187, I have reviewed the code and it looks OK.

👍 TheCharlatan approved a pull request: "ci: Remove CI_EXEC bloat"
(https://github.com/bitcoin/bitcoin/pull/27616#pullrequestreview-1426207043)
ACK fa01c3c59cbe28be0751c2956609907ecfbcbe49

🚀 fanquake merged a pull request: "ci: Remove CI_EXEC bloat"
(https://github.com/bitcoin/bitcoin/pull/27616)

👍 stickies-v approved a pull request: "[24.1] Final Changes"
(https://github.com/bitcoin/bitcoin/pull/27660#pullrequestreview-1426234284)
ACK 89a5a416deac060fed8c21d4381c8f59da4f4187

🚀 fanquake merged a pull request: "build, doc: Adjust comment after PR27254"
(https://github.com/bitcoin/bitcoin/pull/27656)

💬 fanquake commented on pull request "rpc: Add test-only RPC getaddrmaninfo for new/tried table address count":
(https://github.com/bitcoin/bitcoin/pull/27511#issuecomment-1547603057)
> I think that ideally we never should have exposed the terrible filter in the first place.

@mzumsande do you want to propose some changes to remove its exposure?

👍 TheCharlatan approved a pull request: "init: Error if ignored bitcoin.conf file is found"
(https://github.com/bitcoin/bitcoin/pull/27302#pullrequestreview-1426261194)
ACK 0319de5cbedd1a8f8766cfec61151c58b3fb27ef

🚀 fanquake merged a pull request: "Introduce `MockableDatabase` for wallet unit tests"
(https://github.com/bitcoin/bitcoin/pull/26715)

💬 MarcoFalke commented on pull request "test: Drop `deadlock:libdb` TSan suppression":
(https://github.com/bitcoin/bitcoin/pull/27658#issuecomment-1547639621)
Steps to reproduce on a fresh install of OpenSuse Tumbleweed (`registry.opensuse.org/opensuse/tumbleweed:latest`):


```
zypper in -y libevent-devel boost-devel sqlite3-devel libqt5-qttools-devel libqt5-qtbase-devel libdb-4_8-devel find bison gcc-c++ libtool make autoconf automake python3 clang llvm lbzip2 patch xz curl wget htop git vim ccache && git clone https://github.com/bitcoin/bitcoin.git --depth=1 ./bitcoin-core && cd bitcoin-core && ./autogen.sh && ./configure CC=cla
...

💬 fanquake commented on pull request "test: Drop `deadlock:libdb` TSan suppression":
(https://github.com/bitcoin/bitcoin/pull/27658#issuecomment-1547642636)
Concept NACK given the above.

💬 fanquake commented on pull request "init: add MALLOC_ARENA_MAX=1 to systemd":
(https://github.com/bitcoin/bitcoin/pull/27642#issuecomment-1547643907)
Note that internally we already set [`M_ARENA_MAX` to 1](https://github.com/bitcoin/bitcoin/blob/d02df7db6b3651a725fe35be42e3489e2d6b53a1/src/util/system.cpp#L70), but that is currently restricted to 32-bit systems. I would assume everyone reporting issues (#24542) is using on 64-bit. We may be at the point where we could just drop that code entirely.

🤔 stickies-v reviewed a pull request: "test: Return dict in MiniWallet::send_to"
(https://github.com/bitcoin/bitcoin/pull/27640#pullrequestreview-1426307846)
Concept ACK for moving away from a tuple return value. I think I'd prefer something more struct-like though, for example a `typing.NamedTuple`? Also, I don't see the point in returning `tx`, `wtxid`, and `hex` if no one is accessing them yet - can easily be added later on when needed?

💬 fanquake commented on issue ""Create Unsigned" should not show the message: "The amount exceeds you balance" without suggesting alternatives":
(https://github.com/bitcoin/bitcoin/issues/27659#issuecomment-1547651940)
> 25.0.1 rc1

This version doesn't exist?

> There might have been similar issue reported: https://github.com/bitcoin-core/gui/issues/83

Given there is already what looks like a similar issue, might be better to continue the discussion there? GUI issues should be opened on the GUI repo: https://github.com/bitcoin-core/gui.