💬 hebasto commented on pull request "kernel: Remove interface_ui, util/system from kernel library":
(https://github.com/bitcoin/bitcoin/pull/27636#discussion_r1193161217)
Should these methods be non-`const`?

💬 hebasto commented on pull request "kernel: Remove interface_ui, util/system from kernel library":
(https://github.com/bitcoin/bitcoin/pull/27636#discussion_r1193161280)
nit: EOL?

💬 ishaanam commented on pull request "wallet: when a block is disconnected, update transactions that are no longer conflicted":
(https://github.com/bitcoin/bitcoin/pull/27145#issuecomment-1546917869)
I've fixed a bug which resulted in the conflicted tx not being marked as inactive if the conflicting tx was not in `mapTxSpends`.

💬 ishaanam commented on pull request "wallet: when a block is disconnected, update transactions that are no longer conflicted":
(https://github.com/bitcoin/bitcoin/pull/27145#discussion_r1193162426)
There are some tests for that here: https://github.com/bitcoin/bitcoin/blob/master/test/functional/wallet_resendwallettransactions.py. Or did you mean that a test for that should be added for this PR specifically?

💬 TheCharlatan commented on pull request "kernel: Remove interface_ui, util/system from kernel library":
(https://github.com/bitcoin/bitcoin/pull/27636#discussion_r1193165783)
Yes, as far as I am aware, `const` virtual methods are bad practice. See: https://github.com/bitcoin/bitcoin/pull/25337#discussion_r916367659.

⚠️ bleeee opened an issue: "v0.6.5 on iPad mini 6 Security Center button incorrent"
(https://github.com/bitcoin/bitcoin/issues/27654)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

v0.6.5 on iPad mini 6 Security Center button incorrent

2FA button is actually app password
app password button is wall set pass phrase

all wallet encryption button is biometrics

### Expected behaviour

corrention buttons

### Steps to reproduce

press any button in secrity center

### Relevant log output

_No response_

### How did you obtain Bitcoin Core

Compiled from source

###
...

✅ fanquake closed an issue: "v0.6.5 on iPad mini 6 Security Center button incorrent"
(https://github.com/bitcoin/bitcoin/issues/27654)

⚠️ kallerosenbaum opened an issue: "Can't start bitcoin-qt by double-click on linux"
(https://github.com/bitcoin/bitcoin/issues/27655)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

When I double-click the bitcoin-qt file executable file in the graphical file manager, Bitcoin Core doesn't start and this message pops up:


I think this issue is the same as described at https://fostips.com/double-click-run-elf-ubuntu/
The Bitcoin Core build
...

📝 hebasto opened a pull request: "build, doc: Adjust comment after PR27254"
(https://github.com/bitcoin/bitcoin/pull/27656)
This is a follow up for https://github.com/bitcoin/bitcoin/pull/27254.

💬 TheCharlatan commented on pull request "kernel: Remove interface_ui, util/system from kernel library":
(https://github.com/bitcoin/bitcoin/pull/27636#issuecomment-1546926451)
Thank you for the review @hebasto,

Updated 63e915af5a437d36abdd79a1b90fed2395086589 -> 97b0e28d6f5e86e8c7ee0775d22cd923dabca09d ([chainstateRmKernelUiInterface_1](https://github.com/TheCharlatan/bitcoin/commits/chainstateRmKernelUiInterface_1) -> [chainstateRmKernelUiInterface_2](https://github.com/TheCharlatan/bitcoin/commits/chainstateRmKernelUiInterface_2), [compare](https://github.com/TheCharlatan/bitcoin/compare/chainstateRmKernelUiInterface_1..chainstateRmKernelUiInterface_2)).

* Add
...

💬 kallerosenbaum commented on issue "Can't start bitcoin-qt by double-click on linux":
(https://github.com/bitcoin/bitcoin/issues/27655#issuecomment-1546927537)
I also tested Bitcoin Core 24.0.1 on Ubuntu 22.04.2 LTS, and I could double click bitcoin-qt to start it there.

💬 hebasto commented on issue "Can't start bitcoin-qt by double-click on linux":
(https://github.com/bitcoin/bitcoin/issues/27655#issuecomment-1546930882)
It seems like a Debian-specific problem, as I have no such an issue on Ubuntu (22.04, 23.04) with the downloaded binaries (v24.01, v25.0rc2).

Going to investigate further.

👍 TheCharlatan approved a pull request: "build, doc: Adjust comment after PR27254"
(https://github.com/bitcoin/bitcoin/pull/27656#pullrequestreview-1425572673)
ACK 3ece0ebf627ee569a9680bf2663697db7a6ae309

👍 TheCharlatan approved a pull request: "Introduce `MockableDatabase` for wallet unit tests"
(https://github.com/bitcoin/bitcoin/pull/26715#pullrequestreview-1425572973)
ACK 33e2b82a4fc990253ff77655f437c7aed336bc55

💬 hebasto commented on issue "Can't start bitcoin-qt by double-click on Debian 11":
(https://github.com/bitcoin/bitcoin/issues/27655#issuecomment-1546935424)
Well, I have:
```
$ file -i bitcoin-24.0.1/bin/bitcoin-qt
bitcoin-24.0.1/bin/bitcoin-qt: application/x-pie-executable; charset=binary
```

The mime type looks correct.

💬 hebasto commented on issue "Can't start bitcoin-qt by double-click on Debian 11":
(https://github.com/bitcoin/bitcoin/issues/27655#issuecomment-1546936299)
Just to double check, do you have the [`libxcb-xinerama0`](https://packages.debian.org/bullseye/libxcb-xinerama0) package installed on your system?

💬 hebasto commented on issue "Can't start bitcoin-qt by double-click on Debian 11":
(https://github.com/bitcoin/bitcoin/issues/27655#issuecomment-1546936991)
Could be related:
- https://github.com/mate-desktop/caja/issues/1164

💬 kallerosenbaum commented on issue "Can't start bitcoin-qt by double-click on Debian 11":
(https://github.com/bitcoin/bitcoin/issues/27655#issuecomment-1546938092)
You should right click it and view options in the graphical file manager. What does the mime type say for you there? Here's mine:

And I have the same result as you using `file`:
```
$ file -i bitcoin-qt
bitcoin-qt: application/x-pie-executable; charset=binary
```

> do you have the [libxcb-xinerama0](https://packages.debian.org/bullseye/libxcb-xinerama0) package installed on your system?

...

💬 hebasto commented on issue "Can't start bitcoin-qt by double-click on Debian 11":
(https://github.com/bitcoin/bitcoin/issues/27655#issuecomment-1546939182)
On Ubuntu 22.04:

---

FWIW, there were two PRs that aimed improving `bitcoin-qt` launch UX improvements:
- https://github.com/bitcoin/bitcoin/pull/15068
- https://github.com/bitcoin-core/gui/pull/38

🤔 hebasto reviewed a pull request: "kernel: Remove interface_ui, util/system from kernel library"
(https://github.com/bitcoin/bitcoin/pull/27636#pullrequestreview-1425576361)
Approach ACK 97b0e28d6f5e86e8c7ee0775d22cd923dabca09d.

In d84952cd64bd03ce444bbf6077d060c92526d040 commit message:
s/"to FatalError"/"to FatalErrorf"/

Maybe make it a scripted-diff?