💬 ishaanam commented on pull request "wallet: be able to specify a wallet name and passphrase to migratewallet":
(https://github.com/bitcoin/bitcoin/pull/26595#discussion_r1103485473)
nit:
```suggestion
// If the wallet is still loaded, unload it so that nothing else tries to use it while we're changing it
```

💬 davidgumberg commented on pull request "refactor: Move coin_control variable to test setup section":
(https://github.com/bitcoin/bitcoin/pull/26154#issuecomment-1426612195)
ACK https://github.com/bitcoin/bitcoin/commit/d98c39a1274bfcab3935ffdb75165abf85073e88

💬 codo1 commented on pull request "Modernize rpcauth.py":
(https://github.com/bitcoin/bitcoin/pull/27081#issuecomment-1426626622)
tACK
Tested as follows: generated new userpw using an explicit password. Used it on signet through an RPC request (checked I got 'incorrect password attempt' if I changed the userpw a bit).

📝 TysonsTech opened a pull request: "Minor edits - punctuation, spelling to make the contributing instructions more readable for all. "
(https://github.com/bitcoin/bitcoin/pull/27082)
Greetings - Wanted to ease into my first Bitcoin core contribution with some text updates. Small changes but I think the doc reads a bit better. Cheers!

💬 1440000bytes commented on pull request "mempool: Increase mempool default size":
(https://github.com/bitcoin/bitcoin/pull/27079#issuecomment-1426640141)

📝 hebasto opened a pull request: "ci: Improve `ccache` cache hit rates"
(https://github.com/bitcoin/bitcoin/pull/27083)
Changes that are not affecting binaries, e.g., #27070 or #27072, are expected to show up to 100% `ccache` hit rate. But that is not the case:
- https://cirrus-ci.com/build/4720733276864512
- https://cirrus-ci.com/build/5915469295648768

Zero hit rate in the "macOS 10.15" is well [known](https://github.com/bitcoin/bitcoin/issues/21552). But a [fix](https://github.com/bitcoin/bitcoin/pull/24620) was [considered](https://github.com/bitcoin/bitcoin/pull/24620#issuecomment-1100850691) not "a good
...

💬 hebasto commented on pull request "ci: Improve `ccache` cache hit rates":
(https://github.com/bitcoin/bitcoin/pull/27083#issuecomment-1426664401)
Drafted for now as I'm going to demonstrate benefits of this PR by re-running CI twice. First time with cleaned caches, and second one to ensure higher hit rates.

💬 Sjors commented on pull request "p2p, validation: Don't download witnesses for assumed-valid blocks when running in prune mode":
(https://github.com/bitcoin/bitcoin/pull/27050#issuecomment-1426676349)
One thing we could do to mitigate the concern of missing witness data, is to download it for a small random sample of blocks. When that fails, we fall back to redownloading _all_ witness data (which would presumably also fail). So in a scenario where witness data is really gone, pruned nodes will behave the same as unpruned nodes during IBD.

💬 Sjors commented on pull request "consensus: Remove mainnet checkpoints":
(https://github.com/bitcoin/bitcoin/pull/25725#discussion_r1103582363)
I think it's fine to drop the checkpoints in one release and then drop the checkpoint logic in a later release.

💬 bipulkmr-crypto commented on issue "Check usages of `#if defined(...)`":
(https://github.com/bitcoin/bitcoin/issues/16419#issuecomment-1426679579)
Is this issue up for grab?

💬 Sjors commented on pull request "test: p2p: check that headers message with invalid proof-of-work disconnects peer":
(https://github.com/bitcoin/bitcoin/pull/26184#issuecomment-1426685146)
ACK 772671245d50d94fd5087deb2542854604eba174

📝 hebasto converted_to_draft a pull request: "ci: Make `ccache` hashing content of compiler binary"
(https://github.com/bitcoin/bitcoin/pull/27077)
By default, `ccache` includes the modification time (`mtime`) and size of the compiler in the hash to ensure that results retrieved from the cache are accurate. But in CI environment compiler's `mtime` can be unique each run.

Effectively, this PR fixes https://github.com/bitcoin/bitcoin/pull/27063#issuecomment-1423901418:
> Looks like ccache isn't working here
>
> https://cirrus-ci.com/task/4571293245243392?logs=ci#L4178

👋 hebasto's pull request is ready for review: "ci: Make `ccache` hashing content of compiler binary"
(https://github.com/bitcoin/bitcoin/pull/27077)

💬 Sjors commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#issuecomment-1426688833)
We should add a warning in the release notes that, although you can safely downgrade the node, you should _not_ encrypt the wallet while using that older version. And add a test that shows what happens.

📝 hebasto converted_to_draft a pull request: "ci: Make `ccache` hashing content of compiler binary"
(https://github.com/bitcoin/bitcoin/pull/27077)
By default, `ccache` includes the modification time (`mtime`) and size of the compiler in the hash to ensure that results retrieved from the cache are accurate. But in CI environment compiler's `mtime` can be unique each run.

Effectively, this PR fixes https://github.com/bitcoin/bitcoin/pull/27063#issuecomment-1423901418:
> Looks like ccache isn't working here
>
> https://cirrus-ci.com/task/4571293245243392?logs=ci#L4178

💬 taxmeifyoucan commented on pull request "mempool: Increase mempool default size":
(https://github.com/bitcoin/bitcoin/pull/27079#issuecomment-1426700198)
Concept ACK. We saw mempool being filled multiple times before and bigger size might help with spikes. But bumping it 3x seems like a bit step even considering average RAM. 400-500MB would be still fairly conservative but provide significant help with transaction spikes.

💬 kristapsk commented on pull request "mempool: Increase mempool default size":
(https://github.com/bitcoin/bitcoin/pull/27079#issuecomment-1426702510)
Maybe good start would be to discuss first changing defaults in Bitcoin full node distributions like RaspiBolt, RaspiBlitz, Umbrel, etc...?

💬 Sjors commented on pull request "multiprocess: Add bitcoin-gui -ipcconnect option":
(https://github.com/bitcoin/bitcoin/pull/19461#issuecomment-1426706198)
> What was the magic incantation again to tunnel a unix socket over SSH? I'll try if I can run the GUI on a different machine than the node.

On an Ubuntu 22.10 machine I ran `src/bitcoin-node -ipcbind=unix:///tmp/node.sock`. I then opened an SSH connection: `ssh -L/tmp/remote-node.sock:/tmp/node.sock ubuntu`. And then on the mac I connected the GUI: `src/bitcoin-gui -ipconnect=unix:///tmp/remote-node.sock`


I connected just after the node caught up on old blocks. It had the most recent b
...

📝 hebasto opened a pull request: "ci: A few fixes of `ccache` issues"
(https://github.com/bitcoin/bitcoin/pull/27084)
Combined https://github.com/bitcoin/bitcoin/pull/27077 and https://github.com/bitcoin/bitcoin/pull/27083.

✅ hebasto closed a pull request: "ci: Make `ccache` hashing content of compiler binary"
(https://github.com/bitcoin/bitcoin/pull/27077)