💬 achow101 commented on pull request "[23.2] Backports for rc1":
(https://github.com/bitcoin/bitcoin/pull/27624#issuecomment-1544400457)
ACK a26ff204f0f0355749a1b61136437623b325f8fb

Diffs match as expected

💬 achow101 commented on pull request "[25.0] Backports for rc2":
(https://github.com/bitcoin/bitcoin/pull/27613#issuecomment-1544400861)
ACK 7ef71e30c9bc108e29dec008490db5a0fa051629

👍 hebasto approved a pull request: "wallet: fix deadlock in bdb read write operation"
(https://github.com/bitcoin/bitcoin/pull/27556#pullrequestreview-1423109956)
Approach ACK de202f860b3f79774d5235dec59a140fa5c82fa7.

💬 fanquake commented on pull request "[25.0] Backports for rc2":
(https://github.com/bitcoin/bitcoin/pull/27613#issuecomment-1544404869)
Added a version bump for `25.0rc2`.

💬 ryanofsky commented on pull request "refactor: Add util::Result failure values, multiple error and warning messages":
(https://github.com/bitcoin/bitcoin/pull/25665#issuecomment-1544405658)
Thanks for the review.

Note: @martinus left several review comments on https://github.com/bitcoin/bitcoin/pull/25722#pullrequestreview-1386736519, which is based on this PR, which apply to this PR and can improve it a little. I'm planning to update this PR to incorporate the suggestions.

💬 pinheadmz commented on pull request "net: call getaddrinfo() in detachable thread to prevent stalling":
(https://github.com/bitcoin/bitcoin/pull/27557#discussion_r1191495146)
TIL I can probably replace this with `std::atomic_bool`

💬 glozow commented on pull request "rpc: allow submitpackage to be called outside of regtest":
(https://github.com/bitcoin/bitcoin/pull/27609#issuecomment-1544414801)
> without https://github.com/bitcoin/bitcoin/pull/26711 we are still letting things into mempool that are possibly problematic, no?

You're right. Every time we think about it a bit longer, another not-quite-ideal edge case comes up. Especially with full mempools and eviction being something to consider.

I think it was too early to open this. I've pushed a change to disallow any dependency between parents, which is where all these stupid edge cases come from (but is probably not a comon use
...

💬 pinheadmz commented on pull request "indexes: Read the locator's top block during init, allow interaction with reindex-chainstate":
(https://github.com/bitcoin/bitcoin/pull/25193#discussion_r1191500724)
Another side effect of this PR is I don't think we use the `locator` at all anymore besides its tip hash ?!

✅ glozow closed a pull request: "rpc: allow submitpackage to be called outside of regtest"
(https://github.com/bitcoin/bitcoin/pull/27609)

💬 fanquake commented on issue "One core in CPU usage rate remains at 100% for a long time, causing serious delays in new blocks and forks":
(https://github.com/bitcoin/bitcoin/issues/27623#issuecomment-1544419927)
@huzhenyuan Thanks for reporting. As mentioned, Bitcoin Core version 24.1 will be available shortly, and contains some mitigations for the issues you are seeing. I'm going to close this issue for now, as similar/related-to #27586.

✅ fanquake closed an issue: "One core in CPU usage rate remains at 100% for a long time, causing serious delays in new blocks and forks"
(https://github.com/bitcoin/bitcoin/issues/27623)

💬 achow101 commented on pull request "[25.0] Backports for rc2":
(https://github.com/bitcoin/bitcoin/pull/27613#issuecomment-1544422960)
ACK 49a2d66f4e3a01aa697c1b9e5994fd8300953951

💬 achow101 commented on pull request "doc: remove version number from bips.md":
(https://github.com/bitcoin/bitcoin/pull/27629#issuecomment-1544424385)
ACK 308caf326db5619141f0c224fa48410293d59330

Remembering to do this for every release is quite annoying.

🚀 achow101 merged a pull request: "doc: remove version number from bips.md"
(https://github.com/bitcoin/bitcoin/pull/27629)

💬 glozow commented on pull request "rpc: allow submitpackage to be called outside of regtest":
(https://github.com/bitcoin/bitcoin/pull/27609#discussion_r1191507748)
Done in #26711

💬 glozow commented on pull request "rpc: allow submitpackage to be called outside of regtest":
(https://github.com/bitcoin/bitcoin/pull/27609#discussion_r1191508134)
Replaced with carats https://github.com/bitcoin/bitcoin/compare/0cdb25a2392328afaad7651a0a407396b1922f17..f4e449254e41172b09a41ed9b2cc5c5fe3a5edca

💬 glozow commented on pull request "rpc: allow submitpackage to be called outside of regtest":
(https://github.com/bitcoin/bitcoin/pull/27609#discussion_r1191508377)
Done in #26711 (https://github.com/bitcoin/bitcoin/compare/0cdb25a2392328afaad7651a0a407396b1922f17..f4e449254e41172b09a41ed9b2cc5c5fe3a5edca)

💬 instagibbs commented on pull request "rpc: allow submitpackage to be called outside of regtest":
(https://github.com/bitcoin/bitcoin/pull/27609#issuecomment-1544429056)
IsChildWithParentsTree <---- is this originally what the V3 topo looked like?

💬 pinheadmz commented on pull request "indexes: Read the locator's top block during init, allow interaction with reindex-chainstate":
(https://github.com/bitcoin/bitcoin/pull/25193#issuecomment-1544432693)
> In first commit vector `front()` call is replaced by `at(0)` call to avoid undefined behavior in case null locator is loaded.

This happens again later too:

https://github.com/bitcoin/bitcoin/blob/974140f9e721740f857b45d10d7dbab62fdbbe53/src/index/base.cpp#L100

💬 brunoerg commented on pull request "Improve performance of p2p inv to send queues":
(https://github.com/bitcoin/bitcoin/pull/27610#discussion_r1191512898)
Cool, @glozow.