✅ fanquake closed an issue: "Write access to Testing Guide for 29.0 RC"
(https://github.com/bitcoin/bitcoin/issues/32102)

💬 fanquake commented on issue "Write access to Testing Guide for 29.0 RC":
(https://github.com/bitcoin/bitcoin/issues/32102#issuecomment-2742452052)
Added.

💬 TheCharlatan commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-2742479648)
> Maybe I need to think about it more, but I don't see how a similar process could play out between the C++ API and the C bindings, or how there could be other benefits to the C++ code from just maintaining the C bindings. I could see there being benefits from developing the bindings, but would expect those to be the same regardless of repository layout.

I think I was conflating the introduction of some consolidating code here, like a separate context, methods that map to multiple calls to ou
...

💬 maflcko commented on pull request "ci: run test-each-commit on merge to master":
(https://github.com/bitcoin/bitcoin/pull/32103#issuecomment-2742553313)
> Would it not in that case be simpler to checkout the PR `HEAD` commit, fetch and rebase onto master

Again, I don't think this is possible.

In your example the rebase succeeds, because it is not needed. See:

```
git pull --rebase origin master
From https://github.com/willcl-ark/bitcoin
* branch master -> FETCH_HEAD
Current branch dummy-branch is up to date.
```

However, in the general case, it is not possible to rebase all commits of all pull requests on
...

💬 fanquake commented on pull request "build: Drop option to disable hardening.":
(https://github.com/bitcoin/bitcoin/pull/32071#issuecomment-2742557455)
@davidgumberg want to rebase here?

💬 fanquake commented on pull request "refactor: Remove redundant and confusing calls to IsArgSet":
(https://github.com/bitcoin/bitcoin/pull/31896#issuecomment-2742558962)
@ryanofsky Want to take another look?

💬 fanquake commented on pull request "wallet: removed duplicate call to GetDescriptorScriptPubKeyMan":
(https://github.com/bitcoin/bitcoin/pull/32023#issuecomment-2742562905)
https://cirrus-ci.com/task/5112314648592384?logs=ci#L5356:
```bash
[01:20:03.641] Run scriptpubkeyman with args ['/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/bin/fuzz', '-runs=1', PosixPath('/ci_container_base/ci/scratch/qa-assets/fuzz_corpora/scriptpubkeyman')]INFO: Running with entropic power schedule (0xFF, 100).
[01:20:03.641] INFO: Seed: 2231869594
[01:20:03.641] INFO: Loaded 1 modules (623423 inline 8-bit counters): 623423 [0x556e6d276398, 0x556e6d30e6d7),
[01:20:03.641
...

🚀 fanquake merged a pull request: "torcontrol: Limit reconnect timeout to max seconds and log delay in whole seconds"
(https://github.com/bitcoin/bitcoin/pull/31979)

💬 maflcko commented on issue "Source code mapping for debugger has changed since cmake":
(https://github.com/bitcoin/bitcoin/issues/31204#issuecomment-2742587668)
> I find it okay to have to set a mapping for the root directory, but I currently need things like:
>
> ```
> "/home/hodlinator/b2/build/src/test/util/test/util/": "/home/hodlinator/b2/src/test/util/"
> ```
>
> Note how the subdirectory needs to be repeated for it to work: `test/util/test/util/`
>
> Same thing happened for rkrux [above](https://github.com/bitcoin/bitcoin/issues/31204#issuecomment-2681660181):
>
> ```
> ...valid location was found at /Users/rkrux/projects/bitcoin/build/src/wa
...

💬 ajtowns commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#issuecomment-2742606528)
> Can this get surfaced in the fuzz coverage with something that would previously fail?

As long as you actually run the fuzz binary with your changes, and not the fuzz binary in the old location that you compiled a few days ago (*cough*), the following should work:

```diff
--- a/src/test/fuzz/txgraph.cpp
+++ b/src/test/fuzz/txgraph.cpp
@@ -723,4 +723,6 @@ FUZZ_TARGET(txgraph)

// Sanity check again (because invoking inspectors may modify internal unobservable state).
real->
...

🚀 fanquake merged a pull request: "qa: fix an off-by-one in utxo snapshot fuzz target and sanity check its snapshot data"
(https://github.com/bitcoin/bitcoin/pull/31910)

💬 fanquake commented on pull request "fuzz: split `coinselection` harness":
(https://github.com/bitcoin/bitcoin/pull/31870#issuecomment-2742718818)
cc @dergoegge

💬 fanquake commented on pull request "fuzz: coinselection: cover `SetBumpFeeDiscount`":
(https://github.com/bitcoin/bitcoin/pull/31806#issuecomment-2742720048)
cc @marcofleon

💬 fanquake commented on pull request "miniscript: account for all `StringType` variants in `Miniscriptdescriptor::ToString()`":
(https://github.com/bitcoin/bitcoin/pull/31734#issuecomment-2742725629)
cc @darosior

💬 maflcko commented on pull request "fuzz: split `coinselection` harness":
(https://github.com/bitcoin/bitcoin/pull/31870#issuecomment-2742747821)
review ACK ba82240553ddd534287845e10bc76b46b45329fe 👐

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK ba82240553dd
...

⚠️ Davidoff2778 opened an issue: "Vytvořit žádost o podporu | Kapesní možnost"
(https://github.com/bitcoin/bitcoin/issues/32108)
https://m.pocketoption.com/en/cabinet/support/create?o=10,31,85&a=form&field=deposit_id&id=68233033

💬 BrandonOdiwuor commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2742830552)
@maflcko The assumption was, providing default signet challenge is not so useful as it would result in the loss of default the signet configurations, hence did not include the check

https://github.com/bitcoin/bitcoin/blob/2db00278ea571d0f734609f9fefecfa75c16ee34/src/kernel/chainparams.cpp#L393-L408

✅ willcl-ark closed an issue: "Vytvořit žádost o podporu | Kapesní možnost"
(https://github.com/bitcoin/bitcoin/issues/32108)

:lock: fanquake locked an issue: "Vytvořit žádost o podporu | Kapesní možnost"
(https://github.com/bitcoin/bitcoin/issues/32108)

🤔 Sjors reviewed a pull request: "multiprocess: add bitcoin-mine test program"
(https://github.com/bitcoin/bitcoin/pull/30437#pullrequestreview-2705328965)
Code reviewed 5554f9cb4abf7e1852dd79d2d75e714fa8cbeadd.

Rebase looks good, but found a bug in the test.