Bitcoin Core Github
44 subscribers
120K links
Download Telegram
💬 willcl-ark commented on pull request "BIP-119 (OP_CHECKTEMPLATEVERIFY) (no activation)":
(https://github.com/bitcoin/bitcoin/pull/31989#issuecomment-2701106684)
@jamesob I'd be happy to help you keep this thread focused by moderating off-topic comments and pointing them to the appropriate forums.

You've suggested and linked to Delving which seems appropriate for general/conceptual discussion, however there is no thread/post over there to actually point folks to.
Would you mind starting a thread over there so that we have somewhere concrete to point these types of discussions to?
hebasto closed an issue: "build: macOS fuzz instructions broken using latest macOS linker"
(https://github.com/bitcoin/bitcoin/issues/31049)
🚀 hebasto merged a pull request: "doc: update fuzz instructions when on macOS"
(https://github.com/bitcoin/bitcoin/pull/31954)
💬 hebasto commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2701126873)
> [@hebasto's](https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2675061518) are in a different order/selected differently, but the ones I manually checked seem to match...

Here is my shell command:
```sh
find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
```
💬 Sjors commented on pull request "Add waitNext() to BlockTemplate interface":
(https://github.com/bitcoin/bitcoin/pull/31283#issuecomment-2701132902)
@ryanofsky what would be a good way for a consumer of `waitNext()`, directly or via IPC, to abort a wait? Currently only a node shutdown can interrupt it, but in the context of a Template Provider, a stratum client disconnect should probably also abort the wait.
fanquake closed an issue: "Improve description of the `filename` parameter of `loadwallet` RPC"
(https://github.com/bitcoin/bitcoin/issues/30269)
💬 fanquake commented on issue "Improve description of the `filename` parameter of `loadwallet` RPC":
(https://github.com/bitcoin/bitcoin/issues/30269#issuecomment-2701134084)
Closing, given #30302 has been merged.
💬 hebasto commented on issue "Source code mapping for debugger has changed since cmake":
(https://github.com/bitcoin/bitcoin/issues/31204#issuecomment-2701137950)
@hodlinator

Mind submitting a PR?
👍 hodlinator approved a pull request: "ci: Test cross-built Windows executables on Windows natively"
(https://github.com/bitcoin/bitcoin/pull/31176#pullrequestreview-2661348106)
re-ACK 515c64c743d581f84b8be45e5d16968d02264389

- Great that @davidgumberg caught the disrespected exit codes.
- Thanks for adjusting the names!

Realized we also have "macOS-cross, gui, no tests" on Cirrus. Might be nice to also have the equivalent "macOS, test cross-built"?
The Linux/Mac delta is smaller and the compilers the same so probably not as useful in practice.
👍 theStack approved a pull request: "doc: update location of minisketch repository"
(https://github.com/bitcoin/bitcoin/pull/31997#pullrequestreview-2661348628)
ACK 972b604dc423f4a2212f5460d08a7f759ea44311
🚀 fanquake merged a pull request: "doc: update location of minisketch repository"
(https://github.com/bitcoin/bitcoin/pull/31997)
💬 hodlinator commented on issue "Source code mapping for debugger has changed since cmake":
(https://github.com/bitcoin/bitcoin/issues/31204#issuecomment-2701167796)
Any idea where to start looking for the duplicate subdirectory issue? Where do we get the virtual build/src/ paths to begin with?
💬 Prabhat1308 commented on issue "Fuzz: Runtime errors when running fuzz tests on MacOs":
(https://github.com/bitcoin/bitcoin/issues/31591#issuecomment-2701190778)
> @Prabhat1308 is your issue solved after using the new steps in #31954?

Yes . No errors now .
fanquake closed an issue: "Fuzz: Runtime errors when running fuzz tests on MacOs"
(https://github.com/bitcoin/bitcoin/issues/31591)
💬 sipa commented on pull request "kernel: pre-29.x chainparams and headerssync update":
(https://github.com/bitcoin/bitcoin/pull/31978#issuecomment-2701196446)
Note that `du -h` produces 1024-based units, while `m_assumed_blockchain_size` and `m_assumed_chain_state_size` expect multiples of 10^9 bytes, which means adding 4.8% to `M` results, and 7.4% to `G` results.
👍 willcl-ark approved a pull request: "[28.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/31648#pullrequestreview-2661414388)
ACK e57359c7dd75283363b5f82675531af167742da5

Now with nits addressed.
📝 fanquake opened a pull request: "depends: patch around PlacementNew issue in capnp"
(https://github.com/bitcoin/bitcoin/pull/31998)
See #31772 and https://github.com/capnproto/capnproto/pull/2235.

Given there isn't agreement in #29796, pulled this out so it could be merged separately, and it's easier to run different test configurations externally.

Closes #31772.
glozow closed an issue: "Intermittent failures in interface_usdt_mempool.py"
(https://github.com/bitcoin/bitcoin/issues/27380)
🚀 glozow merged a pull request: "test, tracing: don't use problematic `bpf_usdt_readarg_p()`"
(https://github.com/bitcoin/bitcoin/pull/31848)
⚠️ fanquake opened an issue: "build: document `BITCOIN_GENBUILD_NO_GIT` environment variable?"
(https://github.com/bitcoin/bitcoin/issues/31999)
This was ported from Autotools, however it's entirely undocumented, so it's unclear what we are trying to support, or why (and if we can just drop this entirely). It'd be good if it was documented, even just inline in the source: https://github.com/bitcoin/bitcoin/blob/36d4bd7fe326ba69e9372f8ddb3b12a3b5b36a3d/cmake/script/GenerateBuildInfo.cmake#L33 so it's more clear what the use-case is.

Note that as-of `29.x`, the ways we distribute our source code will be via git clone, or using a tarball t
...