💬 luke-jr commented on pull request "rpc: add cli examples, update docs":
(https://github.com/bitcoin/bitcoin/pull/31958#discussion_r1976442528)
We shouldn't be encouraging this in the first place. Suggest replacing the example with yours.

📝 Sjors opened a pull request: "Add mainnet assumeutxo param at height 880,000"
(https://github.com/bitcoin/bitcoin/pull/31969)
#31940 suggests adding a snapshot at every major release.

This snapshot should be suitable for v29. I picked the most recent multiple of 10K blocks.

I'll upload a torrent later. You can generate the snapshot yourself:

```sh
bitcoin-cli -rpcclienttimeout=0 -named dumptxoutset utxo-880000.dat rollback=880000
```

And then load it on a fresh node during IBD with:

```
bitcoin-cli -rpcclienttimeout=0 loadtxoutset utxo-880000.dat
```

Note that it's more performant to turn off netw
...

💬 Sjors commented on pull request "Add assumeutxo chainparams to release-process.md":
(https://github.com/bitcoin/bitcoin/pull/31940#issuecomment-2692296552)
See #31969 for a potential v29 snapshot.

💬 yancyribbens commented on pull request "test: Add expected result assertions":
(https://github.com/bitcoin/bitcoin/pull/31656#issuecomment-2692332226)
@murchandamus sounds good. I added your suggestion to the test description and updated the commit message accordingly. Also rebased to make testing easier.

⚠️ RodrigoCamposDS opened an issue: "Bitcoin Core MacOS - Possible Miner Infection - Bitcoin Core MacOS - Possível Infecção por Minerador"
(https://github.com/bitcoin/bitcoin/issues/31970)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

🇺🇸

Subject: 🚨 Bitcoin Core for MacOS - Possible Miner Infection 🚨

Dear Bitcoin Core developers,

I downloaded the Bitcoin Core software directly from the official website (bitcoincore.org) for macOS, and my antivirus detected a possible malware embedded in the program.

Avast identified the file as MacOS:Miner-AR [PUP], and after checking on VirusTotal, several other antivirus progra
...

👍 hodlinator approved a pull request: "doc: Update documentation to include Clang/llvm based coverage report generation"
(https://github.com/bitcoin/bitcoin/pull/31933#pullrequestreview-2652570456)
ACK 1245e05325b41101eddc76ba9214d910489e35b6

- Good to include some comments on expected warnings (I was getting some too).
- Thanks for incorporating my latest feedback!
- Agree that functional/fuzz test instructions could either be a separate PR or left as an exercise to the reader.

💬 hodlinator commented on pull request "doc: Update documentation to include Clang/llvm based coverage report generation":
(https://github.com/bitcoin/bitcoin/pull/31933#discussion_r1976483663)
nit: Could shorten PR title. (Doesn't invalidate ACKs).
```diff
-doc: Update documentation to include Clang/llvm based coverage report generation
+doc: Add Clang/LLVM based coverage report generation
```

🤔 janb84 reviewed a pull request: "doc: Update documentation to include Clang/llvm based coverage report generation"
(https://github.com/bitcoin/bitcoin/pull/31933#pullrequestreview-2652573782)
re ACK [1245e05](https://github.com/bitcoin/bitcoin/commit/1245e05325b41101eddc76ba9214d910489e35b6)

The extra comments are informative of the possible warnings and their influence on the result.

💬 janb84 commented on pull request "doc: Update documentation to include Clang/llvm based coverage report generation":
(https://github.com/bitcoin/bitcoin/pull/31933#discussion_r1976485591)
Small nit, creating a blockquote note remark section is maybe more fitting:

> Note: The "counter mismatch" warning can be safely ignored, though it can be resolved by updating to Clang 19.\
> The warning occurs due to version mismatches but doesn't affect the coverage report generation.

💬 janb84 commented on pull request "test: Add expected result assertions":
(https://github.com/bitcoin/bitcoin/pull/31656#issuecomment-2692401596)
re ACK [a015b7e](https://github.com/bitcoin/bitcoin/commit/a015b7e13daacdfb6db0eada50563dec70c5afb2)

✅ RodrigoCamposDS closed an issue: "Bitcoin Core MacOS - Possible Miner Infection - Bitcoin Core MacOS - Possível Infecção por Minerador"
(https://github.com/bitcoin/bitcoin/issues/31970)

⚠️ RodrigoCamposDS reopened an issue: "Bitcoin Core MacOS - Possible Miner Infection - Bitcoin Core MacOS - Possível Infecção por Minerador"
(https://github.com/bitcoin/bitcoin/issues/31970)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

🇺🇸

Subject: 🚨 Bitcoin Core for MacOS - Possible Miner Infection 🚨

Dear Bitcoin Core developers,

I downloaded the Bitcoin Core software directly from the official website (bitcoincore.org) for macOS, and my antivirus detected a possible malware embedded in the program.

Avast identified the file as MacOS:Miner-AR [PUP], and after checking on VirusTotal, several other antivirus progra
...

🤔 hodlinator reviewed a pull request: "Add assumeutxo chainparams to release-process.md"
(https://github.com/bitcoin/bitcoin/pull/31940#pullrequestreview-2652580681)
Concept ACK

Should we also add a later step in the release process for the actual generation of the assumeutxo snapshot, maybe referencing *doc/assumeutxo.md*?

💬 hodlinator commented on pull request "Add assumeutxo chainparams to release-process.md":
(https://github.com/bitcoin/bitcoin/pull/31940#discussion_r1976492053)
Must be holding it wrong, but the `gettxoutsetinfo`-RPC isn't allowing me to specify both a `hash_type` and block height?

💬 willcl-ark commented on pull request "Add assumeutxo chainparams to release-process.md":
(https://github.com/bitcoin/bitcoin/pull/31940#issuecomment-2692422674)
We could do. Sjors has a tidy command in the linked PR.

💬 Julian128 commented on issue "Bitcoin Core MacOS - Possible Miner Infection - Bitcoin Core MacOS - Possível Infecção por Minerador":
(https://github.com/bitcoin/bitcoin/issues/31970#issuecomment-2692423629)
you should verify your downloads or build from source and probably not use any of these antiviruses

👍 hodlinator approved a pull request: "Add mainnet assumeutxo param at height 880,000"
(https://github.com/bitcoin/bitcoin/pull/31969#pullrequestreview-2652599416)
ACK 14f16748557faf57cf4b0f4c91c162592557434c

Thanks for doing this.

<details><summary>Testing procedure</summary>

(Testing performed at commit 8b5a50cb353d9524db38a3cfd537bac7a770e1a6, one markdown change away from recent master).

Generated my own snapshot (confirmed that recommended command roughly matches *doc/assumeutxo.md* (and `dumptxoutset`-help for specifying height):
```
₿ build/src/bitcoin-cli -rpcclienttimeout=0 -named dumptxoutset utxo-880000.dat rollback=880000
{
"c
...

💬 rishavtarway commented on issue "Revisiting us self-hosting parts of our CI":
(https://github.com/bitcoin/bitcoin/issues/31965#issuecomment-2692548770)
Will there be possibility we can think of more this idea :

1. Hybrid Approach with Optimized Caching:

=> Key Factors to this approach

i) Instead of a complete switch, maintain a smaller, more secure self-hosted infrastructure specifically for caching.

ii ) Use GitHub Actions or another cloud-based CI for the majority of the job execution.

iii) Develop a robust, distributed caching system (e.g., using a dedicated cloud storage service or a distributed cache like Redis) that integrates wit
...

📝 olaristo109 opened a pull request: "doc: Correct capitalization in release-process.md"
(https://github.com/bitcoin/bitcoin/pull/31971)
This PR corrects the capitalization of "if necessary" in the `doc/release-process.md` file.

The original sentence had "If necessary," with a capital "I". This has been corrected to "if necessary," with a lowercase "i" to maintain consistency.

This change improves the formatting and consistency of the documentation within the release process documentation file.

✅ fanquake closed a pull request: "doc: Correct capitalization in release-process.md"
(https://github.com/bitcoin/bitcoin/pull/31971)