💬 TheCharlatan commented on pull request "refactor (tidy): Fixes after enable-debug configure":
(https://github.com/bitcoin/bitcoin/pull/27353#issuecomment-1541422030)
Updated 3e76aff9d4709f44d6439cd0cbc2fd6c90cae6ab -> 27d182cef72e086afc4592cdfc565b3fdb52d0b4 ([clangTidyDebug_2](https://github.com/TheCharlatan/bitcoin/commits/clangTidyDebug_2) -> [clangTidyDebug_3](https://github.com/TheCharlatan/bitcoin/commits/clangTidyDebug_3), [compare](https://github.com/TheCharlatan/bitcoin/compare/clangTidyDebug_2..clangTidyDebug_3)).

* Dropped the commit changing the CI.

💬 MarcoFalke commented on pull request "refactor(follow-up): Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#issuecomment-1541423034)
Can remove `(follow-up)` from the title. Also, the docstring of the changed methods in the header is still wrong

💬 TheCharlatan commented on pull request "refactor(follow-up): Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#issuecomment-1541445444)
Re https://github.com/bitcoin/bitcoin/pull/27611#issuecomment-1541423034
> Also, the docstring of the changed methods in the header is still wrong

Do you mean these https://github.com/TheCharlatan/bitcoin/commit/0e7abdcb589ac2d891abce0b1cd9babbe6d0d39e ?

💬 TheCharlatan commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1541454221)
Updated 3b34ac7465919b968795063995f6610a73aa2d29 -> 24f1ace25081040af80ba4cf1636592266d8dbb5 ([removeBlockstorageArgs_21](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_21) -> [removeBlockstorageArgs_22](https://github.com/TheCharlatan/bitcoin/tree/removeBlockstorageArgs_22), [compare](https://github.com/TheCharlatan/bitcoin/compare/removeBlockstorageArgs_21..removeBlockstorageArgs_22))
* Addressed @MarcoFalke's [comment](https://github.com/bitcoin/bitcoin/pull/27125#discus
...

💬 MarcoFalke commented on pull request "refactor: Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#issuecomment-1541456801)
I mean the ones of the touched methods `Create*Params()`, which are documented to throw the wrong exception type. Now that you changed to `assert`, there is no exception at all.

💬 MarcoFalke commented on pull request "refactor: Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#issuecomment-1541457873)
Example:

```diff
diff --git a/src/chainparams.h b/src/chainparams.h
index 6a65f40f80..23b272cc41 100644
--- a/src/chainparams.h
+++ b/src/chainparams.h
@@ -26,7 +26,6 @@ class ArgsManager;
/**
* Creates and returns a std::unique_ptr<CChainParams> of the chosen chain.
* @returns a CChainParams* of the chosen chain.
- * @throws a std::runtime_error if the chain is not supported.
*/
std::unique_ptr<const CChainParams> CreateChainParams(const ArgsManager& args, const ChainType
...

⚠️ Tia939 opened an issue: "Btc mining"
(https://github.com/bitcoin/bitcoin/issues/27612)
- 

 Enterprise-level   Bitcoin   and   Blockchain    libraries.  Built   for   businesses,   miners,   wallets,   and  hobbyists  

TECHNOLOGY GITHUB

 

 

$ bcoin-cli info
{
  "version": "2.0.0-dev",
  "network": "main",
  "chain": {
    "height": 597278,
    "tip": "000000000000000000114ab8c7d77b0bce885cbecc12f95f2f1cbdfcefb86aa6",
    "progress": 1
  },
  "indexes": {
    "addr": {
      "enabled": true,
      "height": 597278
    },
    "tx": {
      "enabled": true,
      "height": 59727
...

✅ fanquake closed an issue: "Btc mining"
(https://github.com/bitcoin/bitcoin/issues/27612)

:lock: fanquake locked an issue: "Btc mining"
(https://github.com/bitcoin/bitcoin/issues/27612)

💬 Sjors commented on pull request "assumeutxo (2)":
(https://github.com/bitcoin/bitcoin/pull/27596#issuecomment-1541467462)
When running 8f431ad3b600a8f7e6dff83354ac3475b8936505 I noticed (and reproduced) that `-prune` is not fully honored when loading a snapshot and doing background validation. When I set `-prune=550` the blocks dir ends up somewhere between 3 and 5 GB. Judging by the blk….dat timestamps it seems that both the snapshot and background IBD hold on to more blocks than they should. Tested on Ubuntu 23.04 and with coinstats- and blockfilterindex enabled. The first time I tested I allowed the node to sync
...

🤔 darosior reviewed a pull request: "Improve performance of p2p inv to send queues"
(https://github.com/bitcoin/bitcoin/pull/27610#pullrequestreview-1419935557)
utACK 5b3406094f2679dfb3763de4414257268565b943

💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1541493057)
Nice.

re-ACK 24f1ace25081040af80ba4cf1636592266d8dbb5 🌦

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: re-ACK 24f1ace25
...

💬 MarcoFalke commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#issuecomment-1541494448)
trivial rebase re-ACK 8f94f059b3af5ecaf175a95389ba5e73b724203b 🗝

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: trivial reba
...

💬 Sjors commented on issue "CPU DoS on mainnet in debug mode":
(https://github.com/bitcoin/bitcoin/issues/27586#issuecomment-1541496964)
My highest `bytessent_per_msg` is 65 MB (mostly to the university nodes and Bitnodes), i.e. a lot less than the 2.5 GB @ayeowch is seeing. CPU still calm. My node has 114 inbound connections (and 10 out).

💬 TheCharlatan commented on pull request "refactor: Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#issuecomment-1541546516)
Updated d0767a9e0af367cbcc4ff7fce3758ece7d62861f -> ef39bdf0f709db1b3bfa07adddce7cccbd774109 ([followUp27491_0](https://github.com/TheCharlatan/bitcoin/tree/followUp27491_0) -> [followUp27491_1](https://github.com/TheCharlatan/bitcoin/tree/followUp27491_1), [compare](https://github.com/TheCharlatan/bitcoin/compare/followUp27491_0..followUp27491_1))
* Addressed @MarcoFalke's [comment](https://github.com/bitcoin/bitcoin/pull/27611#issuecomment-1541456801), removing exception docstring.
* Added s
...

👍 MarcoFalke approved a pull request: "refactor: Use ChainType enum exhaustively"
(https://github.com/bitcoin/bitcoin/pull/27611#pullrequestreview-1420053321)
lgtm, found another nit, feel free to ignore

💬 MarcoFalke commented on pull request "refactor: Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#discussion_r1189539373)
The return type is wrong, too. So maybe remove this line as well, as it is redundant with the line above it. Also, in the line above, can remove the return type, as it is redundant with the C++ code?

💬 MarcoFalke commented on pull request "refactor: Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#discussion_r1189540735)
Same

💬 MarcoFalke commented on pull request "refactor: Use ChainType enum exhaustively":
(https://github.com/bitcoin/bitcoin/pull/27611#discussion_r1189543228)
I think the scripted diff can be dropped, given that it fails? Maybe include this diff in the previous commit?

📝 hebasto converted_to_draft a pull request: "Enable HW-accelerated implementations of SHA256 for MSVC builds"
(https://github.com/bitcoin/bitcoin/pull/24773)
This PR enables AVX2, SSE4.1 and x86 SHA-NI implementations of SHA256 instead of the "standard" one.

**NOTE about testing**. During runtime the SHA-NI implementation is available only if a CPU has the `sha_ni` flag set.