🚀 achow101 merged a pull request: "contrib: add tool to convert compact-serialized UTXO set to SQLite database"
(https://github.com/bitcoin/bitcoin/pull/27432)

💬 davidgumberg commented on issue "guix: Unable to reproduce macOS SDK tarball on Fedora 40":
(https://github.com/bitcoin/bitcoin/issues/31873#issuecomment-2660517967)
> Try `diffoscope` (be prepared for very long output, and probably very long runtime).

`diffoscope` says:

> Format-specific differences are supported for Gzipped files but no file-specific differences were detected; falling back to a binary diff.`

```bash
diffoscope --no-default-limits --max-page-diff-block-line 16384 --html diffoscope.html badsdk/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers.tar.gz goodsdk/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers.tar.gz
```

and the binar
...

💬 achow101 commented on issue "guix: Unable to reproduce macOS SDK tarball on Fedora 40":
(https://github.com/bitcoin/bitcoin/issues/31873#issuecomment-2660536157)
Can you `gunzip` the files and compare the `.tar`s?

💬 davidgumberg commented on issue "guix: Unable to reproduce macOS SDK tarball on Fedora 40":
(https://github.com/bitcoin/bitcoin/issues/31873#issuecomment-2660561659)
> Can you `gunzip` the files and compare the `.tar`s?

Nice, the `gunzip`'ed tars are identical:

```console
$ gunzip badsdk/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers.tar.gz
$ gunzip goodsdk/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers.tar.gz
$ sha256sum badsdk/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers.tar
d91d39ca0dbff805677afc46abe0064056e7406728aa58e67ad98e147ef0e04c badsdk/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers.tar
$ sha256sum goodsdk/Xcode-15.0-1
...

💬 AlfazetOperations commented on pull request "addrman: change internal id counting to int64_t":
(https://github.com/bitcoin/bitcoin/pull/30568#issuecomment-2660571937)
https://github.com/bitcoin-core/guix.sigs.git

💬 tnndbtc commented on issue "Fuzz: Runtime errors when running fuzz tests on MacOs":
(https://github.com/bitcoin/bitcoin/issues/31591#issuecomment-2660618666)
I believe the right llvm version should be the one matches with the output indicated in "ld -v". For example, on my mac (Apple M1 chipset, OS: Sequoia 15.1.1):

% ld -v
@(#)PROGRAM:ld PROJECT:ld-1115.7.3
BUILD 23:52:02 Dec 5 2024
configured to support archs: armv6 armv7 armv7s arm64 arm64e arm64_32 i386 x86_64 x86_64h armv6m armv7k armv7m armv7em
will use ld-classic for: armv6 armv7 armv7s i386 armv6m armv7k armv7m armv7em
LTO support using: LLVM version 16.0.0 (static support for 29, runtime
...

💬 tnndbtc commented on issue "build: macOS fuzz instructions broken using latest macOS linker":
(https://github.com/bitcoin/bitcoin/issues/31049#issuecomment-2660619808)
As commented another thread https://github.com/bitcoin/bitcoin/issues/31591#issuecomment-2660618666, I'd like to paste my answer here so other people will install the correct llvm version:

I believe the right llvm version should be the one matches with the output indicated in "ld -v". For example, on my mac (Apple M1 chipset, OS: Sequoia 15.1.1):

% ld -v
@(#)PROGRAM:ld PROJECT:ld-1115.7.3
BUILD 23:52:02 Dec 5 2024
configured to support archs: armv6 armv7 armv7s arm64 arm64e arm64_32 i386 x86_6
...

💬 Prabhat1308 commented on issue "Fuzz: Runtime errors when running fuzz tests on MacOs":
(https://github.com/bitcoin/bitcoin/issues/31591#issuecomment-2660640961)
@tnndbtc
Thank you for this. I see that the linker in my machine also is using llvm 16 for support although llvm 19 came natively installed in machine. Right now the workaround is to build using llvm 16 but do you have any other suggestions to fix this ?

💬 eval-exec commented on pull request "random: Check `GetRNDRRS` is supported in `InitHardwareRand` to avoid infinite loop":
(https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1957007932)
Thank you, I refactored, could you please take another look?

💬 achow101 commented on pull request "random: Check `GetRNDRRS` is supported in `InitHardwareRand` to avoid infinite loop":
(https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1957011127)
I don't think there's any need to have these be separate commits, please squash.

💬 davidgumberg commented on issue "guix: Unable to reproduce macOS SDK tarball on Fedora 40":
(https://github.com/bitcoin/bitcoin/issues/31873#issuecomment-2660692458)
Tried with the same python version as Ubuntu 24.04 with the same zlib and I still get the same bad hash on Fedora 40.

<details>

<summary> Build python 3.12.3 on fedora with zlib-1.3 </summary>

```bash
sudo dnf install gcc openssl-devel xz-devel
curl -L https://github.com/madler/zlib/releases/download/v1.3/zlib-1.3.tar.gz | tar xzvf -
cd zlib-1.3 && ./configure && make -j $(nproc) && make install && cd ..

curl https://pyenv.run | bash
export PYENV_ROOT="$HOME/.pyenv"
[[ -d $PYENV_ROOT/bin ]]
...

💬 eval-exec commented on pull request "random: Check `GetRNDRRS` is supported in `InitHardwareRand` to avoid infinite loop":
(https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1957015376)
Squashed.

⚠️ kousay311 opened an issue: "3"
(https://github.com/bitcoin/bitcoin/issues/31876)
### Motivation

// Good: UpperCamelCase standalone function name
std::unique_ptr<Node> MakeNode(LocalInit& init);

// Bad: lowercase standalone function
std::unique_ptr<Node> makeNode(LocalInit& init);

### Possible solution

[](url)// Good: UpperCamelCase standalone function name
std::unique_ptr<Node> MakeNode(LocalInit& init);

// Bad: lowercase standalone function
std::unique_ptr<Node> makeNode(LocalInit& init);
// Good: lowerCamelCase method name
virtual void blockConnected(const CBlock& blo
...

💬 TheCharlatan commented on issue "guix: Unable to reproduce macOS SDK tarball on Fedora 40":
(https://github.com/bitcoin/bitcoin/issues/31873#issuecomment-2660780429)
Is the output of `tar tvvf` the same for both archives?

🤔 rkrux reviewed a pull request: "wallet: abandon orphan coinbase txs, and their descendants, during startup"
(https://github.com/bitcoin/bitcoin/pull/31794#pullrequestreview-2619349860)
```
git range-diff 409241db5dca0b23f5c7714f99be52411fc5541e...3c89cab06a6259fa70eaf3a78c01ee42780c4e27
```

Newer changes are updating the functional tests based on the comments suggested earlier. I will ACK once a small bug is corrected.

💬 rkrux commented on pull request "wallet: abandon orphan coinbase txs, and their descendants, during startup":
(https://github.com/bitcoin/bitcoin/pull/31794#discussion_r1957061812)
Hmm fair enough.

💬 rkrux commented on pull request "wallet: abandon orphan coinbase txs, and their descendants, during startup":
(https://github.com/bitcoin/bitcoin/pull/31794#discussion_r1957063827)
Need to use `:2`, otherwise it just syncs 1 block and iterates over 1 block - the first one.

```python
self.sync_blocks(self.nodes[:2])
self.disconnect_nodes(1, 0)
assert all(len(node.getpeerinfo()) == 0 for node in self.nodes[:2])
```

✅ fanquake closed an issue: "3"
(https://github.com/bitcoin/bitcoin/issues/31876)

💬 theStack commented on pull request "rpc: allow writing UTXO set to a named pipe, introduce dump_to_sqlite.sh script":
(https://github.com/bitcoin/bitcoin/pull/31560#issuecomment-2660845212)
Rebased on master (now that #27432 has been merged 🎉).

💬 fjahr commented on pull request "contrib: add tool to convert compact-serialized UTXO set to SQLite database":
(https://github.com/bitcoin/bitcoin/pull/27432#issuecomment-2660890740)
post-merge tACK 4080b66cbec2b6fc2fcfd7356941236f65d508e3