💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953500634)
Added a comment to this effect.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953500945)
This comment was no longer relevant, it dates from an earlier iteration. Gone.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953501047)
Done.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953501119)
Gone.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953501453)
When the same Ref is `RemoveTransaction()`ed twice. Added a comment to clarify.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953501564)
Done.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953501757)
Fixed.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953501842)
Done.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953502322)
I've added a comment to `AddTransaction` to clarify one can only pass Refs from a given txgraph object to functions of the same object.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953502492)
Fixed.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953502916)
Added a comment to this effect (the variable is gone in a future commit, though).

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953503038)
Done.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953503351)
Renamed to `find_root_fn`, `locate_fn`, `union_fn`.

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1953503471)
Done.

💬 yancyribbens commented on issue "wallet: Branch and Bound producing change":
(https://github.com/bitcoin/bitcoin/issues/31830#issuecomment-2655016156)
I tried this change running the test @brunoerg posted above and it still results in a change amount of 204 with the given params.

💬 brunoerg commented on issue "wallet: Branch and Bound producing change":
(https://github.com/bitcoin/bitcoin/issues/31830#issuecomment-2655045611)
> @brunoerg: Do you happen to have a copy of the input that crashed the fuzzer? If so, could you either share it or run the fuzz input against the following fix to [line 197 in coinselection.cpp](https://github.com/bitcoin/bitcoin/blob/master/src/wallet/coinselection.cpp#L197)

It's a custom target I wrote but I changed the test that I provided here and it's still producing change.

💬 InnDe commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2655064798)
Thank you all for your help I’ll update it

On Thu, 13 Feb 2025 at 01:33 Ava Chow ***@***.***> wrote:

> Does your passphrase has quotes (" or ') in it? If so, you will need to
> escape them when using the RPC console. If your password also has the space
> character, then entire passphrase will need to be surrounded with quotes so
> that the space is recognized as part of the passphrase.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/bitcoin/bitcoin/issu
...

💬 InnDe commented on issue "Wallet passpharse":
(https://github.com/bitcoin/bitcoin/issues/31852#issuecomment-2655067286)
> Does your passphrase has quotes (`"` or `'`) in it? If so, you will need to escape them when using the RPC console. If your password also has the space character, then entire passphrase will need to be surrounded with quotes so that the space is recognized as part of the passphrase.

tried but doesn't work even in software interface too

⚠️ InnDe opened an issue: "Wallet Passpharse"
(https://github.com/bitcoin/bitcoin/issues/31853)
### Issues, reports or feature requests related to the GUI should be opened directly on the GUI repo

- [x] I still think this issue should be opened here

### Report

Current behaviour
I’m using a passphrase for my encrypted wallets—8 in total.

This passphrase is: (space “thekey” \ \ \ \ \ \ \ \ \ \ \ \ )
“ \ \ \ \ \ \ \ \ \ \ \ \ )”

I use this passphrase for all my wallets (total: 2.4 BTC), but now it doesn’t work as usual. I tried creating a new wallet with the same passphrase, and I encoun
...

✅ achow101 closed an issue: "Wallet Passpharse"
(https://github.com/bitcoin/bitcoin/issues/31853)