📝 eval-exec opened a pull request: "Limit retries in GetRNDRRS to avoid infinite loop"
(https://github.com/bitcoin/bitcoin/pull/31826)
This PR want to fix #31817 by added a maximum retry limit (`max_retries`) to the `GetRNDRRS` function to prevent it from entering an infinite loop if the hardware random number generator fails to return a valid random number. This change improves stability and ensures that the function terminates after a predefined number of retries.

⚠️ Sjors opened an issue: "Rename bitcoin-wallet?"
(https://github.com/bitcoin/bitcoin/issues/31827)
Some chatter from IRC:

```
17:21:41 < darosior> It might be confusing to release both a bitcoin-wallet utility and a bitcoin-wallet binary as part of multiprocess?
17:24:08 < darosior> We could rename the utility, but then it would be nice to at least have one deprecation cycle. Given recent momentum i estimate it's possible we might release multiprocess in
30.0, which means if we want to deprecate the bitcoin-wallet utility name we should do it.. now?
17:33:31 < sipa> bit
...

💬 Sjors commented on pull request "Add bitcoin-{node,gui} to release binaries for IPC":
(https://github.com/bitcoin/bitcoin/pull/31802#issuecomment-2644928621)
@sipa I opened #31827

💬 MrSuddenJoy commented on issue "RFC: Multiprocess binaries and packaging options":
(https://github.com/bitcoin/bitcoin/issues/30983#issuecomment-2645031354)
Just bear in mind that bundled version means slower installation/operation time as well as higher bandwitch usage.

💬 hebasto commented on pull request "build: Enhance Ccache performance across worktrees and build trees":
(https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1947662256)
> This does affect us wrt debug info.

I don't think it affects us too much because:https://github.com/bitcoin/bitcoin/blob/fb0ada982a73687520c43b8fde480fa5d456f3e1/CMakeLists.txt#L456-L458

💬 satoshiv21 commented on something "":
(https://github.com/bitcoin/bitcoin/commit/f1d7a6dfa1411ccf741fbf7351ea4f229dd1e63e#commitcomment-152304857)
Bitcoin BC

1 2 3 4 5 6 7 8 9
A B C D E F G H I 👁
J K L M N O P Q R
S T U V W X Y Z


💀💀💀💀💀
SATOSHI NAKAMOTO = 55
WEB = 3 [ WEB 0 1 2 ] = 3
WE B.C WE B3
B Lock Ch A👁I n = 6
Bitcoin = = 9
(Co in B.C)








PYRAMIDS
KING KHUFU ERA36912
EGYPT GIZA 33000 B.C
B . C

B T C

Bit Coin

B lock 🔒⛓️ CH AI N
👁

Cryptography
397726791787
...

💬 satoshiv21 commented on something "":
(https://github.com/bitcoin/bitcoin/commit/f1d7a6dfa1411ccf741fbf7351ea4f229dd1e63e#commitcomment-152304864)
1 2 3 4 5 6 7 8 9
A B C D E F G H I 👁
J K L M N O P Q R
S T U V W X Y Z


💀💀💀💀💀
SATOSHI NAKAMOTO = 55
WEB = 3 [ WEB 0 1 2 ] = 3
WE B.C WE B3
B Lock Ch A👁I n = 6
Bitcoin = = 9
(Co in B.C)








PYRAMIDS
KING KHUFU ERA36912
EGYPT GIZA 33000 B.C
B . C

B T C

Bit Coin

B lock 🔒⛓️ CH AI N
👁

Cryptography
397726791787
3+9+7+7+2+6+7+
...

💬 satoshiv21 commented on pull request "Limit retries in GetRNDRRS to avoid infinite loop":
(https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1947673312)
1 2 3 4 5 6 7 8 9
A B C D E F G H I 👁
J K L M N O P Q R
S T U V W X Y Z


💀💀💀💀💀
SATOSHI NAKAMOTO = 55
WEB = 3 [ WEB 0 1 2 ] = 3
WE B.C WE B3
B Lock Ch A👁I n = 6
Bitcoin = = 9
(Co in B.C)








PYRAMIDS
KING KHUFU ERA36912
EGYPT GIZA 33000 B.C
B . C

B T C

Bit Coin

B lock 🔒⛓️ CH AI N
👁

Cryptography
397726791787
3+9+7+7+2+6+7+
...

💬 satoshiv21 commented on something "":
(https://github.com/bitcoin/bitcoin/commit/332655cb52c8f8ef64b29b09e38ef5d61235ed21#r152304891)
1 2 3 4 5 6 7 8 9
A B C D E F G H I 👁
J K L M N O P Q R
S T U V W X Y Z


💀💀💀💀💀
SATOSHI NAKAMOTO = 55
WEB = 3 [ WEB 0 1 2 ] = 3
WE B.C WE B3
B Lock Ch A👁I n = 6
Bitcoin = = 9
(Co in B.C)








PYRAMIDS
KING KHUFU ERA36912
EGYPT GIZA 33000 B.C
B . C

B T C

Bit Coin

B lock 🔒⛓️ CH AI N
👁

Cryptography
397726791787
3+9+7+7+2+6+7+
...

💬 satoshiv21 commented on something "":
(https://github.com/bitcoin/bitcoin/commit/332655cb52c8f8ef64b29b09e38ef5d61235ed21#r152304896)
1 2 3 4 5 6 7 8 9
A B C D E F G H I 👁
J K L M N O P Q R
S T U V W X Y Z


💀💀💀💀💀
SATOSHI NAKAMOTO = 55
WEB = 3 [ WEB 0 1 2 ] = 3
WE B.C WE B3
B Lock Ch A👁I n = 6
Bitcoin = = 9
(Co in B.C)








PYRAMIDS
KING KHUFU ERA36912
EGYPT GIZA 33000 B.C
B . C

B T C

Bit Coin

B lock 🔒⛓️ CH AI N
👁

Cryptography
397726791787
3+9+7+7+2+6+7+
...

💬 satoshiv21 commented on something "":
(https://github.com/bitcoin/bitcoin/commit/332655cb52c8f8ef64b29b09e38ef5d61235ed21#r152304903)
1 2 3 4 5 6 7 8 9
A B C D E F G H I 👁
J K L M N O P Q R
S T U V W X Y Z


💀💀💀💀💀
SATOSHI NAKAMOTO = 55
WEB = 3 [ WEB 0 1 2 ] = 3
WE B.C WE B3
B Lock Ch A👁I n = 6
Bitcoin = = 9
(Co in B.C)








PYRAMIDS
KING KHUFU ERA36912
EGYPT GIZA 33000 B.C
B . C

B T C

Bit Coin

B lock 🔒⛓️ CH AI N
👁

Cryptography
397726791787
3+9+7+7+2+6+7+
...

💬 satoshiv21 commented on something "":
(https://github.com/bitcoin/bitcoin/commit/332655cb52c8f8ef64b29b09e38ef5d61235ed21#r152304912)
1 2 3 4 5 6 7 8 9
A B C D E F G H I 👁
J K L M N O P Q R
S T U V W X Y Z


💀💀💀💀💀
SATOSHI NAKAMOTO = 55
WEB = 3 [ WEB 0 1 2 ] = 3
WE B.C WE B3
B Lock Ch A👁I n = 6
Bitcoin = = 9
(Co in B.C)








PYRAMIDS
KING KHUFU ERA36912
EGYPT GIZA 33000 B.C
B . C

B T C

Bit Coin

B lock 🔒⛓️ CH AI N
👁

Cryptography
397726791787
3+9+7+7+2+6+7+
...

💬 eval-exec commented on issue "GetRandBytes() Hangs on Samsung Galaxy S25 and OnePlus 13":
(https://github.com/bitcoin/bitcoin/issues/31817#issuecomment-2645221706)
I have Samsung Galaxy S23 Ultra:


💬 hebasto commented on pull request "build: Enhance Ccache performance across worktrees and build trees":
(https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2645380742)
Thanks to all for the review!

Your feedback has been addressed.

💬 hebasto commented on pull request "build: Enhance Ccache performance across worktrees and build trees":
(https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1947720776)
Thanks! The comment has been [added](https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2645380742).

💬 hebasto commented on pull request "build: Enhance Ccache performance across worktrees and build trees":
(https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1947720890)
Thanks! [Reworked](https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2645380742) per your feedback.

💬 hebasto commented on pull request "build: Enhance Ccache performance across worktrees and build trees":
(https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1947720947)
Thanks! [Fixed](https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2645380742).

💬 hebasto commented on pull request "build: Enhance Ccache performance across worktrees and build trees":
(https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1947721236)
Reverted [back](https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2645380742) given this [comment](https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1941284740).

🤔 maflcko reviewed a pull request: "Limit retries in GetRNDRRS to avoid infinite loop"
(https://github.com/bitcoin/bitcoin/pull/31826#pullrequestreview-2603859200)
Instead of changing the code and repeating the code changes in the description, it would be better to actually explain why the problem happens and why this fix is the correct fix.

To me this seems like a problem where a system claims to support a feature, but doesn't? So it would be better to instead investigate and fix the feature test or feature reporting.

💬 maflcko commented on pull request "Limit retries in GetRNDRRS to avoid infinite loop":
(https://github.com/bitcoin/bitcoin/pull/31826#discussion_r1947836133)
r1 will be uninitialized memory and returning it will be undefined behavior.