💬 mzumsande commented on issue "test: intermittent issue in p2p_1p1c_network.py ":
(https://github.com/bitcoin/bitcoin/issues/31721#issuecomment-2620169640)
I think that the following is happening:
- Orphan is announced to node 1 by python peer, but it doesn't send the tx.
- submitpackage is executed on node 0, which will sequentially schedule `RelayTransaction`, first for the parent, then for the child.
- Usually parent and child are put together in one inv, but if the node sends out an inv in between these two `RelayTransaction` calls, the inv for the child may arrive after the tx for the parent was received - since we now only do orphan resolutio
...

📝 mzumsande opened a pull request: "test: fix intermittent timeout in p2p_1p1c_network.py"
(https://github.com/bitcoin/bitcoin/pull/31751)
The timeout is due to outstanding txrequests with python peers.
I explained this in more detail in https://github.com/bitcoin/bitcoin/issues/31721#issuecomment-2620169640

Fix this by disconnecting the python peers after they send their txns, they aren't needed after this point anyway because the main goal of the test is the sync between the 4 full nodes.

Fixes #31721

📝 maximevtush opened a pull request: "Update LICENSE"
(https://github.com/bitcoin/bitcoin/pull/31752)
Updated the copyright year from 2017 to 2025 in the LICENSE file

✅ fanquake closed a pull request: "Update LICENSE"
(https://github.com/bitcoin/bitcoin/pull/31752)

📝 fanquake locked a pull request: "Update LICENSE"
(https://github.com/bitcoin/bitcoin/pull/31752)
Updated the copyright year from 2017 to 2025 in the LICENSE file

💬 hodlinator commented on pull request "qa: Verify clean shutdown on startup failure":
(https://github.com/bitcoin/bitcoin/pull/30660#issuecomment-2620208770)
Resolved conflict with @maflcko's #31620 which solved the core issue more elegantly.

I think there is still some use in the tests from this PR, as we want to avoid knock-on exceptions being reintroduced. I've reworked the tests from 3 to 1 Python file. They now launch a child process of which keeps the success-state of the parent `BitcoinTestFramework` separate from the expected failures of the child processes.

The final commit (f2e3721e018c3038d5d648ec7ae08e96418f3c29) is what remains of
...

💬 ftruter commented on something "":
(https://github.com/bitcoin/bitcoin/commit/b483084d866c16d97a34251ae652bac94f85f61d#commitcomment-151875207)
The information that WAS in this file BEFORE this commit is no longer ANYWHERE else in the repo. Please revert!!

📝 ShivaanjayNarula opened a pull request: "Merge pull request #1 from bitcoin/master"
(https://github.com/bitcoin/bitcoin/pull/31753)
Merge

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests th
...

✅ willcl-ark closed a pull request: "Merge pull request #1 from bitcoin/master"
(https://github.com/bitcoin/bitcoin/pull/31753)

📝 fanquake locked a pull request: "Merge pull request #1 from bitcoin/master"
(https://github.com/bitcoin/bitcoin/pull/31753)
Merge

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests th
...

💬 pinheadmz commented on something "":
(https://github.com/bitcoin/bitcoin/commit/b483084d866c16d97a34251ae652bac94f85f61d#commitcomment-151875532)
@ftruter it's generated with each new release:

https://github.com/bitcoin/bitcoin/blob/28.x/share/examples/bitcoin.conf

⚠️ tofutim opened an issue: "guix SWH vault Internal Server Error"
(https://github.com/bitcoin/bitcoin/issues/31754)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

For the first time, running contrib/guix/guix-build, I ran into:

```
Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
SWH: found revision 53396a22afc04536ddf75d8f82ad2eafa5082725 with directory at 'https://archive.softwareheritage.org/api/1/directory/d6d830512c16e46521fab9a956c1842ab2fcdea9/'
SWH vault: failure: Internal Server Error. This inc
...

💬 davidgumberg commented on pull request "build: Enhance Ccache performance across worktrees and build trees":
(https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2620364986)
Tested ACK, fixes worktree and build tree ccache hits. https://github.com/bitcoin/bitcoin/commit/4d3f360e2af94f4ed46dc0943196d548da82003e


Note that as the PR description states, in the latest push, setting a `BASE_DIR` for `ccache` (as advised in the productivity notes) is essential for ccache to get hits in different directories.


<details>

<summary>Tested on gcc and clang on ubuntu 22.04</summary>

All on fresh ubuntu 22.04.1 vm images running running with qemu, in variations
I
...

📝 espi3 opened a pull request: "doc: Add test coverage troubleshooting tip"
(https://github.com/bitcoin/bitcoin/pull/31755)
This PR adds troubleshooting information to explain how to overcome two errors that may arise when running the tests with coverage as described in doc/developer-notes.md.

Specifically, running the `cmake -P build/Coverage.cmake` step may produces geninfo mismatch errors of the following sort (Ubuntu 24.04, g++ compiler):

```
geninfo: ERROR: mismatched end line for _ZN7Num30723SerI10DataStreamEEvRT_RKS_ at /home/espi3/src/bitcoin/src/crypto/muhash.h:62: 67 -> 62
(use "geninfo --ig
...

💬 Sjors commented on pull request "rpc: fix mintime field testnet4":
(https://github.com/bitcoin/bitcoin/pull/31600#issuecomment-2621017382)
I was indeed waiting for more people to chime in.

Pushed the simplification to always apply the rule.

✅ fanquake closed an issue: "guix SWH vault Internal Server Error"
(https://github.com/bitcoin/bitcoin/issues/31754)

💬 fanquake commented on issue "guix SWH vault Internal Server Error":
(https://github.com/bitcoin/bitcoin/issues/31754#issuecomment-2621122709)
I haven't seen this before, but it looks like a (hopefully intermittent) upstream issue.

💬 TheCharlatan commented on pull request "rpc: have getblocktemplate mintime account for timewarp":
(https://github.com/bitcoin/bitcoin/pull/31600#discussion_r1933573379)
I think there is room for the functional tests to demonstrate some "common misconfigurations" to help avoid regressions, but agree that this case here is probably best documented and described elsewhere.

💬 Sjors commented on pull request "rpc: have getblocktemplate mintime account for timewarp":
(https://github.com/bitcoin/bitcoin/pull/31600#discussion_r1933586381)
It's in https://github.com/bitcoin/bitcoin/pull/31725

💬 Sjors commented on pull request "multiprocess: Add libmultiprocess git subtree":
(https://github.com/bitcoin/bitcoin/pull/31741#discussion_r1933669516)
01452f8c0da58db549bc46d0cfa7de715344efc4: the Apple version of tar doesn't have `--sort`, see https://github.com/chaincodelabs/libmultiprocess/issues/139#issuecomment-2621080394