💬 hebasto commented on issue "[Linux] Add wayland support":
(https://github.com/bitcoin/bitcoin/issues/19950#issuecomment-1535989723)
@berenddeboer
> I've switched to the Sway window manager which gets a lot of traction, but unfortunately got here as bitcoin doesn't run.

You can compile `bitcoin-qt` by yourself using linking against system-wide (modern enough) Qt5 packages. The resulted binary will support Wayland.

To run it, the additional packages could be required. For details, see https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md.

💬 willcl-ark commented on pull request "util: Use steady clock instead of system clock to measure durations":
(https://github.com/bitcoin/bitcoin/pull/27405#issuecomment-1535999135)
ACK fa83fb3161

This is a nice cleanup to the clocks.

There are a few time values left as other types in the codebase, but it doesn't make sense to change them as they are being used as those types by other components (mainly libevent it seems).

💬 fanquake commented on issue "Compiling a bitcoin core version that accepts transactions over 100vkb":
(https://github.com/bitcoin/bitcoin/issues/27490#issuecomment-1536017323)
Closing for now.

✅ fanquake closed an issue: "Compiling a bitcoin core version that accepts transactions over 100vkb"
(https://github.com/bitcoin/bitcoin/issues/27490)

📝 hebasto opened a pull request: "msvc: Cleanup after upgrading libsecp256k1 up to 0.3.0"
(https://github.com/bitcoin/bitcoin/pull/27580)
libsecp256k1 [v0.3.0](https://github.com/bitcoin-core/secp256k1/blob/master/CHANGELOG.md#030---2023-03-08):
> Removed the configuration header `src/libsecp256k1-config.h`.

This PR removed the code that has been unused since https://github.com/bitcoin/bitcoin/pull/27230.

The `USE_ASM_X86_64` is now undefined explicitly (but actually it seems a bit redundant).

The `ECMULT_GEN_PREC_BITS` and `ECMULT_WINDOW_SIZE` macros are defined by the source code to their defaults.

---

Considerin
...

🤔 darosior reviewed a pull request: "Switch hardened derivation marker to h (in normalized descriptors and new wallets)"
(https://github.com/bitcoin/bitcoin/pull/26076#pullrequestreview-1413412381)
light ACK bd13dc2f46ea10302a928fcf0f53b7aed77ad260. Code looks correct to me but i find the OP and release note misleading (stated purpose is already possible and not what this PR implements) and i'm a bit confused about the choice of where to make breaking changes:
- Why not honour what was parsed for normalized serialization?
- Why keep serializing `hdkeypath`'s hardened paths with apostrophe for legacy wallet but not descriptor wallets or elsewhere (like in `decodepsbt`)?

Just to be clea
...

💬 darosior commented on pull request "Switch hardened derivation marker to h (in normalized descriptors and new wallets)":
(https://github.com/bitcoin/bitcoin/pull/26076#discussion_r1185207740)
But so has it in descriptor wallets? Why would it be more ok to make a breaking change for descriptor wallets than for legacy wallet?

💬 darosior commented on pull request "Switch hardened derivation marker to h (in normalized descriptors and new wallets)":
(https://github.com/bitcoin/bitcoin/pull/26076#discussion_r1185237888)
This is already possible on master (and also at least on 24.0.1). This PR does not change that. For instance on a `24.0.1` regtest node:
```
importdescriptors '[{"desc":"pk([00aabbcc/0h/1h]cSWVo8YMehg6STxqw6xGgmMJE6Ac6RCJ7owcrBZRAT7QANtyAAEj)#uqdekwuc","timestamp":"now"}]'
```
works fine. So does:
```
scantxoutset start '["pk([00aabbcc/0h/1h]cSWVo8YMehg6STxqw6xGgmMJE6Ac6RCJ7owcrBZRAT7QANtyAAEj)#uqdekwuc"]'
```

💬 darosior commented on pull request "Switch hardened derivation marker to h (in normalized descriptors and new wallets)":
(https://github.com/bitcoin/bitcoin/pull/26076#discussion_r1185924697)
`decodepsbt` too.

👍 dergoegge approved a pull request: "refactor: Remove need to pass chainparams to BlockManager methods"
(https://github.com/bitcoin/bitcoin/pull/27570#pullrequestreview-1414541195)
Code review ACK fa5d7c39eb992467e43b12db213b27913374fb83

💬 Sjors commented on pull request "multiprocess: Add bitcoin-gui -ipcconnect option":
(https://github.com/bitcoin/bitcoin/pull/19461#issuecomment-1536056897)
> When I exit the GUI and after that stop `bitcoind` the latter crashes.

This still happens on 5f91aa3d8b47cee97e625c3b5689a37dbd941eff. Same setup as above: node and wallet running on Ubuntu 23.04 with a GUI client connecting from macOS using a unix socket of SSH.

But now I've notice this happens even if you don't connect to it, i.e. starting without `-ipcbind`.

After letting the chain sync (a few days worth of blocks), I shut it down. At that point the log (on Ubuntu):

```
2023-05
...

💬 Sjors commented on pull request "Multiprocess bitcoin":
(https://github.com/bitcoin/bitcoin/pull/10102#issuecomment-1536075360)
I was able to reproduce the crash I found [here](https://github.com/bitcoin/bitcoin/pull/19461#issuecomment-1536056897) using only this PR.

Details: running Ubuntu 23.04, libmultiprocess at fc28a48f01af9730be3b49585e718e11c5eea0c5 and capnproto 0.10.4 compiled from source (because of https://github.com/chaincodelabs/libmultiprocess/issues/68#issuecomment-1527856219).

```
./configure --enable-werror --enable-suppress-external-warnings --without-gui --enable-multiprocess
…
src/bitcoin-no
...

💬 fanquake commented on pull request "assumeutxo":
(https://github.com/bitcoin/bitcoin/pull/15606#issuecomment-1536093556)
> Known weird behavior

Runing through your steps above, everything *seems* to be working, except that my mempool was empty until I stopped and restarted bitcoind?

> If you restart the node in the middle of the bg sync, nChainTx for the snapshot chain will not properly repopulate and your progress= for the snapshot chainstate will be weird. I think there's an easy fix for this, which I'm investigating.

Yea. After a restart:
```bash
# ./src/bitcoin-cli -datadir=${AU_DATADIR} getblockcha
...

👍 TheCharlatan approved a pull request: "refactor: Remove need to pass chainparams to BlockManager methods"
(https://github.com/bitcoin/bitcoin/pull/27570#pullrequestreview-1414604996)
ACK fa5d7c39eb992467e43b12db213b27913374fb83

Thank you for following up so quickly!

💬 TheCharlatan commented on pull request "refactor: Remove need to pass chainparams to BlockManager methods":
(https://github.com/bitcoin/bitcoin/pull/27570#discussion_r1185976774)
Nit: Can be `const` (here and elsewhere) and skip the `node::` namespacing, since it is imported above. If this is merged before #27125 I will follow-up there.

💬 MarcoFalke commented on pull request "fuzz: BIP 42, BIP 30, CVE-2018-17144":
(https://github.com/bitcoin/bitcoin/pull/17860#discussion_r1185989416)
Nice. I get "number go down" from 94k to 90k in the last force push with steps to reproduce:


```
FUZZ=utxo_total_supply /usr/bin/time --f='%M' ./src/test/fuzz/fuzz -runs=1 -- --printtoconsole=0

💬 MarcoFalke commented on pull request "fuzz: BIP 42, BIP 30, CVE-2018-17144":
(https://github.com/bitcoin/bitcoin/pull/17860#discussion_r1185989734)
thx, done

👍 stickies-v approved a pull request: "test: Treat `bitcoin-wallet` binary in the same way as others"
(https://github.com/bitcoin/bitcoin/pull/27554#pullrequestreview-1414615945)
ACK ef01337bbb3d5269db6a26e42c7bbd238000ce2f

Nice little refactoring (modulo being able to now set `BITCOINWALLET` which is new behaviour), less code duplication and functions with smaller scope.

💬 stickies-v commented on pull request "test: Treat `bitcoin-wallet` binary in the same way as others":
(https://github.com/bitcoin/bitcoin/pull/27554#discussion_r1185989630)
nit
```suggestion
"""Update self.options with the paths of all binaries from environment variables or their default values"""
def set_binary_paths(self):
```

💬 stickies-v commented on pull request "test: Treat `bitcoin-wallet` binary in the same way as others":
(https://github.com/bitcoin/bitcoin/pull/27554#discussion_r1185984288)
nit
```suggestion
for binary, [attribute_name, env_variable_name] in binaries.items():
```