👍 hodlinator approved a pull request: "doc: improve dependencies documentation"
(https://github.com/bitcoin/bitcoin/pull/31634#pullrequestreview-2545217904)
ACK d0ca5c53635916868e7d5da913faf3d9a8d706b7

Good to clarify that only one of the compilers is required, and re-introduce that section!

Thanks for updating the PR summary.

### Commit message

Suggest removing repetition of initial sentence and fixing grammar of last line, + less important other changes.

```diff
-doc: improve dependencies documentation
+doc: Improve dependencies documentation

-This commit improves the dependencies documentation by:
-- moving "Clang" and "GCC"
...

💬 hodlinator commented on pull request "doc: improve dependencies documentation":
(https://github.com/bitcoin/bitcoin/pull/31634#discussion_r1912232236)
nit: Not yet touched by this PR, but could optionally add some context.
```suggestion
| Linux Kernel (if building that platform) | [link](https://www.kernel.org/) | N/A | [3.17.0](https://github.com/bitcoin/bitcoin/pull/27699) | Yes |
```

💬 TheCharlatan commented on pull request "kernel: Move kernel-related cache constants to kernel cache":
(https://github.com/bitcoin/bitcoin/pull/31483#issuecomment-2585406915)
Thanks for the ACK @hodlinator :)

Updated cf20c1b9e0b46cb8c4d4f93a054afd9c1f85e4e0 -> 0e2887262e1a3a4a5ab0382f9e8713b135408a77 ([kernel_cache_sizes_13](https://github.com/TheCharlatan/bitcoin/tree/kernel_cache_sizes_13) -> [kernel_cache_sizes_14](https://github.com/TheCharlatan/bitcoin/tree/kernel_cache_sizes_14), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernel_cache_sizes_13..kernel_cache_sizes_14))

* Addressed @hodlinator's [comment](https://github.com/bitcoin/bitcoin/pu
...

👍 hodlinator approved a pull request: "kernel: Move kernel-related cache constants to kernel cache"
(https://github.com/bitcoin/bitcoin/pull/31483#pullrequestreview-2545245484)
re-ACK 0e2887262e1a3a4a5ab0382f9e8713b135408a77

Thanks for addressing my comments. :rocket:

💬 hodlinator commented on pull request "kernel: Move kernel-related cache constants to kernel cache":
(https://github.com/bitcoin/bitcoin/pull/31483#discussion_r1912238290)
What the.. could have sworn my suggestion compiled without warnings, but now I get them. Sorry.

💬 RonieLabr70031 commented on pull request "kernel: chainparams updates for 26.x":
(https://github.com/bitcoin/bitcoin/pull/28591#issuecomment-2585644697)
# BIP-44 Derivation Paths
| BTC | Bitcoin | GetPublicKey | bc1q7799s3qgqpuvfyux7u3vgrd2lus66sc0gmeaxj | SignTx | Derivation | Note |
|-------------------|------------------|------------------------|--------------------|--------------------|---------------|----------------|
| Bitcoin | secp256k1 | `m/p'/c'/a'` | `m/p'/c'/a'/h/i` | `m/p'/c'/a'/h/i` | BIP-32 | [21](#Bitcoin) |
| Ethereum
...

💬 hebasto commented on pull request "wallet: Cleanup accidental encryption keys in watchonly wallets":
(https://github.com/bitcoin/bitcoin/pull/28724#issuecomment-2585683053)
> The new code in `test/functional/wallet_encryption.py` [fails](https://github.com/hebasto/bitcoin-core-nightly/actions/runs/12720574600/job/35462426268) on NetBSD...

The root cause of the issue is that the `-Wl,-z,separate-code` linker option is incompatible with NetBSD's dynamic linker. Building with `-DENABLE_HARDENING=OFF` or `-DAPPEND_LDFLAGS="-Wl,-z,noseparate-code"` fixes the issue.

💬 Andrewsr84 commented on issue "cmake: Compiling for test coverage (low-priority workaround exists)":
(https://github.com/bitcoin/bitcoin/issues/31638#issuecomment-2585699638)
Thank for the help

💬 eshutov commented on issue "Stuck in Endless Pre-Syncing Headers Loop":
(https://github.com/bitcoin/bitcoin/issues/26391#issuecomment-2585720873)
I have faced with the same issue:
```
2025-01-12T12:01:56Z Pre-synchronizing blockheaders, height: 852216 (~97.02%)
2025-01-12T12:02:00Z Pre-synchronizing blockheaders, height: 854216 (~97.23%)
2025-01-12T12:02:02Z Pre-synchronizing blockheaders, height: 856216 (~97.47%)
2025-01-12T12:02:29Z Pre-synchronizing blockheaders, height: 712215 (~81.31%)
2025-01-12T12:02:33Z Pre-synchronizing blockheaders, height: 714215 (~81.52%)
2025-01-12T12:02:37Z Pre-synchronizing blockheaders, height: 7162
...

⚠️ feelancer21 opened an issue: "Cannot open utxo snapshot"
(https://github.com/bitcoin/bitcoin/issues/31643)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Using bitcoind 28.0 I wanted to setup a new full node and load the utxo snapshot from loop.net. I got the following error.



```
$ bitcoin-cli -rpcclienttimeout=0 loadtxoutset utxo-snapshot-height-840000.dat
RPC password>
error code: -8
error message:
Couldn't open file /appdata/bitcoin-01/data/utxo-snapshot-height-840000.dat for reading.
```






### Expected behaviou
...

💬 TheCharlatan commented on issue "Cannot open assumeUTXO snapshot":
(https://github.com/bitcoin/bitcoin/issues/31643#issuecomment-2585736963)
It looks like the snapshot you are trying to load is not in the data directory. Either move it there, or provide the full path to the file in the command. If you just pass the file name, bitcoin will attempt to load it from its data directory (as indicated by the error message).

📝 l0rinc opened a pull request: "leveldb: show non-default options during init"
(https://github.com/bitcoin/bitcoin/pull/31644)
To help with to debugging and traceability (in alignment with displaying other non-default args such as `Command-line arg: dbcache="10000"`) we can extend the LevelDB opening log with the used settings.

To avoid showing booleans as e.g. `create_if_missing=1`, I've added an local `to_string` lambda.
I wanted to use `util::Join` at the end, but couldn't find any way that I liked.

Example Output after the change:
```bash
2025-01-12T17:10:58Z Opening LevelDB in /Users/lorinc/Library/Applica
...

✅ feelancer21 closed an issue: "Cannot open assumeUTXO snapshot"
(https://github.com/bitcoin/bitcoin/issues/31643)

💬 feelancer21 commented on issue "Cannot open assumeUTXO snapshot":
(https://github.com/bitcoin/bitcoin/issues/31643#issuecomment-2585843653)
Thank you. I did not read the error message correctly.

💬 pablomartin4btc commented on issue "Remove libevent as a dependency (HTTP / cli / torcontrol)":
(https://github.com/bitcoin/bitcoin/issues/31194#issuecomment-2585885945)
I've checked that and I see where the problem is...

If you run the following it works correctly (using/ changing `src/test/httpserver_tests.cpp`):

```
uri = "/rest/endpoint/someresource.json?p1=v1%20&p1=v2";
BOOST_CHECK_EQUAL(GetQueryParameterFromUri(uri.c_str(), "p1").value(), "v1 ");
```
```
./build/src/test/test_bitcoin --log_level=all --run_test=httpserver_tests
...
./test/httpserver_tests.cpp(52): info: check GetQueryParameterFromUri(uri.c_str(), "p1").value() == "v1 "
...

💬 pablomartin4btc commented on pull request "httpserver, rest: improving URI validation":
(https://github.com/bitcoin/bitcoin/pull/27253#discussion_r1912521917)
> I think the URI validation was performed before checking the params, so the exception was raised and caught by the test?

It seems that the libevent parser doesn't differentiate if the URI is invalid whether the query syntax is wrong (missing the '?') or there's an invalid char within the URI (`%` not followed by 2 hexa chars - [RFC 3986](https://datatracker.ietf.org/doc/html/rfc3986#section-2.1) and libevent only interprets it if the encoded chars are withing the variable's value, [not in t
...

📝 l0rinc opened a pull request: "optimization: increase default LevelDB write batch size to 64 MiB"
(https://github.com/bitcoin/bitcoin/pull/31645)
The UTXO set has grown significantly recently, and flushing it from memory to LevelDB often takes over 20 minutes after a successful IBD with large dbcache values.
The final UTXO set is written to disk in batches, which LevelDB sorts into SST files.
By increasing the default batch size, we can reduce overhead from repeated compaction cycles, minimize constant overhead per batch, and achieve more sequential writes.

Experiments with different batch sizes (loaded via assumeutxo at block 840k,
...

💬 l0rinc commented on pull request "optimization: increase default LevelDB write batch size to 64 MiB":
(https://github.com/bitcoin/bitcoin/pull/31645#issuecomment-2585900399)
Visual representation of the measurements (16MiB was the previous default, 64MiB is the proposed one):

<img width="780" alt="image" src="https://github.com/user-attachments/assets/93ab3fff-385b-4093-8016-ab2a251cf92a" />

💬 kilrau commented on pull request "BIP-322 basic support":
(https://github.com/bitcoin/bitcoin/pull/24058#issuecomment-2585912510)
Same question @kallewoof , why did you close this? It's a much needed feature.

💬 Sjors commented on pull request "rpc: add gettarget , target getmininginfo field and show next block info":
(https://github.com/bitcoin/bitcoin/pull/31583#discussion_r1912840515)
Testnet3, testnet4 and mainnet all have a difficulty 1 genesis block, so it wouldn't make a difference.