📝 fanquake locked a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/31607)
<!--


Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly: trading

* Any test improvements or new tests that improve coverage are always welcome.
* All other changes shou
...

✅ willcl-ark closed an issue: "Fake bitcoin core website at the top of duckduckgo"
(https://github.com/bitcoin/bitcoin/issues/31602)

💬 willcl-ark commented on issue "Fake bitcoin core website at the top of duckduckgo":
(https://github.com/bitcoin/bitcoin/issues/31602#issuecomment-2572746178)
Hey @thebignaught, thanks for the report, here and on bitcoincore.org repo.

I this this issue will be best left open over there rather than in both repos, so I'm going to close here.

I have also reported the website as per @1440000bytes to duckduckgo and would encourage anyone else reading this to take 30 seconds to do the same. Reports could also be made to https://safebrowsing.google.com/safebrowsing/report_phish/ which DDG (and others) may? use.

I am not sure there is much else we ca
...

:lock: fanquake locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/31606)

:lock: fanquake locked an issue: "."
(https://github.com/bitcoin/bitcoin/issues/31527)

💬 maflcko commented on pull request "ci: Allow build dir on CI host":
(https://github.com/bitcoin/bitcoin/pull/31428#issuecomment-2572752778)
rebased for fresh CI, no code change.

💬 maflcko commented on pull request "[28.x] 28.1 backports and final changes":
(https://github.com/bitcoin/bitcoin/pull/31594#issuecomment-2572777372)
@Sjors I don't think it is useful to backport PRs which have neither been reviewed, nor merged into a final tag without a rc even. Especially, given that the fix is for test-only network with brittle mining anyway.

💬 maflcko commented on pull request "[28.x] 28.1 backports and final changes":
(https://github.com/bitcoin/bitcoin/pull/31594#discussion_r1903955230)
Good catch. Added missing credit line!

💬 Sjors commented on pull request "[28.x] 28.1 backports and final changes":
(https://github.com/bitcoin/bitcoin/pull/31594#issuecomment-2572790627)
@maflcko obviously I'm not advocating backporting the PR before it's merged, but rather to delay the release until it is.

> Especially, given that the fix is for test-only network with brittle mining anyway.

That's probably a good reason to not wait, but it seemed good to bring it up.

👍 hodlinator approved a pull request: "#31403 follow-up"
(https://github.com/bitcoin/bitcoin/pull/31599#pullrequestreview-2531822509)
ACK a3f5573ae3aa5edbe92d0388f36586ad02214de6

First commit follows recommendations by myself with improvements by maflcko in already merged PR.

Passed subset of functional tests locally.

---

Might squeeze a little bit more information into the title?

"#31403 follow-up" -> "qa: Improve framework.generate* enforcement (#31403 follow-up)"

See https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#creating-the-pull-request

👍 Eunovo approved a pull request: "RPC: Add reserve member function to `UniValue` and use it in `getblock` RPC"
(https://github.com/bitcoin/bitcoin/pull/31179#pullrequestreview-2531822542)
Tested ACK https://github.com/bitcoin/bitcoin/pull/31179/commits/bf5c569898d0297de010102a623bf52009607ed8

Confirmed slight improvement in `BlockToJson` bench.
Before:
```
| ns/op | op/s | err% | ins/op | cyc/op | IPC | bra/op | miss% | total | benchmark
|--------------------:|--------------------:|--------:|----------------:|----------------:|-------:|---------------:|--------:|----------:|:----------
| 438,695.0
...

📝 brunoerg converted_to_draft a pull request: "descriptor: check whitespace in `ParsePubkeyInner`"
(https://github.com/bitcoin/bitcoin/pull/31603)
Currently, we successfully parse descriptors which contains spaces in the beginning or end of the fragment (e.g. `pk( KEY)`, `pk(KEY )` or `pk( KEY )`. I noticed that one of the reasons is that the `DecodeBase58` function simply ignore these whitespaces. This PR changes the `ParsePubkeyInner` function to reject pubkeys that contain a whitespace at the beginning and/or at the end.

For context: https://github.com/brunoerg/bitcoinfuzz/issues/72

🚀 fanquake merged a pull request: "test: fix typo in mempool_ephemeral_dust"
(https://github.com/bitcoin/bitcoin/pull/31604)

🚀 fanquake merged a pull request: "ci: Run functional tests in msan task"
(https://github.com/bitcoin/bitcoin/pull/31592)

✅ fanquake closed a pull request: "ci: Switch to latest macOS and Windows images"
(https://github.com/bitcoin/bitcoin/pull/31597)

💬 maflcko commented on pull request "refactor: modernize recent `ByteType` usages and read/write functions":
(https://github.com/bitcoin/bitcoin/pull/31601#issuecomment-2572824301)
Not sure about the first commit. There is no issue or risk with the existing code that is fixed by the style fixups, so to me it seems better to not change it, unless there is a compelling reason. Generally when it comes to style modernizations, my recommendation would be to include them in changes that touch the line anyway, or leave them as-is, or do them wholesale for the whole project (only if there is a good reason for them). But going out and doing them one-by one for specific subsections
...

💬 maflcko commented on pull request "#31403 follow-up":
(https://github.com/bitcoin/bitcoin/pull/31599#issuecomment-2572826673)
Also, a rebase would be good

💬 fanquake commented on pull request "ci: Bump centos stream 10":
(https://github.com/bitcoin/bitcoin/pull/31593#issuecomment-2572832061)
https://cirrus-ci.com/task/4631012182851584
```bash
[10:35:39.510] + bash -c 'dnf -y --allowerasing install gcc-c++ glibc-devel.x86_64 libstdc++-devel.x86_64 glibc-devel.i686 libstdc++-devel.i686 ccache make git python3 python3-pip which patch lbzip2 xz procps-ng dash rsync coreutils bison e2fsprogs cmake '
[10:35:40.618] Extra Packages for Enterprise Linux 10 - x86_64 3.7 MB/s | 3.1 MB 00:00
[10:35:41.599] Last metadata expiration check: 0:00:01 ago on Mon Jan 6 05:35:40 2025.
[10
...

🚀 fanquake merged a pull request: "doc: Update NetBSD Build Guide"
(https://github.com/bitcoin/bitcoin/pull/31586)

📝 brunoerg opened a pull request: "test: importdescriptors is not available for non-descriptor wallets"
(https://github.com/bitcoin/bitcoin/pull/31609)
This PR adds test coverage for the error thrown when trying to import descriptors into a non-descriptor wallet.