💬 achow101 commented on pull request "rpc: Extend scope of validation mutex in generateblock":
(https://github.com/bitcoin/bitcoin/pull/31563#issuecomment-2565841234)
ACK fa63b8232f38e78d3c6413fa7d51809f376de75c

💬 achow101 commented on pull request "test: descriptor: fix test for `MaxSatisfactionWeight`":
(https://github.com/bitcoin/bitcoin/pull/31570#issuecomment-2565842092)
ACK b29d68f942e333d2cfdd6be8d49fe484e0d15e11

✅ achow101 closed an issue: "Intermittent issue in feature_index_prune.py: assert_equal(pruneheight_new, 248) AssertionError: not(249 == 248)"
(https://github.com/bitcoin/bitcoin/issues/31446)

🚀 achow101 merged a pull request: "test: Avoid intermittent error in assert_equal(pruneheight_new, 248)"
(https://github.com/bitcoin/bitcoin/pull/31468)

✅ furszy closed a pull request: "[WIP] wallet: tx creation, don't select outputs from txes that are being replaced"
(https://github.com/bitcoin/bitcoin/pull/26732)

💬 furszy commented on pull request "[WIP] wallet: tx creation, don't select outputs from txes that are being replaced":
(https://github.com/bitcoin/bitcoin/pull/26732#issuecomment-2565843578)
Closing for now. Might revive it in the future, post #26966.

✅ furszy closed a pull request: "reduce cs_main scope, guard block index 'nFile' under a local mutex"
(https://github.com/bitcoin/bitcoin/pull/27006)

💬 furszy commented on pull request "reduce cs_main scope, guard block index 'nFile' under a local mutex":
(https://github.com/bitcoin/bitcoin/pull/27006#issuecomment-2565844088)
Closing for now. Might revive it in the future, post #26966.

✅ achow101 closed an issue: "test: functional tests fail to start if -maxconnections is reduced"
(https://github.com/bitcoin/bitcoin/issues/23968)

🚀 achow101 merged a pull request: "qa: Limit `-maxconnections` in tests"
(https://github.com/bitcoin/bitcoin/pull/31537)

✅ achow101 closed an issue: "qa: Intermittent `AssertionError: not(10.00000000 == 340)` in `wallet_assumeutxo.py --descriptors`"
(https://github.com/bitcoin/bitcoin/issues/31546)

🚀 achow101 merged a pull request: "validation: Send correct notification during snapshot completion"
(https://github.com/bitcoin/bitcoin/pull/31556)

💬 achow101 commented on pull request "wallet: migration, don't create spendable wallet from a watch-only legacy wallet":
(https://github.com/bitcoin/bitcoin/pull/31423#discussion_r1899757970)
In 788bb48f6712c39995831020dc36297f88c42f71 "wallet: introduce method to return all db created files"

These are created only by BDB.

SQLite makes only `wallet.dat` and `wallet.dat-journal`.

💬 achow101 commented on pull request "wallet: migration, avoid loading legacy wallet after failure when BDB isn't compiled":
(https://github.com/bitcoin/bitcoin/pull/31451#issuecomment-2565858913)
ACK 589ed1a8eafe1daed379ebb383602c8f220aef19

✅ achow101 closed an issue: "Assertion pindexPrev && pindexPrev == chainstate.m_chain.Tip() when running regtest"
(https://github.com/bitcoin/bitcoin/issues/31562)

🚀 achow101 merged a pull request: "rpc: Extend scope of validation mutex in generateblock"
(https://github.com/bitcoin/bitcoin/pull/31563)

💬 murchandamus commented on pull request "fuzz: Limit wallet_notifications iterations (take 2)":
(https://github.com/bitcoin/bitcoin/pull/31467#discussion_r1899761615)
Removing Knapsack is still on my to-do list!

💬 mzumsande commented on pull request "validation: Send correct notification during snapshot completion":
(https://github.com/bitcoin/bitcoin/pull/31556#discussion_r1899762694)
missed this, it could probably be done in a follow-up such as #30455

🚀 achow101 merged a pull request: "test: descriptor: fix test for `MaxSatisfactionWeight`"
(https://github.com/bitcoin/bitcoin/pull/31570)

💬 Sjors commented on pull request "rpc: Extend scope of validation mutex in generateblock":
(https://github.com/bitcoin/bitcoin/pull/31563#issuecomment-2565873162)
Post merge ACK