💬 hebasto commented on issue "qa: Intermittent `AssertionError: not(10.00000000 == 340)` in `wallet_assumeutxo.py --descriptors`":
(https://github.com/bitcoin/bitcoin/issues/31546#issuecomment-2557299362)
> Is it reproducible?

It seems intermittent.

💬 vasild commented on issue "Feature Request: Broadcast Pool":
(https://github.com/bitcoin/bitcoin/issues/30471#issuecomment-2557300801)
The closest thing to this is at https://github.com/bitcoin/bitcoin/pull/29415, waiting for testing and code review.

💬 hebasto commented on pull request "doc: Install `net/py-pyzmq` port on FreeBSD for `interface_zmq.py`":
(https://github.com/bitcoin/bitcoin/pull/31526#issuecomment-2557307026)
Friendly ping @vasild :)

💬 sipa commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#issuecomment-2557349002)
I'm aware this is a big chunk of code, but perhaps this can aid review a bit.

The biggest commits is [txgraph: (feature) add initial version](https://github.com/bitcoin/bitcoin/pull/31363/commits/afc6a665770004411f1b57f4f43dda916dadd8f7). To get an idea of what is going on, I think it's useful to look (in order) at:
* The `src/txgraph.h` file added in that commit, as it defines the public interface.
* The `src/test/fuzz/txgraph.cpp` test added in the next commit ([txgraph: (tests) add simul
...

💬 hebasto commented on issue "depends: `capnp` package fails to build on NetBSD 10.0":
(https://github.com/bitcoin/bitcoin/issues/31499#issuecomment-2557362137)
> Shouldn't this be an upstream bug report, given that's where the issue is?

https://github.com/capnproto/capnproto/issues/2201.

📝 marcofleon opened a pull request: "fuzz: Abort if system time is called without mock time being set"
(https://github.com/bitcoin/bitcoin/pull/31549)
This PR expands the `CheckGlobals` utility that was introduced in https://github.com/bitcoin/bitcoin/pull/31486 and should help with fuzz stability (https://github.com/bitcoin/bitcoin/issues/29018).

System time shouldn't be used when running a fuzz test, as it is likely to introduce instability (non-determinism). This PR identifies and fixes the targets that were calling system time without setting mock time at the start of an iteration.

Removing`SetMockTime()` from any one of these targe
...

💬 theuni commented on pull request "cmake: Always provide `RPATH` on NetBSD":
(https://github.com/bitcoin/bitcoin/pull/31543#issuecomment-2557510392)
So the `ld` finds the lib to link against, but the runtime loader then can't find it? That seems absurd.

Or is it because the toolchain you're using adds `/usr/pkg/lib/` to `ld`'s paths?

💬 hebasto commented on pull request "cmake: Always provide `RPATH` on NetBSD":
(https://github.com/bitcoin/bitcoin/pull/31543#issuecomment-2557513164)
> So the `ld` finds the lib to link against, but the runtime loader then can't find it? That seems absurd.
>
>
>
> Or is it because the toolchain you're using adds `/usr/pkg/lib/` to `ld`'s paths?

This is because CMake uses absolute paths to libraries during the linking stage.

💬 theuni commented on pull request "cmake: Always provide `RPATH` on NetBSD":
(https://github.com/bitcoin/bitcoin/pull/31543#issuecomment-2557527549)
> > So the `ld` finds the lib to link against, but the runtime loader then can't find it? That seems absurd.
> > Or is it because the toolchain you're using adds `/usr/pkg/lib/` to `ld`'s paths?
>
> This is because CMake uses absolute paths to libraries during the linking stage.

Yes, but I was asking how it found it to link against in the first place.

Answering my own question: [CMake is adding it, not `ld`](https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/Platform/UnixPath
...

👍 theuni approved a pull request: "cmake: Always provide `RPATH` on NetBSD"
(https://github.com/bitcoin/bitcoin/pull/31543#pullrequestreview-2518124400)
utACK https://github.com/bitcoin/bitcoin/pull/31543/commits/11115e9aa845d675a88e18e729913f0aaa11e322

🤔 mzumsande reviewed a pull request: "qa: Limit `-maxconnections` in tests"
(https://github.com/bitcoin/bitcoin/pull/31537#pullrequestreview-2518220584)
Code Review ACK d9d5bc2e7466033d989432f53a112325fa3d6d4a

Some tests will overwrite `-maxconnections`, e.g. `p2p_eviction.py` sets it to 32 and connects 22 python peers at the same time, so with the current test suite any OS would need to be able to deal with that.
But since the BSD limit of 94 is larger than that, and I don't really see a need for functional tests having more peers than that, there should be no problem.

👍 i-am-yuvi approved a pull request: "rpc: Add signet_challenge field to getblockchaininfo and getmininginfo"
(https://github.com/bitcoin/bitcoin/pull/31531#pullrequestreview-2518245384)
Concept ACK ecaa786cc103cf7cc63ae899ec13d81a54e2fd1e

Both the RPC seems to be giving enough information about the signet challenges!! Thanks @A-Manning for this!!

I have used custom signet(OP_TRUE) on Linux x86_64:

`getblockchaininfo`:
```
{
"chain": "signet",
"blocks": 0,
"headers": 0,
"bestblockhash": "00000008819873e925422c1ff0f99f7cc9bbb232af63a077a480a3633bee1ef6",
"difficulty": 0.001126515290698186,
"time": 1598918400,
"mediantime": 1598918400,
"verificat
...

💬 i-am-yuvi commented on pull request "Extend signetchallenge to set target block spacing":
(https://github.com/bitcoin/bitcoin/pull/29365#issuecomment-2557651018)
Great work!! @starius
Concept ACK

This would be a great help for Warnet Game since now you can easily configure the block creation time. Will review the code very soon!!

💬 pinheadmz commented on pull request "Extend signetchallenge to set target block spacing":
(https://github.com/bitcoin/bitcoin/pull/29365#issuecomment-2557668342)
> This would be a great help for Warnet Game since now you can easily configure the block creation time. Will review the code very soon!!

Indeed, this is how we do it now:
https://github.com/bitcoin-dev-project/battle-of-galen-erso/blob/15ac31e0ec78dae716afc150f62e5cbc0fb7bd2e/scenarios/stub_orphan.py#L25-L31

💬 ismaelsadeeq commented on issue "Faster way to get block with prevouts in JSON-RPC":
(https://github.com/bitcoin/bitcoin/issues/30495#issuecomment-2557708013)
Thank you, @josibake, for highlighting this! I was able to perform some benchmarks to evaluate the performance you claimed of using
- Rust wrapper by @TheCharlatan https://github.com/TheCharlatan/rust-bitcoinkernel
- Python wrapper by @stickies-v https://github.com/stickies-v/py-bitcoinkernel

As you claimed, this is indeed more performant.
### Benchmark Results:

I used the libbitcoinkernel library to imitate extracting block data for the same interval block heights 840000 to 841000,
...

🤔 ismaelsadeeq reviewed a pull request: "kernel: Introduce initial C header API"
(https://github.com/bitcoin/bitcoin/pull/30595#pullrequestreview-2518337899)
Concept ACK

💬 brunoerg commented on pull request "fuzz: Abort if system time is called without mock time being set":
(https://github.com/bitcoin/bitcoin/pull/31549#issuecomment-2557743801)
Concept ACK

👍 hodlinator approved a pull request: "net, net_processing: additional and consistent disconnect logging"
(https://github.com/bitcoin/bitcoin/pull/28521#pullrequestreview-2518411198)
ACK 06443b8f28bcec4315cec262eb03343dee5465a6

Agree that follow-ups should be handled in other PRs at this point.

---

<details><summary>
Tested syncing signet and turned off WiFi
</summary>

```
2024-12-20T21:34:36Z [net] got inv: wtx 3e9f4e49ddfb5cfd1fd847de22836de941a7245054db0629bb5c0cdfdd2466bf have peer=0
2024-12-20T21:34:36Z [net] received: tx (248 bytes) peer=7
2024-12-20T21:34:37Z [net] sending inv (73 bytes) peer=5
2024-12-20T21:34:37Z [net] sending inv (37 bytes) peer=
...

💬 mzumsande commented on issue "qa: Intermittent `AssertionError: not(10.00000000 == 340)` in `wallet_assumeutxo.py --descriptors`":
(https://github.com/bitcoin/bitcoin/issues/31546#issuecomment-2557882520)
I looked into this (thanks @furszy who helped me understand the wallet part of this) and believe that this is a bug in validation:

When the snapshot block is connected at the end of the background sync, `MaybeCompleteSnapshotValidation` is called from `ConnectTip()` (deactivating one chainstate), and the `BlockConnected()` signal for the snapshot height (which logically belongs to the background chainstate) is sent out after this.
Since the background chainstate does no longer exist by th
...

⚠️ grubles opened an issue: "build: v28.1rc2 test/test_bitcoin-base58_tests.o errors on freebsd 14.2"
(https://github.com/bitcoin/bitcoin/issues/31550)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Running `gmake` errors when trying to build v28.1rc2 on FreeBSD 14.2:

```
% gmake
Making all in src
gmake[1]: Entering directory '/home/user/builds/bitcoin/src'
gmake[2]: Entering directory '/home/user/builds/bitcoin/src'
gmake[3]: Entering directory '/home/user/builds/bitcoin'
gmake[3]: Leaving directory '/home/user/builds/bitcoin'
GEN obj/build.h
CXX test/test_bi
...