💬 MarcoFalke commented on issue "Proposed Timeline for Legacy Wallet and BDB removal":
(https://github.com/bitcoin/bitcoin/issues/20160#issuecomment-1527763221)
I think the milestones will need to be edited in OP to be moved back by one release?

💬 MarcoFalke commented on pull request "test: add coverage for `-bantime`":
(https://github.com/bitcoin/bitcoin/pull/26604#discussion_r1180578823)
Pretty sure this will lead to a race when the rpc is dispatched after a one second sleep?

💬 MarcoFalke commented on issue "ci: failure in Docker build step":
(https://github.com/bitcoin/bitcoin/issues/27492#issuecomment-1527772394)
For now the only workarounds I see are:

* rebase
* remove the cirrus CI env file feature for this task

💬 jonatack commented on pull request "Add wallet method to detect if a key is "active"":
(https://github.com/bitcoin/bitcoin/pull/27216#issuecomment-1527773928)
> https://github.com/bitcoin/bitcoin/commit/81f29f03a607cbfb7162705c1c1618ca7b59640e I'm not sure if or when legacy wallet support is expected to be phased out, but if isactive is only different from ismine in legacy wallets, is it worth adding a field (and all the new methods), versus just updating the ismine field documentation in the help for descriptor wallets

Following up on https://github.com/bitcoin/bitcoin/pull/27216#discussion_r1160272170 above, according to https://github.com/bitcoi
...

💬 brunoerg commented on pull request "Relay own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/27509#issuecomment-1527780479)
> One shot connections + immediate tx broadcast without inv,getdata exchange leaks that the tx is likely being broadcast for the first time (easy to censor the tx as the receiver).

I agree. My main concern is about how to ensure the transaction has not been censored. It seems easy for an attacker to identify someone opened a connection just to relay its own transaction.

> Now we wait until we receive an INV about that tx from somebody

Just to clarify: We would open the short-lived conne
...

💬 darosior commented on pull request "MiniTapscript: port Miniscript to Tapscript":
(https://github.com/bitcoin/bitcoin/pull/27255#discussion_r1180610019)
Note to self: i should relax the ops and script size limits below under Tapscript context.

💬 emc99 commented on issue "Drop support for g++-8?":
(https://github.com/bitcoin/bitcoin/issues/27537#issuecomment-1527893748)
What does ACK mean?

💬 jonatack commented on issue "Drop support for g++-8?":
(https://github.com/bitcoin/bitcoin/issues/27537#issuecomment-1527895120)
> What does ACK mean?

https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core#terminology

💬 Riahiamirreza commented on issue "rpc: show P2(W)SH redeemScript in getrawtransaction (and friends)":
(https://github.com/bitcoin/bitcoin/issues/27391#issuecomment-1527913381)
Okay, I'm currently working on this issue. But it may take a while, since this is my first contribution.

💬 Sjors commented on pull request "Multiprocess bitcoin":
(https://github.com/bitcoin/bitcoin/pull/10102#issuecomment-1527920697)
Building c86da22175e5bbe40e03624689bd3d4cc1508ba1 fails when configured without a wallet, but with gui.

Intel macOS 13.3.1 with capnp 0.10.3 via homebrew and libmultiprocess 1af83d15239ccfa7e47b8764029320953dd7fdf1.

```
./configure --enable-suppress-external-warnings --enable-c++20 --with-gui --enable-multiprocess --disable-bench --disable-tests --disable-external-signer --disable-fuzz-binary --disable-wallet
...
make
...
CXXLD bitcoin-gui
Undefined symbols for architecture x8
...

📝 Empact opened a pull request: "init: Fixes for file descriptor accounting"
(https://github.com/bitcoin/bitcoin/pull/27539)
This rebases and revises #16003 for clarity of review.

Aims to fix #18911.

💬 0xB10C commented on pull request "ci: use LLVM/clang-16 in native_asan job":
(https://github.com/bitcoin/bitcoin/pull/27360#issuecomment-1528104826)
Can't really comment on the change of using clang-16. The second commit dropping the bpfcc-tools from the PPA looks fine. You could remove the reference to this PR from the description of 5fbda45d2b962a67221ea0c8c35e38f6eef06499.

💬 RandyMcMillan commented on pull request "Updated the installation instructions for macOS":
(https://github.com/bitcoin/bitcoin/pull/27525#issuecomment-1528126395)
ACK


💬 RandyMcMillan commented on pull request "Updated the installation instructions for macOS":
(https://github.com/bitcoin/bitcoin/pull/27525#issuecomment-1528130736)
Note: it is good idea to check that markdown looks good in desktop editors (macdown for example) - github flavored markdown has diverged from other flavors and sometimes there are minor issues.

💬 HenrikJannsen commented on pull request "Remove BIP35 mempool p2p message":
(https://github.com/bitcoin/bitcoin/pull/27426#issuecomment-1528610256)
> The mempool message is used by all wallets based on bitcoinj to learn about pending transactions, in both full blocks mode and also in filtered mode. The estimated install base is 10M+.

I guess the large install base should be reason enough to drop that proposal.

[Bisq](https://bisq.network/) is using BitcoinJ and would be affected by that proposed change as well.

💬 pablomartin4btc commented on pull request "httpserver, rest: fix segmentation fault on evhttp_uri_get_query":
(https://github.com/bitcoin/bitcoin/pull/27253#issuecomment-1528701927)
- Fixed`http_request`fuzz failure and added some relevant comments in the code.

📝 JurbinM opened a pull request: "Create devcontainer.json"
(https://github.com/bitcoin/bitcoin/pull/27541)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ hebasto closed a pull request: "Create devcontainer.json"
(https://github.com/bitcoin/bitcoin/pull/27541)

📝 hebasto locked a pull request: "Create devcontainer.json"
(https://github.com/bitcoin/bitcoin/pull/27541)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 TheCharlatan commented on pull request "rpc: Optimize serialization disk space of dumptxoutset":
(https://github.com/bitcoin/bitcoin/pull/26045#issuecomment-1528716678)
Re https://github.com/bitcoin/bitcoin/pull/26045#issuecomment-1472285629

> I was also wondering why the bitcoin-cli savetxoutset API (same goes for savemempool) requires to specify a filename instead of writing to stdout that would offer better composition while maintaining the possibility to write to file with >utxo.bin

Writing to stdout would mean that the data would have to be carried over the rpc connection, right?