💬 jonatack commented on pull request "rpc: add 'getnetmsgstats', new rpc to view network message statistics":
(https://github.com/bitcoin/bitcoin/pull/27534#discussion_r1179543384)
nit unless I'm missing something, https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#f16-for-in-parameters-pass-cheaply-copied-types-by-value-and-others-by-reference-to-const

💬 jonatack commented on pull request "rpc: add 'getnetmsgstats', new rpc to view network message statistics":
(https://github.com/bitcoin/bitcoin/pull/27534#discussion_r1179553879)
Perhaps better to calculate this programmatically, so it doesn't need to be updated.

💬 ilbarillo2014 commented on issue "Bitcoin Core v22.0.0 crashes while syncronizing the first local wallet transaction":
(https://github.com/bitcoin/bitcoin/issues/27533#issuecomment-1526233524)
Problem solved installing 24.0.1.
THANKS !

✅ ilbarillo2014 closed an issue: "Bitcoin Core v22.0.0 crashes while syncronizing the first local wallet transaction"
(https://github.com/bitcoin/bitcoin/issues/27533)

💬 HenrikJannsen commented on pull request "Remove BIP35 mempool p2p message":
(https://github.com/bitcoin/bitcoin/pull/27426#issuecomment-1526869942)
@schildbach - this would be problematic for BitcoinJ, no?

💬 George43566 commented on pull request "Remove now-unnecessary poll, fcntl includes from net(base).cpp":
(https://github.com/bitcoin/bitcoin/pull/27530#issuecomment-1527049237)
I can help you out

On Thu, 27 Apr 2023, 4:11 pm Jon Atack, ***@***.***> wrote:

> ***@***.**** commented on this pull request.
>
> utACK b095ac5
> <https://github.com/bitcoin/bitcoin/commit/b095ac573b89d6898168bb9fda2abf7622ddec09>
>
> Noticed these while doing #27385
> <https://github.com/bitcoin/bitcoin/pull/27385>. Per
> https://cirrus-ci.com/task/6749578737745920:
>
> net.cpp should remove these lines:
> - #include <clientversion.h> // lines 15-15
> - #include <crypto/sha256.h> // lines 1
...

💬 George43566 commented on pull request "Remove now-unnecessary poll, fcntl includes from net(base).cpp":
(https://github.com/bitcoin/bitcoin/pull/27530#issuecomment-1527049841)
I can handle it

On Thu, 27 Apr 2023, 4:00 pm Christopher Coverdale, <
***@***.***> wrote:

> tACK
> I also ran netbase.cpp through the iwyu CI and seems like there maybe a
> few more unused imports, but I haven't thoroughly tested removing the other
> ones
>
> netbase.cpp should remove these lines:
> - #include <fcntl.h> // lines 25-25
> - #include <poll.h> // lines 29-29
> - #include <chrono> // lines 18-18
> - #include <cstdint> // lines 19-19
> - #include <limits> // lines 21-21
>
> —
>
...

💬 Empact commented on pull request "Remove now-unnecessary poll, fcntl includes from net(base).cpp":
(https://github.com/bitcoin/bitcoin/pull/27530#issuecomment-1527141145)
I'll update this PR on Sunday, just busy with http://btcpp.dev at the moment.

💬 MarcoFalke commented on pull request "Bump python minimum version to 3.8":
(https://github.com/bitcoin/bitcoin/pull/27483#issuecomment-1527228543)
Thanks. I think it is best for you to open a follow-up, unless people want me to push the commit here.

💬 fanquake commented on pull request "Bump python minimum version to 3.8":
(https://github.com/bitcoin/bitcoin/pull/27483#issuecomment-1527240485)
> I think it is best for you to open a follow-up,

Lets do that.

🚀 fanquake merged a pull request: "Bump python minimum version to 3.8"
(https://github.com/bitcoin/bitcoin/pull/27483)

💬 darosior commented on pull request "Wallet: estimate the size of signed inputs using descriptors":
(https://github.com/bitcoin/bitcoin/pull/26567#discussion_r1180304523)
Pushed a much cleaner version of this: introducing a `MultiSigningProvider` to wrap around both the wallet and external providers. Still as a commit on top, let me know what you think @achow101.

📝 fjahr opened a pull request: "test: Remove modinv python util helper function"
(https://github.com/bitcoin/bitcoin/pull/27538)
Since #27483 was merged the `modinv()` body is just one line calling pythons own implementation of `pow()`. We can just remove the function as it doesn't seem to add any value. Additionally the comment in the function is now outdated and the test is only testing two ways of doing modular inverse but both using python's `pow()` function.

💬 sipa commented on pull request "test: Remove modinv python util helper function":
(https://github.com/bitcoin/bitcoin/pull/27538#issuecomment-1527470660)
Concept ACK

💬 MarcoFalke commented on pull request "test: Remove modinv python util helper function":
(https://github.com/bitcoin/bitcoin/pull/27538#discussion_r1180329594)
```
test/functional/test_framework/util.py:18:1: F401 'unittest' imported but unused

💬 MarcoFalke commented on pull request "test: Remove modinv python util helper function":
(https://github.com/bitcoin/bitcoin/pull/27538#discussion_r1180329919)
```
test/functional/test_framework/util.py:18:1: F401 'unittest' imported but unused

💬 MarcoFalke commented on pull request "lint: stop ignoring LIEF imports":
(https://github.com/bitcoin/bitcoin/pull/27507#issuecomment-1527477037)
```
contrib/devtools/security-check.py:246: error: "object" has no attribute "header" [attr-defined]

💬 Riahiamirreza commented on issue "rpc: show P2(W)SH redeemScript in getrawtransaction (and friends)":
(https://github.com/bitcoin/bitcoin/issues/27391#issuecomment-1527485466)
Can I work on it? Isn't it much hard as the first time contribution?

💬 michaelfolkson commented on issue "rpc: show P2(W)SH redeemScript in getrawtransaction (and friends)":
(https://github.com/bitcoin/bitcoin/issues/27391#issuecomment-1527511935)
@Riahiamirreza: You don't need to ask but stating you are planning to work on this is helpful for others. If you look at the linked attempt in #8849 it looks doable as a first contribution but I don't know your skillset, level of understanding.

💬 kevkevinpal commented on pull request "test: Remove modinv python util helper function":
(https://github.com/bitcoin/bitcoin/pull/27538#issuecomment-1527515641)
Concept ACK also did a grep for modinv in /test and looks like you got all them