💬 pinheadmz commented on issue "Allow groups of accounts to access the RPC cookie file":
(https://github.com/bitcoin/bitcoin/issues/25270#issuecomment-1525819410)
This issue is unlikely to be fixed in Bitcoin Core. We'll close for now, but feel free to open another issue or pull request with a fix.

✅ pinheadmz closed an issue: "Allow groups of accounts to access the RPC cookie file"
(https://github.com/bitcoin/bitcoin/issues/25270)

✅ pinheadmz closed an issue: "GUI unresponsive during slow operations"
(https://github.com/bitcoin/bitcoin/issues/10504)

💬 RandyMcMillan commented on pull request "Bump python minimum version to 3.8":
(https://github.com/bitcoin/bitcoin/pull/27483#issuecomment-1525824196)
https://github.com/bitcoin/bitcoin/pull/27130

✅ pinheadmz closed an issue: "assumeutxo"
(https://github.com/bitcoin/bitcoin/issues/15605)

💬 ccdle12 commented on pull request "Remove now-unnecessary poll, fcntl includes from net(base).cpp":
(https://github.com/bitcoin/bitcoin/pull/27530#issuecomment-1525855649)
tACK

<details><summary>I also ran netbase.cpp through the iwyu CI and seems like there maybe a few more unused imports, but I haven't thoroughly tested removing the other ones</summary>
<p>

```
netbase.cpp should remove these lines:
- #include <fcntl.h> // lines 25-25
- #include <poll.h> // lines 29-29
- #include <chrono> // lines 18-18
- #include <cstdint> // lines 19-19
- #include <limits> // lines 21-21
```
</p>
</details>

💬 ryanofsky commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1179303184)
Just talked about this offline, but if possible to make ZMQ just take a pointer to BlockManager instead of NodeContext, that would be good. This way ZMQ would only have access to the state it actually needs

💬 jonatack commented on pull request "Remove now-unnecessary poll, fcntl includes from net(base).cpp":
(https://github.com/bitcoin/bitcoin/pull/27530#issuecomment-1525866006)
> Can you add this to iwyu CI to double check and aid reviewers?

I did that recently for these files while working on #27385; the results are here: https://cirrus-ci.com/task/6749578737745920

🤔 jonatack reviewed a pull request: "Remove now-unnecessary poll, fcntl includes from net(base).cpp"
(https://github.com/bitcoin/bitcoin/pull/27530#pullrequestreview-1404309583)
utACK b095ac573b89d6898168bb9fda2abf7622ddec09

Noticed these while doing #27385. Per https://cirrus-ci.com/task/6749578737745920:

```
net.cpp should remove these lines:
- #include <clientversion.h> // lines 15-15
- #include <crypto/sha256.h> // lines 18-18
- #include <fcntl.h> // lines 45-45
- #include <math.h> // lines 63-63
- #include <poll.h> // lines 53-53
- #include <array> // lines 57-57
- #include <unordered_map> // lines 61-61

netbase.cpp should remove these lines
...

💬 JBaczuk commented on issue "Create a list of validation errors in one location":
(https://github.com/bitcoin/bitcoin/issues/15356#issuecomment-1525876920)
@pinheadmz Probably not at this point.

💬 darosior commented on pull request "MiniTapscript: port Miniscript to Tapscript":
(https://github.com/bitcoin/bitcoin/pull/27255#issuecomment-1525910357)
Reviewers, i've seen the comments i'm going to address them soon and rebase this.

I have discussed this with @sipa in person today. A couple notes from my recollection:
- I introduce the `diff` (net difference in stack size before and after executing a fragment) and `exec` (maximum stack size reached during execution) here to account for the maximum stack size at all time. Pieter noticed we may be able to express the size in function of the diff. Or vice versa.
- We tried to assert this pro
...

💬 MarcoFalke commented on issue "Create a list of validation errors in one location":
(https://github.com/bitcoin/bitcoin/issues/15356#issuecomment-1525988287)
Not sure what exactly should be done here. Maybe the error messages can be improved for some, but generally they should be self-explanatory. Recall that the ones you mention are accompanied by an extended description and more specific error message. For example, `"non-mandatory-script-verify-flag (Negative locktime)"`.

💬 MarcoFalke commented on issue "Create a list of validation errors in one location":
(https://github.com/bitcoin/bitcoin/issues/15356#issuecomment-1525988708)
The feature request didn't seem to attract much attention in the past. Thus, closing due to lack of interest, progress and direction.

Pull requests with improvements are always welcome. Moreover, it is possible to re-open this issue or create a new issue referencing it, if there is fresh interest.

✅ MarcoFalke closed an issue: "Create a list of validation errors in one location"
(https://github.com/bitcoin/bitcoin/issues/15356)

💬 brunoerg commented on pull request "Relay own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/27509#issuecomment-1526013801)
Concept ACK

💬 MarcoFalke commented on issue "depends: Multiple `FALLBACK_DOWNLOAD_PATH`s":
(https://github.com/bitcoin/bitcoin/issues/17234#issuecomment-1526026245)
For reference, for now I am using this diff locally to get the depends from a ipv6 (cloudflare):

```diff
diff --git a/depends/Makefile b/depends/Makefile
index 27bf804..768db6b 100644
--- a/depends/Makefile
+++ b/depends/Makefile
@@ -45,7 +45,7 @@ NO_USDT ?=
NO_NATPMP ?=
MULTIPROCESS ?=
LTO ?=
-FALLBACK_DOWNLOAD_PATH ?= https://bitcoincore.org/depends-sources
+FALLBACK_DOWNLOAD_PATH ?= https://drahtbot.space/depends_download_fallback

C_STANDARD ?= c11
CXX_STANDARD ?= c++17
...

💬 MarcoFalke commented on issue "depends: Multiple `FALLBACK_DOWNLOAD_PATH`s":
(https://github.com/bitcoin/bitcoin/issues/17234#issuecomment-1526028066)
Same as https://github.com/bitcoin/bitcoin/pull/17704

💬 MarcoFalke commented on issue "v 0.17.0 win 7 64 bit missing recent transactions. ":
(https://github.com/bitcoin/bitcoin/issues/14541#issuecomment-1526032160)
> see https://github.com/bitcoin/bitcoin/pull/25880

This is a wallet issue, so the ref seems wrong?

💬 LarryRuane commented on pull request "test: allow BITCOIN_TEST_PATH to specify working dir":
(https://github.com/bitcoin/bitcoin/pull/26564#issuecomment-1526037535)
Yes, still hoping to get this merged. Force-pushed 5df0ed5ab789e005cb9aa0fc3ab61b7ce0b80ec8 to rebase onto the latest master (since it's been a long time)

💬 LarryRuane commented on pull request "test: allow BITCOIN_TEST_PATH to specify working dir":
(https://github.com/bitcoin/bitcoin/pull/26564#issuecomment-1526052311)
Another force push to improve the doc slightly and to address review comments, thanks @kouloumos!

Ready for review, also ping @theStack.