💬 pinheadmz commented on issue "signrawtransaction incorrectly reports "complete" as false when the transaction is completely signed":
(https://github.com/bitcoin/bitcoin/issues/5960#issuecomment-1525784139)
This is no longer an issue in recent versions of Bitcoin Core. We'll close it for now, please feel free to add additional comments or open a new issue if you think that would be helpful.

Deprecated by PSBT

✅ pinheadmz closed an issue: "Periodic automatic UTXO database backup"
(https://github.com/bitcoin/bitcoin/issues/8037)

💬 pinheadmz commented on issue "iOS Deployment Target for RPC":
(https://github.com/bitcoin/bitcoin/issues/11720#issuecomment-1525793880)
Superceded by kernel

✅ pinheadmz closed an issue: "iOS Deployment Target for RPC"
(https://github.com/bitcoin/bitcoin/issues/11720)

✅ pinheadmz closed an issue: "Improving fee bumping in Core"
(https://github.com/bitcoin/bitcoin/issues/12271)

💬 pinheadmz commented on issue "minRelayTxFee should be calculated on weight, not vbytes. aka "vbytes must die"":
(https://github.com/bitcoin/bitcoin/issues/13283#issuecomment-1525797070)
This issue is unlikely to be fixed in Bitcoin Core. We'll close for now, but feel free to open another issue or pull request with a fix.

✅ pinheadmz closed an issue: "minRelayTxFee should be calculated on weight, not vbytes. aka "vbytes must die""
(https://github.com/bitcoin/bitcoin/issues/13283)

💬 pinheadmz commented on issue "RPC getblockstats first argument inconsistency":
(https://github.com/bitcoin/bitcoin/issues/15412#issuecomment-1525798918)
This issue is unlikely to be fixed in Bitcoin Core. We'll close for now, but feel free to open another issue or pull request with a fix.

✅ pinheadmz closed an issue: "RPC getblockstats first argument inconsistency"
(https://github.com/bitcoin/bitcoin/issues/15412)

💬 pinheadmz commented on issue "build: Explore building with musl as libc":
(https://github.com/bitcoin/bitcoin/issues/18110#issuecomment-1525801053)
This issue is unlikely to be fixed in Bitcoin Core. We'll close for now, but feel free to open another issue or pull request with a fix.

✅ pinheadmz closed an issue: "build: Explore building with musl as libc"
(https://github.com/bitcoin/bitcoin/issues/18110)

💬 pinheadmz commented on issue "Allow groups of accounts to access the RPC cookie file":
(https://github.com/bitcoin/bitcoin/issues/25270#issuecomment-1525819410)
This issue is unlikely to be fixed in Bitcoin Core. We'll close for now, but feel free to open another issue or pull request with a fix.

✅ pinheadmz closed an issue: "Allow groups of accounts to access the RPC cookie file"
(https://github.com/bitcoin/bitcoin/issues/25270)

✅ pinheadmz closed an issue: "GUI unresponsive during slow operations"
(https://github.com/bitcoin/bitcoin/issues/10504)

💬 RandyMcMillan commented on pull request "Bump python minimum version to 3.8":
(https://github.com/bitcoin/bitcoin/pull/27483#issuecomment-1525824196)
https://github.com/bitcoin/bitcoin/pull/27130

✅ pinheadmz closed an issue: "assumeutxo"
(https://github.com/bitcoin/bitcoin/issues/15605)

💬 ccdle12 commented on pull request "Remove now-unnecessary poll, fcntl includes from net(base).cpp":
(https://github.com/bitcoin/bitcoin/pull/27530#issuecomment-1525855649)
tACK

<details><summary>I also ran netbase.cpp through the iwyu CI and seems like there maybe a few more unused imports, but I haven't thoroughly tested removing the other ones</summary>
<p>

```
netbase.cpp should remove these lines:
- #include <fcntl.h> // lines 25-25
- #include <poll.h> // lines 29-29
- #include <chrono> // lines 18-18
- #include <cstdint> // lines 19-19
- #include <limits> // lines 21-21
```
</p>
</details>

💬 ryanofsky commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1179303184)
Just talked about this offline, but if possible to make ZMQ just take a pointer to BlockManager instead of NodeContext, that would be good. This way ZMQ would only have access to the state it actually needs

💬 jonatack commented on pull request "Remove now-unnecessary poll, fcntl includes from net(base).cpp":
(https://github.com/bitcoin/bitcoin/pull/27530#issuecomment-1525866006)
> Can you add this to iwyu CI to double check and aid reviewers?

I did that recently for these files while working on #27385; the results are here: https://cirrus-ci.com/task/6749578737745920

🤔 jonatack reviewed a pull request: "Remove now-unnecessary poll, fcntl includes from net(base).cpp"
(https://github.com/bitcoin/bitcoin/pull/27530#pullrequestreview-1404309583)
utACK b095ac573b89d6898168bb9fda2abf7622ddec09

Noticed these while doing #27385. Per https://cirrus-ci.com/task/6749578737745920:

```
net.cpp should remove these lines:
- #include <clientversion.h> // lines 15-15
- #include <crypto/sha256.h> // lines 18-18
- #include <fcntl.h> // lines 45-45
- #include <math.h> // lines 63-63
- #include <poll.h> // lines 53-53
- #include <array> // lines 57-57
- #include <unordered_map> // lines 61-61

netbase.cpp should remove these lines
...