💬 rkrux commented on pull request "test: group executed tests within the same directory":
(https://github.com/bitcoin/bitcoin/pull/31291#discussion_r1843545615)
> Think of each unit test as a separate child class inheriting from the testing setup class and implementing a run() method. Each one constructs a new instance of the setup class, thereby creating a new rand_str.

One thing that I noticed is that there are several such (`1731649167593349000`) time directories when the unit tests are run, each having around one test_name directory inside. Whereas for the functional tests, a dir such as `test_runner_?_🏃_20241115_150614` encapsulates all of them
...

💬 Sjors commented on pull request "Add waitNext() to BlockTemplate interface":
(https://github.com/bitcoin/bitcoin/pull/31283#discussion_r1843589729)
A `fee_threshold` of 0 combined with a `timeout` of 0 will immediately return a new template. This is useful for the Template Provider, because it needs to unconditionally send new templates to all connected clients if fees increased sufficiently for one its connected clients. (at least until cluster mempool makes the fee calculation trivially cheap)

📝 marcofleon converted_to_draft a pull request: "fuzz: Fix difficulty target generation in `p2p_headers_presync`"
(https://github.com/bitcoin/bitcoin/pull/31213)
In the `p2p_headers_presync` fuzz target, this assertion failed:
```
assert(total_work < chainman.MinimumChainWork());
```
Input that triggered the failure: [p2ppresync_crash.txt](https://github.com/user-attachments/files/17620203/p2ppresync_crash.txt)

The test previously used `ConsumeIntegralInRange` to generate header difficulty targets within a hardcoded range. The fuzzer found specific values in that range that correspond to very low thresholds due to how [`SetCompact`][setcompact-l
...

💬 Yygik commented on pull request "validation: fix m_best_header tracking and BLOCK_FAILED_CHILD assignment":
(https://github.com/bitcoin/bitcoin/pull/30666#discussion_r1843669771)
各方面看过嗯结果OK

💬 Yygik commented on pull request "validation: fix m_best_header tracking and BLOCK_FAILED_CHILD assignment":
(https://github.com/bitcoin/bitcoin/pull/30666#issuecomment-2478676296)
i额迷你发光你放哪更好

⚠️ Yygik opened an issue: "i额迷你发光你放哪更好"
(https://github.com/bitcoin/bitcoin/issues/31294)
i额迷你发光你放哪更好

_Originally posted by @Yygik in https://github.com/bitcoin/bitcoin/issues/30666#issuecomment-2478676296_

✅ Yygik closed an issue: "i额迷你发光你放哪更好"
(https://github.com/bitcoin/bitcoin/issues/31294)

:lock: fanquake locked an issue: "i额迷你发光你放哪更好"
(https://github.com/bitcoin/bitcoin/issues/31294)

💬 sipa commented on issue "Discover() will not run if listening on any address with an explicit bind=0.0.0.0":
(https://github.com/bitcoin/bitcoin/issues/31293#issuecomment-2478721606)
> Operating system and version
>
> Windows 3.11

Doubt.

👋 marcofleon's pull request is ready for review: "fuzz: Fix difficulty target generation in `p2p_headers_presync`"
(https://github.com/bitcoin/bitcoin/pull/31213)

💬 marcofleon commented on pull request "fuzz: Fix difficulty target generation in `p2p_headers_presync`":
(https://github.com/bitcoin/bitcoin/pull/31213#discussion_r1843774945)
As is, the test doesn't hit that part in `pow.cpp`. But I'll look to improve this test and its coverage in a future PR. Still thinking about the best way to do it. For now, I'm going leave it as is and just be sure that the crash is fixed.

👍 ryanofsky approved a pull request: "refactor: Avoid std::string format strings"
(https://github.com/bitcoin/bitcoin/pull/31287#pullrequestreview-2438629037)
Code review ACK fa1177e3d7ca9ef003ded4d0c915fa6dc22bd37d

I think I'll merge this PR shortly so we can make progress on related PRs #31061 and #31072, but you can let me know if you would prefer this _not_ to be merged now in case you want to address the [comment](https://github.com/bitcoin/bitcoin/pull/31287#discussion_r1842156687) that using `strprintf("%s %s", ...)` instead of `+` makes code more confusing

💬 ryanofsky commented on pull request "refactor: Avoid std::string format strings":
(https://github.com/bitcoin/bitcoin/pull/31287#discussion_r1843809721)
In commit "refactor: Avoid std::string format strings" (fa1177e3d7ca9ef003ded4d0c915fa6dc22bd37d)

Note: Precedes this PR, but there appears to be mixed translation bugs here and below. GetDisplayName() can return the english string "[default wallet]" while "Rescanning" is translated. This might become a non-issue after the legacy wallet removal where (I'm assuming) unnamed wallets will finally get names? I think having more type safety to make it harder to accidentally combine translated and
...

💬 ryanofsky commented on pull request "refactor: Avoid std::string format strings":
(https://github.com/bitcoin/bitcoin/pull/31287#discussion_r1843821603)
re: https://github.com/bitcoin/bitcoin/pull/31287#discussion_r1842156687

I think this confusion only backs up the original comment that:

```c++
ShowProgress(GetDisplayName() + " " + _("Rescanning…").translated, 0);
```

is clearer than:

```c++
ShowProgress(strprintf("%s %s", GetDisplayName(), _("Rescanning…").translated), 0);
```

💬 TheCharlatan commented on pull request "build: increase minimum supported Windows to 10.0":
(https://github.com/bitcoin/bitcoin/pull/31172#issuecomment-2479011646)
Guix build:
```
606d0909c4591fc7dac3759e230e7bd3de00555c1c535d437ca8bc19df85fc70 guix-build-ee1128ead846/output/aarch64-linux-gnu/SHA256SUMS.part
4aca1c476b6824d485044c6636ce2ecf45f542a89bc501493f4868cf16c13d1f guix-build-ee1128ead846/output/aarch64-linux-gnu/bitcoin-ee1128ead846-aarch64-linux-gnu-debug.tar.gz
46d17a50226b60af12124b9c2b70cdab1c257a2034463999c0340d8a8b573cdd guix-build-ee1128ead846/output/aarch64-linux-gnu/bitcoin-ee1128ead846-aarch64-linux-gnu.tar.gz
d82c381c8d4e888ea552
...

💬 maflcko commented on pull request "refactor: Avoid std::string format strings":
(https://github.com/bitcoin/bitcoin/pull/31287#discussion_r1843917615)
Maybe a follow-up can fix this, so that this remains a refactor?

💬 maflcko commented on pull request "refactor: Avoid std::string format strings":
(https://github.com/bitcoin/bitcoin/pull/31287#discussion_r1843918244)
I'll leave as-is for now. I think both are fine.

💬 instagibbs commented on pull request "policy: ephemeral dust followups":
(https://github.com/bitcoin/bitcoin/pull/31279#discussion_r1843921416)
touched up

💬 instagibbs commented on pull request "policy: ephemeral dust followups":
(https://github.com/bitcoin/bitcoin/pull/31279#discussion_r1843921461)
done

🚀 ryanofsky merged a pull request: "refactor: Avoid std::string format strings"
(https://github.com/bitcoin/bitcoin/pull/31287)