⚠️ southunitedraza opened an issue: "https://fb.gg/play/bravoslotsgame/d/1090680746136943/"
(https://github.com/bitcoin/bitcoin/issues/31280)
https://fb.gg/play/bravoslotsgame/d/1090680746136943/

✅ fanquake closed an issue: "https://fb.gg/play/bravoslotsgame/d/1090680746136943/"
(https://github.com/bitcoin/bitcoin/issues/31280)

:lock: fanquake locked an issue: "https://fb.gg/play/bravoslotsgame/d/1090680746136943/"
(https://github.com/bitcoin/bitcoin/issues/31280)

🤔 fjahr reviewed a pull request: "wallet, rpc: Settxfeerate"
(https://github.com/bitcoin/bitcoin/pull/31278#pullrequestreview-2430637810)
Did you try to follow the approach suggested here: https://github.com/bitcoin/bitcoin/issues/31088#issuecomment-2413394142? If not, can you say why it didn't work?

💬 fjahr commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838736610)
Examples copy+pasted but not updated

💬 fjahr commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838745844)
Why "will be deprecated"? Why not actually deprecate it?

💬 fjahr commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838750890)
I don't think that's the right description

💬 fjahr commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838736093)
Why 2014-2022?

💬 fjahr commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838749101)
Do we set deprecated rpc methods to hidden? I'm not sure I have seen that before.

💬 ismaelsadeeq commented on pull request "Policy: Report reason inputs are non standard":
(https://github.com/bitcoin/bitcoin/pull/29060#issuecomment-2471554421)
> The release note helps a lot. To err on the side of caution, it seems appropriate to include a `-deprecatedrpc=` option, to enable a period of deprecation for users.

Thanks for your review @tdb3 will address this comment soon.

💬 polespinasa commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838753630)
thanks for the observation, will correct it

💬 polespinasa commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838754267)
have to update, used a template from an old test

💬 polespinasa commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838754885)
Avoid incompatibility problems with programs actually using this RPC call.

💬 polespinasa commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838755718)
it's what it's suggested on https://github.com/bitcoin/bitcoin/issues/31088

💬 polespinasa commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838756057)
copy paste for a template, I will update it

💬 ismaelsadeeq commented on pull request "Refactor BnB tests":
(https://github.com/bitcoin/bitcoin/pull/29532#discussion_r1838735560)
After this PR, we will have two coin selection test files. Is there a reason why?
Wouldn't it be better to add a commit that renames `coinselector_tests` to `coinselection_tests` and modify the test name to `coinselection_tests`?

💬 ismaelsadeeq commented on pull request "Refactor BnB tests":
(https://github.com/bitcoin/bitcoin/pull/29532#discussion_r1838729200)
In a8bf940ae20ed5a03a1cc328212fcac3c3462b43
A comment explaining why you selected these magic numbers would be helpful.
similar to `tx_noinputs_size` or an indication if they are just random.

but in initializing CSP, and some defaults in `MakeCoin`

💬 ismaelsadeeq commented on pull request "Refactor BnB tests":
(https://github.com/bitcoin/bitcoin/pull/29532#discussion_r1838770918)
Since we are checking for Value equivalence, this can just be
`CheckValueEquivalence` for clarity

💬 ismaelsadeeq commented on pull request "Refactor BnB tests":
(https://github.com/bitcoin/bitcoin/pull/29532#discussion_r1838771982)
```suggestion
auto ret = std::mismatch(a_amts.begin(), a_amts.end(), b_amts.begin());
```

💬 ismaelsadeeq commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1838790179)
Ahh Makes sense