👍 theStack approved a pull request: "Ephemeral Dust"
(https://github.com/bitcoin/bitcoin/pull/30239#pullrequestreview-2430361343)
re-ACK 5c2e291060cca3be500f3af0f6f2d3fd2177a7c9

💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1838568129)
mmm, seems like a test of generateblock to me? going to leave as is

📝 instagibbs opened a pull request: "policy: ephemeral dust followups"
(https://github.com/bitcoin/bitcoin/pull/31279)
Here are the parent PR's comments that should be addressed by this PR:

https://github.com/bitcoin/bitcoin/pull/30239/files#r1834529646
https://github.com/bitcoin/bitcoin/pull/30239/files#r1831247308
https://github.com/bitcoin/bitcoin/pull/30239/files#r1832622481
https://github.com/bitcoin/bitcoin/pull/30239/files#r1831195216
https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1835805164
https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1835805164
https://github.com/bitcoin
...

💬 ariard commented on pull request "Halt processing of unrequested transactions v2":
(https://github.com/bitcoin/bitcoin/pull/30572#issuecomment-2471402156)
> I was seeing were mostly non-segwit transactions - not unsolicited transactions. The problematic commit seems to be https://github.com/bitcoin/bitcoin/commit/c7bc444d02d34273a0a42806745e6a32b3146143.

@0xB10C Thanks, that’s interesting. I’ll dig into the `TxRequester`, if due to switching from iterating by status to iterate by peers, if the processing for non-segwit transactions and segwit transactions is always the same.

—————

>Between 2024-10-29T22:50:51 and 2024-10-29T23:54 the nod
...

⚠️ southunitedraza opened an issue: "https://fb.gg/play/bravoslotsgame/d/1090680746136943/"
(https://github.com/bitcoin/bitcoin/issues/31280)
https://fb.gg/play/bravoslotsgame/d/1090680746136943/

✅ fanquake closed an issue: "https://fb.gg/play/bravoslotsgame/d/1090680746136943/"
(https://github.com/bitcoin/bitcoin/issues/31280)

:lock: fanquake locked an issue: "https://fb.gg/play/bravoslotsgame/d/1090680746136943/"
(https://github.com/bitcoin/bitcoin/issues/31280)

🤔 fjahr reviewed a pull request: "wallet, rpc: Settxfeerate"
(https://github.com/bitcoin/bitcoin/pull/31278#pullrequestreview-2430637810)
Did you try to follow the approach suggested here: https://github.com/bitcoin/bitcoin/issues/31088#issuecomment-2413394142? If not, can you say why it didn't work?

💬 fjahr commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838736610)
Examples copy+pasted but not updated

💬 fjahr commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838745844)
Why "will be deprecated"? Why not actually deprecate it?

💬 fjahr commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838750890)
I don't think that's the right description

💬 fjahr commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838736093)
Why 2014-2022?

💬 fjahr commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838749101)
Do we set deprecated rpc methods to hidden? I'm not sure I have seen that before.

💬 ismaelsadeeq commented on pull request "Policy: Report reason inputs are non standard":
(https://github.com/bitcoin/bitcoin/pull/29060#issuecomment-2471554421)
> The release note helps a lot. To err on the side of caution, it seems appropriate to include a `-deprecatedrpc=` option, to enable a period of deprecation for users.

Thanks for your review @tdb3 will address this comment soon.

💬 polespinasa commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838753630)
thanks for the observation, will correct it

💬 polespinasa commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838754267)
have to update, used a template from an old test

💬 polespinasa commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838754885)
Avoid incompatibility problems with programs actually using this RPC call.

💬 polespinasa commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838755718)
it's what it's suggested on https://github.com/bitcoin/bitcoin/issues/31088

💬 polespinasa commented on pull request "wallet, rpc: Settxfeerate":
(https://github.com/bitcoin/bitcoin/pull/31278#discussion_r1838756057)
copy paste for a template, I will update it

💬 ismaelsadeeq commented on pull request "Refactor BnB tests":
(https://github.com/bitcoin/bitcoin/pull/29532#discussion_r1838735560)
After this PR, we will have two coin selection test files. Is there a reason why?
Wouldn't it be better to add a commit that renames `coinselector_tests` to `coinselection_tests` and modify the test name to `coinselection_tests`?