💬 glozow commented on pull request "[mempool] allow tx replacement by smaller witness":
(https://github.com/bitcoin/bitcoin/pull/24007#issuecomment-1522007031)
Closing as there doesn't seem to be much support for this change - it's still unclear whether any use cases exist. If something changes, please feel free to comment and we can revisit this at a later time.

✅ glozow closed a pull request: "[mempool] allow tx replacement by smaller witness"
(https://github.com/bitcoin/bitcoin/pull/24007)

📝 brunoerg converted_to_draft a pull request: "p2p: delete anchors.dat after trying to connect to that peers"
(https://github.com/bitcoin/bitcoin/pull/24034)
In the current scenario, `anchors.dat` is deleted right after reading it, however, if my node stops before trying to connect to the anchors peers, it will create an empty `anchors.dat`. This PR changes it to delete `anchors.dat` after trying to connect to the peers from it. So, if my node stops (**in a clean way**) before trying to connect to that peers, the `anchors.dat` file will be preserved and a dump won't happen.

💬 achow101 commented on pull request "Add ASM optimizations for MuHash3072":
(https://github.com/bitcoin/bitcoin/pull/19181#issuecomment-1522014008)

@real-or-random

💬 achow101 commented on pull request "refactor: Extract MIB_BYTES constant for init.cpp":
(https://github.com/bitcoin/bitcoin/pull/25386#issuecomment-1522019921)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

✅ achow101 closed a pull request: "refactor: Extract MIB_BYTES constant for init.cpp"
(https://github.com/bitcoin/bitcoin/pull/25386)

💬 glozow commented on pull request "util: Show descriptive error messages when FileCommit fails":
(https://github.com/bitcoin/bitcoin/pull/26654#issuecomment-1522020092)
@john-moffett please rebase?

💬 achow101 commented on pull request "Add reindex=auto flag to automatically reindex corrupt data":
(https://github.com/bitcoin/bitcoin/pull/26674#issuecomment-1522021327)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

Closing due to lack of interest. Pull requests with improvements are always welcome.

✅ achow101 closed a pull request: "Add reindex=auto flag to automatically reindex corrupt data"
(https://github.com/bitcoin/bitcoin/pull/26674)

💬 achow101 commented on pull request "contrib/init: Better systemd integration":
(https://github.com/bitcoin/bitcoin/pull/25975#issuecomment-1522023013)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

Closing due to lack of interest. Pull requests with improvements are always welcome.

✅ achow101 closed a pull request: "contrib/init: Better systemd integration"
(https://github.com/bitcoin/bitcoin/pull/25975)

✅ achow101 closed a pull request: "Move `CopyrightHolders()` and `LicenseInfo()` into `libbitcoin_common`"
(https://github.com/bitcoin/bitcoin/pull/26688)

📝 achow101 converted_to_draft a pull request: "wallet: tx creation, don't select outputs from txes that are being replaced"
(https://github.com/bitcoin/bitcoin/pull/26732)
Adding test coverage and the needed checks for two scenarios
where the wallet creates invalid transactions.


#### First Scenario, Do Not Use Outputs From the Tx Being Replaced

When the wallet creates/fund a replacement transaction, it should
not fund the new transaction with outputs belonging to the tx
being replaced.

Reason:
Once replaced, those outputs are no longer going to exist, there
by the created/funded transaction will be invalid.

#### Second Scenario, Do Not Create BI
...

💬 achow101 commented on pull request "policy: Report reason inputs are nonstandard from AreInputsStandard":
(https://github.com/bitcoin/bitcoin/pull/13525#issuecomment-1522029174)
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

✅ achow101 closed a pull request: "policy: Report reason inputs are nonstandard from AreInputsStandard"
(https://github.com/bitcoin/bitcoin/pull/13525)

💬 achow101 commented on pull request "Safegcd-based modular inverses in MuHash3072":
(https://github.com/bitcoin/bitcoin/pull/21590#issuecomment-1522036913)
cc @real-or-random @fjahr

💬 achow101 commented on pull request "test: Remove unused coin_selection param":
(https://github.com/bitcoin/bitcoin/pull/26110#issuecomment-1522037326)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

Closing due to lack of interest. Pull requests with improvements are always welcome.

✅ achow101 closed a pull request: "test: Remove unused coin_selection param"
(https://github.com/bitcoin/bitcoin/pull/26110)

💬 achow101 commented on pull request "refactor: Simplify bnb coin_selection test params":
(https://github.com/bitcoin/bitcoin/pull/26111#issuecomment-1522038714)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

Closing due to lack of interest. Pull requests with improvements are always welcome.

✅ achow101 closed a pull request: "refactor: Simplify bnb coin_selection test params"
(https://github.com/bitcoin/bitcoin/pull/26111)