Bitcoin Core Github
44 subscribers
121K links
Download Telegram
💬 achow101 commented on pull request "p2p: skip netgroup diversity follow-up":
(https://github.com/bitcoin/bitcoin/pull/27467#issuecomment-1521500955)
While renaming this variable is technically correct, I don't think it's useful to have these kind of PRs. Although it is small and trivial, it does take away time from review, has an effect on git blaming, and possibly conflicts with other PRs in this area that do introduce meaningful changes.
💬 jonatack commented on pull request "p2p: skip netgroup diversity follow-up":
(https://github.com/bitcoin/bitcoin/pull/27467#issuecomment-1521526214)
@achow101 The code comment needs to be fixed as it is now incorrect, and the naming is now misleading. I think the change is clearly justified here.
💬 MarcoFalke commented on pull request "Fix unsigned integer overflows in interpreter":
(https://github.com/bitcoin/bitcoin/pull/24214#issuecomment-1521549361)
Closing for now due to inactivity. I still think this is useful (see OP) and we should re-evaluate it the next time the interpreter.cpp is changed to catch newly introduced unintended unsigned integer overflow.
MarcoFalke closed a pull request: "Fix unsigned integer overflows in interpreter"
(https://github.com/bitcoin/bitcoin/pull/24214)
🚀 fanquake merged a pull request: "test: simplify uint256 (de)serialization routines"
(https://github.com/bitcoin/bitcoin/pull/27516)
💬 jonatack commented on pull request "refactor: move index class members from protected to private":
(https://github.com/bitcoin/bitcoin/pull/24150#issuecomment-1521605660)
Closing temporarily so that I can re-open it -- am still interested to work on this.
jonatack closed a pull request: "refactor: move index class members from protected to private"
(https://github.com/bitcoin/bitcoin/pull/24150)
💬 jonatack commented on pull request "Add cs_main annotation to WriteBatchSync(), drop lock in CDiskBlockIndex":
(https://github.com/bitcoin/bitcoin/pull/24199#issuecomment-1521606641)
Closing temporarily so that I can re-open it -- am still interested to work on this.
jonatack closed a pull request: "Add cs_main annotation to WriteBatchSync(), drop lock in CDiskBlockIndex"
(https://github.com/bitcoin/bitcoin/pull/24199)
💬 jonatack commented on pull request "Severity-based logging -- parent PR":
(https://github.com/bitcoin/bitcoin/pull/25203#issuecomment-1521607155)
Closing temporarily so that I can re-open it -- am still interested to finish this.
jonatack closed a pull request: "Severity-based logging -- parent PR"
(https://github.com/bitcoin/bitcoin/pull/25203)
💬 jonatack commented on pull request "p2p: always provide CNodeStateStats and getpeerinfo/netinfo/gui updates":
(https://github.com/bitcoin/bitcoin/pull/25923#issuecomment-1521607657)
Closing temporarily so that I can re-open it -- am still interested to finish this.
jonatack closed a pull request: "p2p: always provide CNodeStateStats and getpeerinfo/netinfo/gui updates"
(https://github.com/bitcoin/bitcoin/pull/25923)
💬 sipa commented on pull request "Optimizations & simplifications following #25717":
(https://github.com/bitcoin/bitcoin/pull/25968#issuecomment-1521954195)
Closing as up for grabs.
sipa closed a pull request: "Optimizations & simplifications following #25717"
(https://github.com/bitcoin/bitcoin/pull/25968)
💬 achow101 commented on pull request "tracing: macOS USDT support":
(https://github.com/bitcoin/bitcoin/pull/25541#issuecomment-1521971098)
What's the status of this?
achow101 closed a pull request: "script: create V1SigVersion for functions which should only accept taproot/tapscript"
(https://github.com/bitcoin/bitcoin/pull/26101)
achow101 closed a pull request: "Refactor: Improve API design of `ScriptToUniv`, `TxToUniv` etc to return the `UniValue` instead of mutating a parameter/reference"
(https://github.com/bitcoin/bitcoin/pull/23507)
achow101 closed a pull request: "p2p: Replace RecursiveMutex `m_tx_inventory_mutex` with Mutex and rename it"
(https://github.com/bitcoin/bitcoin/pull/24125)
💬 achow101 commented on pull request "index: Compare deserialized block hash with the block hash from the blockindex":
(https://github.com/bitcoin/bitcoin/pull/26390#issuecomment-1521985512)
Are you still working on this?