💬 bigspider commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#issuecomment-2462726758)
Attempting some fancier setups, I'm trying to do a "decaying MuSig" that starts as a 3-of-3 in the keypath, with 3 timelocked 2-of-2 in the scriptpaths.

```
$ ./bitcoin-cli -regtest getdescriptorinfo "tr(musig(tpubDD863BuWFdsaCg6f1SGdwLxp9mDcm3YRm3HxxbppBrizxvU1MqhQ1WpMwhz4vrZHNT7NFbXQ35CquVG9xaLsWaUWfSMZamDESisvtKZ7veF,tpubD6NzVbkrYhZ4YAPXpMw61GrdqXJJEiYhHo6wxVkfwZgUged5qXm6Df4NLf8ZTFXxW1UhxDKGeKdAVxZtmodC8KfR7SqmW6LGQfDGfnFLmQ6,tpubD6NzVbkrYhZ4WSLhjy9cMaGTEW7No4ALTRikqWo5xFsiTTkRfxA8eRyj2G
...

💬 marcofleon commented on pull request "ci: Split out native fuzz jobs for macOS and windows (take 2)":
(https://github.com/bitcoin/bitcoin/pull/31221#issuecomment-2462727501)
Concept ACK

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#issuecomment-2462749804)
`musig()` is not being parsed in Miniscript expressions yet.

📝 achow101 opened a pull request: "wallet, desc spkm: Return SigningProvider only if we have the privkey"
(https://github.com/bitcoin/bitcoin/pull/31242)
If we know about a pubkey that's in our descriptor, but we don't have the private key, don't return a SigningProvider for that pubkey.

This is specifically an issue for Taproot outputs that use the H point as the resulting PSBTs may end up containing irrelevant information because the H point was detected as a pubkey each unrelated descriptor knew about.

Split from #29675

📝 achow101 opened a pull request: "descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey`"
(https://github.com/bitcoin/bitcoin/pull/31243)
Instead of having `MakeScripts` infer what pubkeys need to go into the output `FlatSigningProvider`, have each of the `PubkeyProviders` that have `GetPubKey` called fill it directly with relevant keys and origins.

This allows for keys and origins to be added that won't directly appear in the output, which is necessary for `musig()` descriptors.

Split from #29675

💬 sdaftuar commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1833035081)
Done

💬 sdaftuar commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1833036997)
My thought was that we're storing `CTxMemPool::txiter` objects internally, but the `TxHandle` object could be replaced with some other wrapper if we wanted to hide the internals of the mempool further. So I'm leaving this as-is for now.

💬 bigspider commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#issuecomment-2462766759)
> `musig()` is not being parsed in Miniscript expressions yet.

Ah, ok, I'll keep an eye for updates.
Thanks!

💬 sdaftuar commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1833040860)
Updated the commit message.

💬 sdaftuar commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1833040997)
Gone.

💬 sdaftuar commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1833043139)
I cherry-picked https://github.com/0xB10C/bitcoin/commit/2eb1410e774636040d19d3baf5e22b2e4a8fbfd2, which updates the documentation and resolves the issue discussed above: https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1832803900

💬 fanquake commented on pull request "depends: Specify CMake generator explicitly":
(https://github.com/bitcoin/bitcoin/pull/31171#issuecomment-2462789506)
Guix Build:
```bash
2b8363e54965bc413159a4dbc371a70e4c8a77976c196c57747917928009ed03 guix-build-e2ba8236715e/output/aarch64-linux-gnu/SHA256SUMS.part
4b0b3358ffe8c136759ff8594e5ea4502a7b9299f3c3b271c65bc3187b832960 guix-build-e2ba8236715e/output/aarch64-linux-gnu/bitcoin-e2ba8236715e-aarch64-linux-gnu-debug.tar.gz
303f29d256c2f31909b8a6ffdbcb2c6fd974a3e188bb6726de369c8746ad4b9f guix-build-e2ba8236715e/output/aarch64-linux-gnu/bitcoin-e2ba8236715e-aarch64-linux-gnu.tar.gz
df57974010085f36
...

👍 fanquake approved a pull request: "depends: Specify CMake generator explicitly"
(https://github.com/bitcoin/bitcoin/pull/31171#pullrequestreview-2421636564)
ACK e2ba8236715ee4530d08312b075d8b41cb592257 - Going forward I think we should look at making this work without having to hard code anything.

🚀 fanquake merged a pull request: "depends: Specify CMake generator explicitly"
(https://github.com/bitcoin/bitcoin/pull/31171)

💬 fanquake commented on pull request "wallet: remove BDB dependency from wallet migration benchmark":
(https://github.com/bitcoin/bitcoin/pull/31241#issuecomment-2462816933)
https://cirrus-ci.com/task/4957802181951488?logs=ci#L1777:
```bash
[17:17:27.480] Thread T4 'b-httpworker.1' (tid=27041, running) created by main thread at:
[17:17:27.480] #0 pthread_create <null> (bitcoind+0xf7df5) (BuildId: 759dffa438a525872edb969c48b6c5c4c6341482)
[17:17:27.480] #1 std::__1::__libcpp_thread_create[abi:ne190103](unsigned long*, void* (*)(void*), void*) /usr/lib/llvm-19/bin/../include/c++/v1/__thread/support/pthread.h:182:10 (bitcoind+0x6e06fb) (BuildId: 759dffa43
...

🚀 fanquake merged a pull request: "TxDownloadManager followups"
(https://github.com/bitcoin/bitcoin/pull/31190)

💬 sdaftuar commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1833111731)
Thanks! I've included your commit (and will mark this as resolved).

👋 edilmedeiros's pull request is ready for review: "RFC: doc: Fix dead links to mailing list archives"
(https://github.com/bitcoin/bitcoin/pull/31240)

📝 achow101 opened a pull request: "descriptors: MuSig2"
(https://github.com/bitcoin/bitcoin/pull/31244)
Implements parsing of BIP 328 `musig()` descriptors.

Depends on #31243

Split from #29675

📝 achow101 opened a pull request: "wallet: Sign transactions containing MuSig2 inputs"
(https://github.com/bitcoin/bitcoin/pull/31245)
Implements all of the signing logic for transactions containing MuSig2 inputs.

Note that this is not actually usable as the session data for MuSig2 is not stored. That will require the PSBT fields from #29675

Depends on #31242, #31243, and #31244

Split from #29675