💬 Gezegorz1 commented on issue "macOS App Notarization":
(https://github.com/bitcoin/bitcoin/issues/15774#issuecomment-1519175607)
niedz., 23 kwi 2023 o 17:07 Will Clark ***@***.***>
napisał(a):

> The policy reads to me that notarization will *always* phone home, even
> in the case of having an externally-stapled ticket, *unless* a connection
> is not available in which case the stapled ticket is locally verified.
> Therefore it seems to me that we have two options available:
>
> 1.
>
> Notarize the binary and somehow communicate to users that if they
> don't want Apple to know that they are running Bitcoin Core t
...

⚠️ Martinlopez-hash opened an issue: "Open source"
(https://github.com/bitcoin/bitcoin/issues/27522)

✅ willcl-ark closed an issue: "Open source"
(https://github.com/bitcoin/bitcoin/issues/27522)

💬 Gezegorz1 commented on issue "Open source":
(https://github.com/bitcoin/bitcoin/issues/27522#issuecomment-1519197775)
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt
...

:lock: achow101 locked an issue: "Open source"
(https://github.com/bitcoin/bitcoin/issues/27522)

📝 ethanjlim opened a pull request: "testing things..."
(https://github.com/bitcoin/bitcoin/pull/27523)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ fanquake closed a pull request: "testing things..."
(https://github.com/bitcoin/bitcoin/pull/27523)

📝 fanquake locked a pull request: "testing things..."
(https://github.com/bitcoin/bitcoin/pull/27523)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 ChrisCho-H commented on pull request "script: add description for the functionality of each opcode":
(https://github.com/bitcoin/bitcoin/pull/27109#issuecomment-1519433917)
Looking for code reviewers! appreciate voluntary dedication in advance 🙏

💬 MarcoFalke commented on pull request "httpserver, rest: fix segmentation fault on evhttp_uri_get_query":
(https://github.com/bitcoin/bitcoin/pull/27253#issuecomment-1519637810)
Fuzzing segfaults, see CI

💬 MarcoFalke commented on pull request "test: simplify uint256 (de)serialization routines":
(https://github.com/bitcoin/bitcoin/pull/27516#issuecomment-1519661945)
lgtm ACK 96bf0bca4a0e3aa0b7c07d8c225861e72f970fa9

💬 MarcoFalke commented on pull request "ci: use LLVM/clang-16 in native_asan job":
(https://github.com/bitcoin/bitcoin/pull/27360#discussion_r1174994067)
You'll have to do it in this pull. Otherwise CI will warn: E: The repository 'https://ppa.launchpadcontent.net/hadret/bpfcc/ubuntu lunar Release' does not have a Release file.

💬 pablomartin4btc commented on pull request "httpserver, rest: fix segmentation fault on evhttp_uri_get_query":
(https://github.com/bitcoin/bitcoin/pull/27253#issuecomment-1519869383)
> Fuzzing segfaults, see CI

Saw it yesterday, working on it, thanks.

👍 brunoerg approved a pull request: "test: simplify uint256 (de)serialization routines"
(https://github.com/bitcoin/bitcoin/pull/27516#pullrequestreview-1397816417)
crACK 96bf0bca4a0e3aa0b7c07d8c225861e72f970fa9

📝 FlannelDipole opened a pull request: "Updated the installation instructions for macOS"
(https://github.com/bitcoin/bitcoin/pull/27525)
Added: Instructions on changing directories after the repo clone (cd bitcoin)
(Rationale: The initial documentation assumes that the user knows to change the current directory to the cloned repository before running further commands. However, for new users or those unfamiliar with the command line, this step might not be obvious.)

Added: Instructions on verifying the build was successful and the GUI was compiled.
(Rationale: After compiling the Bitcoin Core software, it's important to verif
...

💬 ishaanam commented on pull request "bumpfee: allow send coins back to yourself":
(https://github.com/bitcoin/bitcoin/pull/27195#issuecomment-1520235843)
reACK be72663a1521bc6cdf16d43a4feae7c5b57735c0

💬 satsie commented on issue "Consider Removing Message Signing":
(https://github.com/bitcoin/bitcoin/issues/27515#issuecomment-1520380907)
Given that all features require some effort to maintain, does this message signing code have a disproportionately high maintenance cost? You mention it is being abused to verify wallets, but I want to echo jlopp's comment about its usage being, in the absence of another well established standard (official or not), a way to arbitrarily sign messages with private keys. From what I have seen, this feature is mainly used to verify the integrity of hardware and software wallets--to make sure the BIP-
...

💬 jonatack commented on pull request "Remove BIP35 mempool p2p message":
(https://github.com/bitcoin/bitcoin/pull/27426#issuecomment-1520408121)
Linking here this response to the ML request for feedback.

https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2023-April/021563.html

💬 ekzyis commented on pull request "Allow configuring target block time for a signet":
(https://github.com/bitcoin/bitcoin/pull/27446#issuecomment-1520485069)
utACK d8434da3c14ed6723d86ef2cd266008d366e1413

> **If we want to allow for more configurable signet consensus rules**, then I think we need to do it in a more robust way rather than ad-hoc adding options that all users must remember to set if they want to use a particular signet. As these are consensus parameters, forgetting to set the option correctly will result in eventual consensus failure which is generally only resolved by nuking the data directory. This may garner additional and unnece
...

⚠️ darosior opened an issue: "wallet coin selection: don't mixup coins with absolute timelocks of different types"
(https://github.com/bitcoin/bitcoin/issues/27526)
We now support spending from coins containing `CHECKLOCKTIMEVERIFY` instructions. `CLTV` is a check on the value of the `nLockTime` field of the spending transaction. There are two types of timelocks possible: by timestamp and by block. Both are incompatible, the `nLockTime` field cannot satisfy both a timestamp and a block timelock.

The coin selection is at the moment completely unaware of timelocks. If we have two coins for two different descriptors, one with a timestamp absolute timelock a
...