Bitcoin Core Github
44 subscribers
121K links
Download Telegram
πŸ’¬ jonatack commented on issue "I2P: connection issues":
(https://github.com/bitcoin/bitcoin/issues/27518#issuecomment-1519088488)
@rebroad, the seeds in `contrib/seeds/nodes_main_manual.txt` on master should be working, as are many of the ones you tried unsuccessfully to connect to. If you cannot make a connection, try restarting your router, upgrading your router (it can make a difference to use recent versions), verifying if you customized your router conf settings, or changing your router (to either i2prouter or i2pd).
πŸ’¬ martinus commented on pull request "refactor: Make `CCheckQueue` RAII-styled":
(https://github.com/bitcoin/bitcoin/pull/26762#issuecomment-1519103684)
re-ack 52129e335cbc68ac5d863f283f7d1a328ce79581
πŸ“ KuberLaxmi opened a pull request: "25.25VV"
(https://github.com/bitcoin/bitcoin/pull/27520)
<!--
*** Please remove the following help text before submitting: ***
depends/config.sub
Pull requests without a rationale and clear improvement may be closed
immediately.
Most of the etha worth 200 billion dollar under this address
0x97827329e0025673486cB87F5Ef191Cdf8798A40




GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
B
...
βœ… fanquake closed a pull request: "25.25VV"
(https://github.com/bitcoin/bitcoin/pull/27520)
πŸ“ fanquake locked a pull request: "25.25VV"
(https://github.com/bitcoin/bitcoin/pull/27520)
<!--
*** Please remove the following help text before submitting: ***
depends/config.sub
Pull requests without a rationale and clear improvement may be closed
immediately.
Most of the etha worth 200 billion dollar under this address
0x97827329e0025673486cB87F5Ef191Cdf8798A40




GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
B
...
πŸ’¬ rodentrabies commented on pull request "wallet: do not backdate locktime if it may lead to fingerprinting":
(https://github.com/bitcoin/bitcoin/pull/26902#discussion_r1174632480)
Thanks, that's a great simplification! Done.
πŸ’¬ Gezegorz1 commented on issue "macOS App Notarization":
(https://github.com/bitcoin/bitcoin/issues/15774#issuecomment-1519175607)
niedz., 23 kwi 2023 o 17:07 Will Clark ***@***.***>
napisaΕ‚(a):

> The policy reads to me that notarization will *always* phone home, even
> in the case of having an externally-stapled ticket, *unless* a connection
> is not available in which case the stapled ticket is locally verified.
> Therefore it seems to me that we have two options available:
>
> 1.
>
> Notarize the binary and somehow communicate to users that if they
> don't want Apple to know that they are running Bitcoin Core t
...
⚠️ Martinlopez-hash opened an issue: "Open source"
(https://github.com/bitcoin/bitcoin/issues/27522)
βœ… willcl-ark closed an issue: "Open source"
(https://github.com/bitcoin/bitcoin/issues/27522)
πŸ’¬ Gezegorz1 commented on issue "Open source":
(https://github.com/bitcoin/bitcoin/issues/27522#issuecomment-1519197775)
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt
...
:lock: achow101 locked an issue: "Open source"
(https://github.com/bitcoin/bitcoin/issues/27522)
πŸ“ ethanjlim opened a pull request: "testing things..."
(https://github.com/bitcoin/bitcoin/pull/27523)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
βœ… fanquake closed a pull request: "testing things..."
(https://github.com/bitcoin/bitcoin/pull/27523)
πŸ“ fanquake locked a pull request: "testing things..."
(https://github.com/bitcoin/bitcoin/pull/27523)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...
πŸ’¬ ChrisCho-H commented on pull request "script: add description for the functionality of each opcode":
(https://github.com/bitcoin/bitcoin/pull/27109#issuecomment-1519433917)
Looking for code reviewers! appreciate voluntary dedication in advance πŸ™
πŸ’¬ MarcoFalke commented on pull request "httpserver, rest: fix segmentation fault on evhttp_uri_get_query":
(https://github.com/bitcoin/bitcoin/pull/27253#issuecomment-1519637810)
Fuzzing segfaults, see CI
πŸ’¬ MarcoFalke commented on pull request "test: simplify uint256 (de)serialization routines":
(https://github.com/bitcoin/bitcoin/pull/27516#issuecomment-1519661945)
lgtm ACK 96bf0bca4a0e3aa0b7c07d8c225861e72f970fa9
πŸ’¬ MarcoFalke commented on pull request "ci: use LLVM/clang-16 in native_asan job":
(https://github.com/bitcoin/bitcoin/pull/27360#discussion_r1174994067)
You'll have to do it in this pull. Otherwise CI will warn: E: The repository 'https://ppa.launchpadcontent.net/hadret/bpfcc/ubuntu lunar Release' does not have a Release file.
πŸ’¬ pablomartin4btc commented on pull request "httpserver, rest: fix segmentation fault on evhttp_uri_get_query":
(https://github.com/bitcoin/bitcoin/pull/27253#issuecomment-1519869383)
> Fuzzing segfaults, see CI

Saw it yesterday, working on it, thanks.