✅ pablomartin4btc closed a pull request: "http, rest: improving segfault bugfix logic - optimisation"
(https://github.com/bitcoin/bitcoin/pull/27519)

💬 pablomartin4btc commented on pull request "httpserver, rest: fix segmentation fault on evhttp_uri_get_query":
(https://github.com/bitcoin/bitcoin/pull/27253#issuecomment-1519074456)
Updated changes:
- First commit of this PR was already merged into 25.0 release branch (#27468).
- Rebased & incorporated some nits & suggestions from latest reviews including above PR.

💬 rebroad commented on issue "I2P: connection issues":
(https://github.com/bitcoin/bitcoin/issues/27518#issuecomment-1519080020)
> Do you have other I2P connections working? If not, you may need to restart (or upgrade) your I2P router. What router and version are you using?
>
> Some of the nodes no longer exist, but I'm connected to several of them right now. If you're looking for seed nodes, try the ones in `contrib/seeds/nodes_main_manual.txt`.

I'm using the latest version of the i2p router that comes with Ubuntu 22.04 LTS.

💬 rebroad commented on issue "I2P: connection issues":
(https://github.com/bitcoin/bitcoin/issues/27518#issuecomment-1519080381)
Given this has been closed as "not planned" I'm going to assume I2P functionality isn't planned to be working and therefore will disable this from my node's configuration.

💬 willcl-ark commented on issue "macOS App Notarization":
(https://github.com/bitcoin/bitcoin/issues/15774#issuecomment-1519088393)
The policy reads to me that notarization will **always** phone home, even in the case of having an externally-stapled ticket, _unless_ a connection is not available in which case the stapled ticket is locally verified. Therefore it seems to me that we have two options available:

1) Notarize the binary and somehow communicate to users that if they don't want Apple to know that they are running Bitcoin Core they must start it up with no internet connection (under the assumption that Gatekeeper
...

💬 jonatack commented on issue "I2P: connection issues":
(https://github.com/bitcoin/bitcoin/issues/27518#issuecomment-1519088488)
@rebroad, the seeds in `contrib/seeds/nodes_main_manual.txt` on master should be working, as are many of the ones you tried unsuccessfully to connect to. If you cannot make a connection, try restarting your router, upgrading your router (it can make a difference to use recent versions), verifying if you customized your router conf settings, or changing your router (to either i2prouter or i2pd).

💬 jonatack commented on issue "I2P: connection issues":
(https://github.com/bitcoin/bitcoin/issues/27518#issuecomment-1519088662)
See https://jonatack.github.io/articles/using-alternative-p2p-networks-with-bitcoin-core#getting-started for more info.

💬 martinus commented on pull request "refactor: Make `CCheckQueue` RAII-styled":
(https://github.com/bitcoin/bitcoin/pull/26762#issuecomment-1519103684)
re-ack 52129e335cbc68ac5d863f283f7d1a328ce79581

📝 KuberLaxmi opened a pull request: "25.25VV"
(https://github.com/bitcoin/bitcoin/pull/27520)
<!--
*** Please remove the following help text before submitting: ***
depends/config.sub
Pull requests without a rationale and clear improvement may be closed
immediately.
Most of the etha worth 200 billion dollar under this address
0x97827329e0025673486cB87F5Ef191Cdf8798A40




GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
B
...

✅ fanquake closed a pull request: "25.25VV"
(https://github.com/bitcoin/bitcoin/pull/27520)

📝 fanquake locked a pull request: "25.25VV"
(https://github.com/bitcoin/bitcoin/pull/27520)
<!--
*** Please remove the following help text before submitting: ***
depends/config.sub
Pull requests without a rationale and clear improvement may be closed
immediately.
Most of the etha worth 200 billion dollar under this address
0x97827329e0025673486cB87F5Ef191Cdf8798A40




GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
B
...

💬 rodentrabies commented on pull request "wallet: do not backdate locktime if it may lead to fingerprinting":
(https://github.com/bitcoin/bitcoin/pull/26902#discussion_r1174632480)
Thanks, that's a great simplification! Done.

💬 Gezegorz1 commented on issue "macOS App Notarization":
(https://github.com/bitcoin/bitcoin/issues/15774#issuecomment-1519175607)
niedz., 23 kwi 2023 o 17:07 Will Clark ***@***.***>
napisał(a):

> The policy reads to me that notarization will *always* phone home, even
> in the case of having an externally-stapled ticket, *unless* a connection
> is not available in which case the stapled ticket is locally verified.
> Therefore it seems to me that we have two options available:
>
> 1.
>
> Notarize the binary and somehow communicate to users that if they
> don't want Apple to know that they are running Bitcoin Core t
...

⚠️ Martinlopez-hash opened an issue: "Open source"
(https://github.com/bitcoin/bitcoin/issues/27522)

✅ willcl-ark closed an issue: "Open source"
(https://github.com/bitcoin/bitcoin/issues/27522)

💬 Gezegorz1 commented on issue "Open source":
(https://github.com/bitcoin/bitcoin/issues/27522#issuecomment-1519197775)
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt
...

:lock: achow101 locked an issue: "Open source"
(https://github.com/bitcoin/bitcoin/issues/27522)

📝 ethanjlim opened a pull request: "testing things..."
(https://github.com/bitcoin/bitcoin/pull/27523)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ fanquake closed a pull request: "testing things..."
(https://github.com/bitcoin/bitcoin/pull/27523)

📝 fanquake locked a pull request: "testing things..."
(https://github.com/bitcoin/bitcoin/pull/27523)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...