✅ fanquake closed an issue: "Hm"
(https://github.com/bitcoin/bitcoin/issues/31218)

:lock: fanquake locked an issue: "Hm"
(https://github.com/bitcoin/bitcoin/issues/31218)

💬 sr-gi commented on pull request "p2p: Fill reconciliation sets (Erlay) attempt 2":
(https://github.com/bitcoin/bitcoin/pull/30116#discussion_r1828421634)
I'll squash in the next force push

✅ fanquake closed an issue: "Authentication with KYC"
(https://github.com/bitcoin/bitcoin/issues/31217)

💬 achow101 commented on pull request "fuzz: wallet: add target for spkm migration":
(https://github.com/bitcoin/bitcoin/pull/29694#discussion_r1828420886)
I think it would also be good to cover hd chain before hd chain split.

💬 achow101 commented on pull request "fuzz: wallet: add target for spkm migration":
(https://github.com/bitcoin/bitcoin/pull/29694#discussion_r1828423452)
It would be nice to have multisig scripts here as the handling of ismine for that is quite complicated and having fuzz testing of it would be great.

💬 achow101 commented on pull request "fuzz: wallet: add target for spkm migration":
(https://github.com/bitcoin/bitcoin/pull/29694#discussion_r1828421887)
Would it be possible for `script_count` to really be watchonly script count and just have it increment only when a watchonly script is added?

💬 achow101 commented on pull request "fuzz: wallet: add target for spkm migration":
(https://github.com/bitcoin/bitcoin/pull/29694#discussion_r1828422802)
If watchonly script count can be tracked, then this check should be able to be an exact check as `desc_spkms` should be `load_key_count` plus the number of spendable scripts.

💬 achow101 commented on pull request "wallet: fix unrelated parent conflict doesn't cause child tx to be marked as conflict":
(https://github.com/bitcoin/bitcoin/pull/29680#discussion_r1828448683)
In 7eba56accbd1b4ce3c09656c8d69b5aa437a706f "Handle double-spending of unrelated parents to wallet txs"

The replacement could still be sending to us, and in that case, it isn't unrelated.

💬 achow101 commented on pull request "wallet: fix unrelated parent conflict doesn't cause child tx to be marked as conflict":
(https://github.com/bitcoin/bitcoin/pull/29680#discussion_r1828472777)
In 7eba56accbd1b4ce3c09656c8d69b5aa437a706f "Handle double-spending of unrelated parents to wallet txs"

nit: whitespace.

Also, I think it would be better to clarify that the key is the txid of the replacing transaction which may be unrelated to the wallet, and the value is the replaced transaction which is related to this wallet.

💬 achow101 commented on pull request "wallet: fix unrelated parent conflict doesn't cause child tx to be marked as conflict":
(https://github.com/bitcoin/bitcoin/pull/29680#discussion_r1828455481)
In 7eba56accbd1b4ce3c09656c8d69b5aa437a706f "Handle double-spending of unrelated parents to wallet txs"

The extra scoping is not necessary, just name `it` something else.

🤔 ryanofsky reviewed a pull request: "tinyformat: Add compile-time checking for literal format strings"
(https://github.com/bitcoin/bitcoin/pull/31174#pullrequestreview-2414174938)
Updated e53829d3952c6ed275507a66e77636aad67d106b -> ecc5cb9a89c6b001df839675b23d8fc1f7ac69ba ([`pr/tcheck.3`](https://github.com/ryanofsky/bitcoin/commits/pr/tcheck.3) -> [`pr/tcheck.4`](https://github.com/ryanofsky/bitcoin/commits/pr/tcheck.4), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/tcheck.3..pr/tcheck.4)) with review suggestions.

re: https://github.com/bitcoin/bitcoin/pull/31174#pullrequestreview-2405166236

> Could document non-parity like so (unless you prefer I do it
...

💬 ryanofsky commented on pull request "tinyformat: Add compile-time checking for literal format strings":
(https://github.com/bitcoin/bitcoin/pull/31174#discussion_r1828424828)
re: https://github.com/bitcoin/bitcoin/pull/31174#discussion_r1822780992

> Should this be removed?

I think it's useful to document the format of the specifier, and it's still true that the remainder of the specifier (length and type) is not checked. Happy to update this if there's a specific suggestion, but I think it's still helpful and accurate so would not want to remove it.

💬 ryanofsky commented on pull request "tinyformat: Add compile-time checking for literal format strings":
(https://github.com/bitcoin/bitcoin/pull/31174#discussion_r1828424763)
re: https://github.com/bitcoin/bitcoin/pull/31174#discussion_r1822782509

> (One could expect that at least one precision-digit was required after '.' but it is not in tinyformat so this behavior is consistent).

That's good to know, I was just trying to make the parsing as simple as possible, but this syntax does seem to be commonly accepted (it works in python too) and I added test cases for it following your other suggestion

💬 ryanofsky commented on pull request "tinyformat: Add compile-time checking for literal format strings":
(https://github.com/bitcoin/bitcoin/pull/31174#discussion_r1828424528)
re: https://github.com/bitcoin/bitcoin/pull/31174#discussion_r1823488811

> ```c++
> PassFmt<1>("%.f");
> ```

Nice suggestion, added two cases: `%5.f` and `%.f` below `%5.2f`

💬 ryanofsky commented on pull request "tinyformat: Add compile-time checking for literal format strings":
(https://github.com/bitcoin/bitcoin/pull/31174#discussion_r1828424659)
re: https://github.com/bitcoin/bitcoin/pull/31174#discussion_r1822308585

Thanks, updated

💬 ryanofsky commented on pull request "tinyformat: Add compile-time checking for literal format strings":
(https://github.com/bitcoin/bitcoin/pull/31174#discussion_r1828438077)
re: https://github.com/bitcoin/bitcoin/pull/31174#discussion_r1823481424

> Why not use `FormatStringCheck<sizeof...(Args)>` in `printf` and `printfln` directly below as well?

No reason, added now.

🤔 achow101 reviewed a pull request: "test: Add `leaf_version` parameter to `taproot_tree_helper()`"
(https://github.com/bitcoin/bitcoin/pull/29371#pullrequestreview-2414278216)
Concept ACK

Please cleanup your commit message, it contains message fragments from squashed commits.

💬 achow101 commented on pull request "test: Add `leaf_version` parameter to `taproot_tree_helper()`":
(https://github.com/bitcoin/bitcoin/pull/29371#discussion_r1828489955)
nit:

add a space after the comma.

💬 ismaelsadeeq commented on pull request "test: enable running independent functional test sub-tests":
(https://github.com/bitcoin/bitcoin/pull/30991#discussion_r1828498975)
Done, thanks for reviewing