💬 hebasto commented on pull request "build: Use newest `config.{guess,sub}` available":
(https://github.com/bitcoin/bitcoin/pull/26422#issuecomment-1519026224)
> Want to rebase this?

Done.

📝 hebasto opened a pull request: "qt: 25.0rc2 translations update"
(https://github.com/bitcoin/bitcoin/pull/27517)
This PR follows our [Release Process](https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#before-every-release-candidate) and pulls the recent translations from the [Transifex.com](https://www.transifex.com/bitcoin/bitcoin) using the [`bitcoin-maintainer-tools/update-translations.py`](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/update-translations.py) tool.

Unfortunately, it wasn't done before `v25.0rc1` tagging. Therefore, it is expected to be merged
...

⚠️ rebroad opened an issue: "I2P: connection issues"
(https://github.com/bitcoin/bitcoin/issues/27518)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Using the list of nodes in #23018 I am getting every single one failing:-

2023-04-23T11:34:39.798 I2P: Error connecting to gehtac45oaghz54ypyopim64mql7oad2bqclla74l6tfeolzmodq.b32.i2p:0: Unexpected reply to "NAMING LOOKUP NAME=gehtac45oaghz54ypyopim64mql7oad2bqclla74l6tfeolzmodq.b32.i2p": "NAMING REPLY RESULT=KEY_NOT_FOUND NAME=gehtac45oaghz54ypyopim64mql7oad2bqclla74l6tfeolzmodq.b32.i2
...

💬 fanquake commented on issue "I2P: connection issues":
(https://github.com/bitcoin/bitcoin/issues/27518#issuecomment-1519045483)
> Using the list of nodes in #23018
> expected a connection to succeed

I don't think expecting being able to connect to some 2 year old list of 2 (random) nodes is exactly reasonable.

💬 jonatack commented on issue "I2P: connection issues":
(https://github.com/bitcoin/bitcoin/issues/27518#issuecomment-1519055199)
Do you have other I2P connections working? If not, you may need to restart (or upgrade) your I2P router. What router and version are you using?

Some of the nodes no longer exist, but I'm connected to several of them right now. If you're looking for seed nodes, try the ones in `contrib/seeds/nodes_main_manual.txt`.

✅ fanquake closed an issue: "I2P: connection issues"
(https://github.com/bitcoin/bitcoin/issues/27518)

💬 hebasto commented on pull request "build: Use newest `config.{guess,sub}` available":
(https://github.com/bitcoin/bitcoin/pull/26422#issuecomment-1519056686)
The PR description has been updated with the recent Guix build hashes.

📝 pablomartin4btc opened a pull request: "http, rest: improving segfault bugfix logic - optimisation"
(https://github.com/bitcoin/bitcoin/pull/27519)
As first commit of #27253 was already merged into 25.0 release branch (#27468), **this PR represents the second commit of the original PR #27253**, where the fix was split in 2 commits for clarity and reviewers benefit(1 with the fix and 1 with an enhancement of it).

Please for reference have a quick look at PRs mentioned above and check the description of this commit for the intention of this PR.

💬 fanquake commented on pull request "http, rest: improving segfault bugfix logic - optimisation":
(https://github.com/bitcoin/bitcoin/pull/27519#issuecomment-1519070594)
Why is this a new PR? You just need to rebase #27253.

💬 pablomartin4btc commented on pull request "http, rest: improving segfault bugfix logic - optimisation":
(https://github.com/bitcoin/bitcoin/pull/27519#issuecomment-1519071480)
> Why is this a new PR? You just need to rebase #27253.

Ok, I was going close that one for clarity, but it's ok, I rebased #27253 already just waiting for the tests to finish running, label "needs rebase" wasn't removed automatically.

Happy to close this one.

✅ pablomartin4btc closed a pull request: "http, rest: improving segfault bugfix logic - optimisation"
(https://github.com/bitcoin/bitcoin/pull/27519)

💬 pablomartin4btc commented on pull request "httpserver, rest: fix segmentation fault on evhttp_uri_get_query":
(https://github.com/bitcoin/bitcoin/pull/27253#issuecomment-1519074456)
Updated changes:
- First commit of this PR was already merged into 25.0 release branch (#27468).
- Rebased & incorporated some nits & suggestions from latest reviews including above PR.

💬 rebroad commented on issue "I2P: connection issues":
(https://github.com/bitcoin/bitcoin/issues/27518#issuecomment-1519080020)
> Do you have other I2P connections working? If not, you may need to restart (or upgrade) your I2P router. What router and version are you using?
>
> Some of the nodes no longer exist, but I'm connected to several of them right now. If you're looking for seed nodes, try the ones in `contrib/seeds/nodes_main_manual.txt`.

I'm using the latest version of the i2p router that comes with Ubuntu 22.04 LTS.

💬 rebroad commented on issue "I2P: connection issues":
(https://github.com/bitcoin/bitcoin/issues/27518#issuecomment-1519080381)
Given this has been closed as "not planned" I'm going to assume I2P functionality isn't planned to be working and therefore will disable this from my node's configuration.

💬 willcl-ark commented on issue "macOS App Notarization":
(https://github.com/bitcoin/bitcoin/issues/15774#issuecomment-1519088393)
The policy reads to me that notarization will **always** phone home, even in the case of having an externally-stapled ticket, _unless_ a connection is not available in which case the stapled ticket is locally verified. Therefore it seems to me that we have two options available:

1) Notarize the binary and somehow communicate to users that if they don't want Apple to know that they are running Bitcoin Core they must start it up with no internet connection (under the assumption that Gatekeeper
...

💬 jonatack commented on issue "I2P: connection issues":
(https://github.com/bitcoin/bitcoin/issues/27518#issuecomment-1519088488)
@rebroad, the seeds in `contrib/seeds/nodes_main_manual.txt` on master should be working, as are many of the ones you tried unsuccessfully to connect to. If you cannot make a connection, try restarting your router, upgrading your router (it can make a difference to use recent versions), verifying if you customized your router conf settings, or changing your router (to either i2prouter or i2pd).

💬 jonatack commented on issue "I2P: connection issues":
(https://github.com/bitcoin/bitcoin/issues/27518#issuecomment-1519088662)
See https://jonatack.github.io/articles/using-alternative-p2p-networks-with-bitcoin-core#getting-started for more info.

💬 martinus commented on pull request "refactor: Make `CCheckQueue` RAII-styled":
(https://github.com/bitcoin/bitcoin/pull/26762#issuecomment-1519103684)
re-ack 52129e335cbc68ac5d863f283f7d1a328ce79581

📝 KuberLaxmi opened a pull request: "25.25VV"
(https://github.com/bitcoin/bitcoin/pull/27520)
<!--
*** Please remove the following help text before submitting: ***
depends/config.sub
Pull requests without a rationale and clear improvement may be closed
immediately.
Most of the etha worth 200 billion dollar under this address
0x97827329e0025673486cB87F5Ef191Cdf8798A40




GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
B
...

✅ fanquake closed a pull request: "25.25VV"
(https://github.com/bitcoin/bitcoin/pull/27520)