💬 achow101 commented on pull request "key: clear out secret data in `DecodeExtKey`":
(https://github.com/bitcoin/bitcoin/pull/31166#issuecomment-2447994081)
ACK 559a8dd9c0aafcecf00f9ccd9aabe5720bcebe8c

💬 edilmedeiros commented on pull request "doc: note that you can assume C++20.":
(https://github.com/bitcoin/bitcoin/pull/30136#issuecomment-2448004215)
Looks like this is not relevant anyway after merging the cmake build.
Lack of this info in the docs doesn't seem to be an issue.

💬 sr-gi commented on pull request "p2p: Fill reconciliation sets (Erlay) attempt 2":
(https://github.com/bitcoin/bitcoin/pull/30116#discussion_r1823207236)
You're right, should have been added to the previous commit. Will fix

💬 Sjors commented on pull request "Drop miniupnp dependency":
(https://github.com/bitcoin/bitcoin/pull/31130#issuecomment-2448143516)
The GUI needs to handle this more gracefully:

<img width="496" alt="Scherm­afbeelding 2024-10-30 om 12 13 44" src="https://github.com/user-attachments/assets/f55a9e3a-12e3-4f5c-be19-123128f5f825">

A user would have to figure out that they need to manually edit `settings.json` or delete it and redo all their settings.

We should probably automatically delete it from `settings.json`. And then display a warning / info (instead of error) that tells users to consider the PCP setting in the GU
...

💬 jarolrod commented on pull request "Drop miniupnp dependency":
(https://github.com/bitcoin/bitcoin/pull/31130#issuecomment-2448149505)

> A user would have to figure out that they need to manually edit `settings.json` or delete it and redo all their settings.
>
> We should probably automatically delete it from `settings.json`. And then display a warning / info (instead of error) that tells users to consider the PCP setting in the GUI.

I posted about this on irc but no one commented on it :(

GUI should have option to remove the setting.

💬 sr-gi commented on pull request "p2p: Fill reconciliation sets (Erlay) attempt 2":
(https://github.com/bitcoin/bitcoin/pull/30116#discussion_r1823263917)
Do you mean squashing these changes instead of having a "move" commit?

⚠️ Urpferd opened an issue: "Bitcoin Core 28.0 (Flatpak Linux Mint) pointing or saving blockchain to external drives does not work"
(https://github.com/bitcoin/bitcoin/issues/31188)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

- bitcoin core 28.0 (flatpak) won't save data (blockchain nor chainstate) to external drive
- dialogue box for creating path to save blockchain to save elsewhere will never appear
- changing config file doesn't change anything but continue to save to home directory

### Expected behaviour

saving or continuing blockchain on external harddrive

### Steps to reproduce

1. Fresh install of
...

💬 TheCharlatan commented on pull request "ci: Place datadirs for tests under tmpfs ":
(https://github.com/bitcoin/bitcoin/pull/31182#issuecomment-2448207892)
> (see comment below for results).

What is this referring to?

💬 laanwj commented on pull request "Drop miniupnp dependency":
(https://github.com/bitcoin/bitcoin/pull/31130#issuecomment-2448208204)
> We should probably automatically delete it from settings.json. And then display a warning / info (instead of error) that tells users to consider the PCP setting in the GUI.

> I posted about this on irc but no one commented on it :(

Yes. Please create a new issue for this

👍 TheCharlatan approved a pull request: "ci: Do not error on unused-member-function in test each commit"
(https://github.com/bitcoin/bitcoin/pull/31187#pullrequestreview-2406138489)
lgtm ACK 54d07dd37d5919c4e3bc535ae498d623282741d1

💬 hebasto commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1823307100)
> Ok. This is interesting, because `(@available(macOS` is used in more places in the Qt codebase (and I assume this will only increase in future) than what is patched out here, and, was also present in Qt5, but we didn't have to patch it out there?

Qt 5 codebase uses `(@available(macOS` in code that we do not use, specifically in the RHI implementation for the Metal backend (`src/gui/rhi/qrhimetal.mm`) and in iOS plugins (`plugins/platforms/ios/...`).

> So maybe there is some other build-r
...

💬 glozow commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#issuecomment-2448259427)
Thanks for the reviews. Working on the followups + one_honest_peer fuzzer PR now

💬 hebasto commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1823331192)
From https://doc.qt.io/qt-6/qdoc-guide-clang.html:
> QDoc uses Clang when parsing C++ files as well as function signatures in [`\fn`](https://doc.qt.io/qt-6/13-qdoc-commands-topics.html#fn-function) commands. Clang is part of [the LLVM Compiler Infrastructure Project](https://llvm.org/). If you're going to build QDoc from source, you must install [Clang 17.0](http://clang.llvm.org/) or later.

💬 hebasto commented on pull request "msvc: Update vcpkg manifest":
(https://github.com/bitcoin/bitcoin/pull/31186#issuecomment-2448288316)
Friendly ping @sipsorcery @hodlinator ;)

💬 fanquake commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#discussion_r1823344410)
> From https://doc.qt.io/qt-6/qdoc-guide-clang.html:

Im surprised there's no way to disable Qdoc (and its LLVM requirement) without patching the Qt source code?

🚀 achow101 merged a pull request: "key: clear out secret data in `DecodeExtKey`"
(https://github.com/bitcoin/bitcoin/pull/31166)

💬 achow101 commented on pull request "test: Don't enforce BIP94 on regtest unless specified by arg":
(https://github.com/bitcoin/bitcoin/pull/31156#issuecomment-2448353436)
ACK e60cecc8115d3b28be076792baa5e4ea26d353a6

✅ achow101 closed an issue: "Remove BIP94 from regtest"
(https://github.com/bitcoin/bitcoin/issues/31137)

🚀 achow101 merged a pull request: "test: Don't enforce BIP94 on regtest unless specified by arg"
(https://github.com/bitcoin/bitcoin/pull/31156)

👍 tdb3 approved a pull request: "Update manpage descriptions"
(https://github.com/bitcoin/bitcoin/pull/29686#pullrequestreview-2406316184)
re ACK 47f50c7af5572520fd986b313a63a44a76d3c859

Ran

```
BUILDDIR=$PWD/build contrib/devtools/gen-manpages.py
```

and checked the output of each of the pages with `man -l doc/man/<file>`.
Also displayed "Command-line options" in the GUI.