💬 jonatack commented on pull request "cli: rework -addrinfo cli to use addresses which aren’t filtered for quality/recency":
(https://github.com/bitcoin/bitcoin/pull/26988#discussion_r1173977053)
Please don't break user space. Again suggest https://github.com/bitcoin/bitcoin/pull/26988#discussion_r1147473618.

💬 jonatack commented on pull request "rpc: Add test-only RPC getaddrmaninfo for new/tried table address count":
(https://github.com/bitcoin/bitcoin/pull/27511#issuecomment-1518103852)
This PR is based on master from two months age. You may need to rebase it to current master for the CI to be green.

💬 jonatack commented on pull request "rpc: Add test-only RPC getaddrmaninfo for new/tried table address count":
(https://github.com/bitcoin/bitcoin/pull/27511#issuecomment-1518117272)
Tested Concept ACK. It might be good to have the breakdown of pre/post `IsTerrible` (RPC getnodeaddresses and CLI -addrinfo return post) -- see the large differences between them.

```
jon|(54a4f196190...):~/bitcoin/bitcoin$ ./src/bitcoin-cli -rpcwait getaddrmaninfo
{
"ipv4": {
"new": 29414,
"tried": 2043,
"total": 31457
},
"ipv6": {
"new": 6909,
"tried": 544,
"total": 7453
},
"onion": {
"new": 11499,
"tried": 5164,
"total": 16663

...

💬 dongcarl commented on issue "user config: Support XDG Base Directory Specification or `$HOME/.{config,local}/`":
(https://github.com/bitcoin/bitcoin/issues/27512#issuecomment-1518117482)
True, will post what I wrote there and close.

✅ dongcarl closed an issue: "user config: Support XDG Base Directory Specification or `$HOME/.{config,local}/`"
(https://github.com/bitcoin/bitcoin/issues/27512)

💬 dongcarl commented on issue "Comply with the XDG Base Directory Specification":
(https://github.com/bitcoin/bitcoin/issues/16733#issuecomment-1518118024)
Was thinking about this myself, here's an example of what we could do for the config file:

1. Check for config files in the following order (first hit is applied, warn if multiple found)
1. `-conf` command line parameter
1. `$datadir/bitcoin.conf`
1. `$XDG_CONFIG_HOME/.config/bitcoin/bitcoin.conf`
1. `$HOME/.config/bitcoin/bitcoin.conf`
1. `$HOME/.bitcoin/bitcoin/bitcoin.conf` (current non-XDG directory)

A question: should we use `$XDG_DATA_HOME` (`$HOME/.local/sha
...

💬 jonatack commented on pull request "cli: rework -addrinfo cli to use addresses which aren’t filtered for quality/recency":
(https://github.com/bitcoin/bitcoin/pull/26988#discussion_r1174004892)
(See https://github.com/bitcoin/bitcoin/pull/27511#issuecomment-1518117272 for a current example on mainnet of how different the data can be.)

💬 jonatack commented on pull request "rpc: Add test-only RPC getaddrmaninfo for new/tried table address count":
(https://github.com/bitcoin/bitcoin/pull/27511#discussion_r1174005736)
Maybe a final "totals" field with the totals for each?

💬 jonatack commented on pull request "net, refactor: extract Network and BIP155Network logic to node/network":
(https://github.com/bitcoin/bitcoin/pull/27385#issuecomment-1518138160)
Rebased!

💬 jonatack commented on pull request "Move IsDeprecatedRPCEnabled to rpc/util, rm redundant rpcEnableDeprecated":
(https://github.com/bitcoin/bitcoin/pull/27322#issuecomment-1518166453)
Rebased 😃

🚀 achow101 merged a pull request: "rpc: In `utxoupdatepsbt` also look for the tx in the txindex"
(https://github.com/bitcoin/bitcoin/pull/25939)

🤔 mzumsande reviewed a pull request: "test: prevent intermittent failures"
(https://github.com/bitcoin/bitcoin/pull/27506#pullrequestreview-1396226339)
Code review ACK 10a354f1740a5c1b913d0b6951e80fb5401ab43a - the fix is what I suggested [here](https://github.com/bitcoin/bitcoin/pull/27214#discussion_r1169169601) and should make these intermittent failures impossible.

💬 fanquake commented on pull request "ci: use LLVM/clang-16 in native_asan job":
(https://github.com/bitcoin/bitcoin/pull/27360#issuecomment-1518195345)
```bash
�[0;34m node0 2023-04-21T16:34:04.866961Z [http] [httpserver.cpp:308] [ThreadHTTP] [http] Exited http event loop �[0m
�[0;34m node0 2023-04-21T16:34:04.867449Z [shutoff] [httpserver.cpp:505] [StopHTTPServer] [http] Stopped HTTP server �[0m
�[0;34m node0 2023-04-21T16:34:04.868612Z [msghand] [logging.h:263] [error] ERROR: ProcessNewBlock: AcceptBlock FAILED (AcceptBlock: Failed to find position to write new block to disk) �[0m
�[0;34m node0 2023-04-21T16:34:04.869269Z [msghand] [util/
...

🚀 fanquake merged a pull request: "test: prevent intermittent failures"
(https://github.com/bitcoin/bitcoin/pull/27506)

💬 achow101 commented on pull request "util: improve FindByte() performance":
(https://github.com/bitcoin/bitcoin/pull/19690#issuecomment-1518201999)
ACK 0fe832c4a4b2049fdf967bca375468d5ac285563

👍 john-moffett approved a pull request: "util: improve FindByte() performance"
(https://github.com/bitcoin/bitcoin/pull/19690#pullrequestreview-1396277513)
ACK 0fe832c4a4b2049fdf967bca375468d5ac285563

💬 achow101 commented on pull request "blockstorage: do not flush block to disk if it is already there":
(https://github.com/bitcoin/bitcoin/pull/27039#discussion_r1174134793)
> The only way I could think of to do that is to read and checksum the file, and compare the checksums instead of the timestamps.

Isn't the point that the file contents aren't changing? So checksum wouldn't work because the files will be the same whether it's rewritten or not. The only things that can be different are the filesystem's metadata on the modification time.

💬 hebasto commented on pull request "build: use latest config.{guess,sub} in depends":
(https://github.com/bitcoin/bitcoin/pull/27508#issuecomment-1518321534)
My Guix builds:
```
fef9152d593aa1cb3243f37b8c069ef863f4e270962e17918cfa83e18c9eac3a guix-build-4a3f1db4ea5f/output/aarch64-linux-gnu/SHA256SUMS.part
3fa8236cea2ba1a08d0caf677de80f798f2594cb208f10e5dfe0a9a71de7978d guix-build-4a3f1db4ea5f/output/aarch64-linux-gnu/bitcoin-4a3f1db4ea5f-aarch64-linux-gnu-debug.tar.gz
36409f4fa6acfb577d6e6a43c2fda2d81f1fb6fb4e5d90cbaa65a2dbb26d1c23 guix-build-4a3f1db4ea5f/output/aarch64-linux-gnu/bitcoin-4a3f1db4ea5f-aarch64-linux-gnu.tar.gz
02a62c4cc2ecb63b
...

⚠️ inmortalbobz opened an issue: "I believe #10072 should help with bip9-softforks."
(https://github.com/bitcoin/bitcoin/issues/27514)
I believe #10072 should help with bip9-softforks.

_Originally posted by @jnewbery in https://github.com/bitcoin/bitcoin/issues/10052#issuecomment-289143384_

✅ fanquake closed an issue: "I believe #10072 should help with bip9-softforks."
(https://github.com/bitcoin/bitcoin/issues/27514)