💬 sipa commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1820886255)
You can mimic what we did for BIP61 in the same document (which just lists the history of when it was introduced, and when it was removed).

⚠️ fanquake opened an issue: "bench: `linearizeoptimallyexample11` benchmark now running 4x slow than previously"
(https://github.com/bitcoin/bitcoin/issues/31178)
According to https://corecheck.dev/benchmarks, the `linearizeoptimallyexample11` benchmark 4x'd it's execution time at some point in the last few days.

💬 Christewart commented on pull request "consensus: fix `OP_1NEGATE` handling in `CScriptOp`":
(https://github.com/bitcoin/bitcoin/pull/29589#issuecomment-2444403494)
> Hey @Christewart! Do you plan to update for cmake?

Done, i squashed everything into 1 commit as well.

👍 hebasto approved a pull request: "ci: Use clang-19 from apt.llvm.org"
(https://github.com/bitcoin/bitcoin/pull/30634#pullrequestreview-2402063455)
ACK fabe90c8242aa45a8b9925347ca6fc11d5852ffd, I have reviewed the code and it looks OK.

💬 sipa commented on issue "bench: `linearizeoptimallyexample11` benchmark now running 4x slow than previously":
(https://github.com/bitcoin/bitcoin/issues/31178#issuecomment-2444413270)
More like 2x (from 0.64 to 1.21)? Still bizarre, this code has not been touched the past month for as far as I can see?

💬 fanquake commented on issue "bench: `linearizeoptimallyexample11` benchmark now running 4x slow than previously":
(https://github.com/bitcoin/bitcoin/issues/31178#issuecomment-2444418197)
I was just looking at total execution time increasing from ~4.3s to ~16.3.

💬 sipa commented on issue "bench: `linearizeoptimallyexample11` benchmark now running 4x slow than previously":
(https://github.com/bitcoin/bitcoin/issues/31178#issuecomment-2444420462)
Oh nevermind, I was looking at the "outliers" panel, which doesn't give absolute time. Indeed, 4x.

🤔 jonatack reviewed a pull request: "rpc, cli: return "verificationprogress" of 1 when up to date"
(https://github.com/bitcoin/bitcoin/pull/31177#pullrequestreview-2402104620)
Concept ACK, some ideas to encourage review:

- make sure your proposal compiles in your local environment, with passing unit and functional tests, so updating all the callers of `GuessVerificationProgress`. This makes it easier for reviewers to build and test your code and see if any test coverage needs to be updated or possibly added. Some reviewers may also wait until your pull has a green CI as enough proof of work before reviewing it more closely.
- squash your commits

This [article](
...

💬 darosior commented on pull request "Cleanups to port mapping module post UPnP drop":
(https://github.com/bitcoin/bitcoin/pull/31157#discussion_r1820926787)
Ah, yeah, right, that was stupid. I'll stick to just renaming `use_pcp` to `enabled`.

💬 mzumsande commented on pull request "test: Don't enforce BIP94 on regtest unless specified by arg":
(https://github.com/bitcoin/bitcoin/pull/31156#discussion_r1820928668)
Just following the process described in https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#release-notes - a change to that process should be discussed in a separate issue / PR - whatever works best for the maintainers I guess, personally I don't care at all.

💬 hebasto commented on pull request "refactor: Clean up messy strformat and bilingual_str usages":
(https://github.com/bitcoin/bitcoin/pull/31072#issuecomment-2444460496)
Concept ACK.

💬 l0rinc commented on pull request "tinyformat: Add compile-time checking for literal format strings":
(https://github.com/bitcoin/bitcoin/pull/31174#discussion_r1820938133)
we still have unbounded increment without checking the end (I though we've fixed this already, maybe it got stuck in the comments...)

💬 mzumsande commented on pull request "test: Don't enforce BIP94 on regtest unless specified by arg":
(https://github.com/bitcoin/bitcoin/pull/31156#discussion_r1820940387)
By the way, the reason I added a release note is that there also was one in the [28.0 release notes](https://bitcoincore.org/en/releases/28.0/) about introducing this.

💬 l0rinc commented on pull request "test: cover base32/base58/base64 with symmetric roundtrip fuzz (and padding) tests":
(https://github.com/bitcoin/bitcoin/pull/30746#discussion_r1820941193)
[Done](https://github.com/bitcoin/bitcoin/compare/5bc0a8daab37a826a59ed83eb59aef4081f1fe19..6fd185c035c1cc4dd961cf14a2087e97fb069440), thanks

💬 rkrux commented on pull request "test: Don't enforce BIP94 on regtest unless specified by arg":
(https://github.com/bitcoin/bitcoin/pull/31156#discussion_r1820949739)
> Just following the process described in https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#release-notes - a change to that process should be discussed in a separate issue / PR - whatever works best for the maintainers I guess, personally I don't care at all.

Thanks for sharing, I didn't know there is a process already for this.

👍 laanwj approved a pull request: "key: clear out secret data in `DecodeExtKey`"
(https://github.com/bitcoin/bitcoin/pull/31166#pullrequestreview-2402172194)
Code review ACK 559a8dd9c0aafcecf00f9ccd9aabe5720bcebe8c

💬 hebasto commented on pull request "Improve parallel script validation error debug logging":
(https://github.com/bitcoin/bitcoin/pull/31112#issuecomment-2444512400)
Concept ACK.

💬 hebasto commented on pull request "Dialog for allowing the user to choose the change output when bumping a tx":
(https://github.com/bitcoin-core/gui/pull/700#issuecomment-2444551530)
`test_bitcoin-qt` fails in the CI: https://github.com/bitcoin-core/gui/actions/runs/11186485220.

💬 hodlinator commented on pull request "build: increase minimum supported Windows to 10.0":
(https://github.com/bitcoin/bitcoin/pull/31172#issuecomment-2444563081)
Using GUIX to produce binaries, I'm able to run the base commit of this PR (bitcoin-da10e0bab4a3-win64-setup-unsigned.exe), but unable to run the binaries installed from the current PR commit (bitcoin-7dd0ee89a092-win64-setup-unsigned.exe):
<img width="297" alt="Screenshot 2024-10-29 160928" src="https://github.com/user-attachments/assets/1d4d0731-898f-4925-8146-9030484b7245">

System:
Edition Windows 11 Home
Version 23H2
OS build 22631.4317

💬 l0rinc commented on pull request "refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests":
(https://github.com/bitcoin/bitcoin/pull/30906#discussion_r1821014127)
It seems this [was introduced in 2017](https://github.com/bitcoin/bitcoin/commit/50830796889ecaa458871f1db878c255dd2554cb#diff-f0ed73d62dae6ca28ebd3045e5fc0d5d02eaaacadb4c2a292985a3fbd7e1c77cR100), when the project was still on [C++11](https://github.com/bitcoin/bitcoin/blob/342b9bc3907edf8eae64440397a32833ed44fae4/configure.ac#L58), but `try_emplace` was only introduced in [C++17](https://en.cppreference.com/w/cpp/container/map/try_emplace).

When this was split out to [`EmplaceCoinInternalDA
...