💬 fanquake commented on pull request "Bump python minimum version to 3.8":
(https://github.com/bitcoin/bitcoin/pull/27483#issuecomment-1517638047)
Should also bump the lint DOckerfile to `python:3.8-buster`?
(https://github.com/bitcoin/bitcoin/pull/27483#issuecomment-1517638047)
Should also bump the lint DOckerfile to `python:3.8-buster`?
📝 fanquake opened a pull request: "build: use latest config.{guess,sub} in depends"
(https://github.com/bitcoin/bitcoin/pull/27508)
Been a few years since we last updated these.
Also related to https://github.com/bitcoin/bitcoin/pull/26422#issuecomment-1421178967.
(https://github.com/bitcoin/bitcoin/pull/27508)
Been a few years since we last updated these.
Also related to https://github.com/bitcoin/bitcoin/pull/26422#issuecomment-1421178967.
🚀 fanquake merged a pull request: "fuzz: re-enable prioritisetransaction & analyzepsbt RPC"
(https://github.com/bitcoin/bitcoin/pull/27464)
(https://github.com/bitcoin/bitcoin/pull/27464)
👋 fanquake's pull request is ready for review: "[23.x] Additional backports for 23.x"
(https://github.com/bitcoin/bitcoin/pull/27475)
(https://github.com/bitcoin/bitcoin/pull/27475)
💬 hebasto commented on pull request "build: use latest config.{guess,sub} in depends":
(https://github.com/bitcoin/bitcoin/pull/27508#issuecomment-1517649284)
Concept ACK.
(https://github.com/bitcoin/bitcoin/pull/27508#issuecomment-1517649284)
Concept ACK.
💬 fanquake commented on pull request "ci: use LLVM/clang-16 in native_asan job":
(https://github.com/bitcoin/bitcoin/pull/27360#discussion_r1173636442)
@fkorotkov can you offer any insight here? Should we be able to use non-LTS Ubuntu images?
(https://github.com/bitcoin/bitcoin/pull/27360#discussion_r1173636442)
@fkorotkov can you offer any insight here? Should we be able to use non-LTS Ubuntu images?
💬 pinheadmz commented on pull request "net: use interruptible async getaddrinfo wrapper from libevent for DNS":
(https://github.com/bitcoin/bitcoin/pull/27505#issuecomment-1517682872)
@dergoegge I think the CI failures are memory leaks from my code, I'm going to fix that. But I hear your point about the arcane library. Any suggestions?
(https://github.com/bitcoin/bitcoin/pull/27505#issuecomment-1517682872)
@dergoegge I think the CI failures are memory leaks from my code, I'm going to fix that. But I hear your point about the arcane library. Any suggestions?
💬 hebasto commented on pull request "refactor: Make `CCheckQueue` RAII-styled":
(https://github.com/bitcoin/bitcoin/pull/26762#issuecomment-1517728829)
Rebased d462e3da7fc6be75269e88928fd80fc98c405474 -> 52129e335cbc68ac5d863f283f7d1a328ce79581 ([pr26762.07](https://github.com/hebasto/bitcoin/commits/pr26762.07) -> [pr26762.08](https://github.com/hebasto/bitcoin/commits/pr26762.08)) due to the conflict with #27419.
(https://github.com/bitcoin/bitcoin/pull/26762#issuecomment-1517728829)
Rebased d462e3da7fc6be75269e88928fd80fc98c405474 -> 52129e335cbc68ac5d863f283f7d1a328ce79581 ([pr26762.07](https://github.com/hebasto/bitcoin/commits/pr26762.07) -> [pr26762.08](https://github.com/hebasto/bitcoin/commits/pr26762.08)) due to the conflict with #27419.
💬 MarcoFalke commented on pull request "Bump python minimum version to 3.8":
(https://github.com/bitcoin/bitcoin/pull/27483#issuecomment-1517739626)
> Should also bump the lint Dockerfile to python:3.8-buster?
buster is EOL and unmaintained, which is one of the reasons I created this pull, as can be seen in the pull request description. I don't really understand why the lint Dockerfile isn't simply using the exact same distro and setup like the lint CI. Using something else is just going to make it less reproducible and harder to maintain. Though, those changes should probably be made in a separate follow-up pull.
(https://github.com/bitcoin/bitcoin/pull/27483#issuecomment-1517739626)
> Should also bump the lint Dockerfile to python:3.8-buster?
buster is EOL and unmaintained, which is one of the reasons I created this pull, as can be seen in the pull request description. I don't really understand why the lint Dockerfile isn't simply using the exact same distro and setup like the lint CI. Using something else is just going to make it less reproducible and harder to maintain. Though, those changes should probably be made in a separate follow-up pull.
💬 fanquake commented on pull request "Bump python minimum version to 3.8":
(https://github.com/bitcoin/bitcoin/pull/27483#issuecomment-1517765508)
> buster is EOL and unmaintained,
In this context, I don't think that makes any difference, as the container is just an interpreter, so as long as it's downloadable, it should work (no installing packages etc).
> I don't really understand why the lint Dockerfile isn't simply using the exact same distro and setup like the lint CI.
No idea. Maybe ask @jamesob.
I was mostly pointing it out because it seemed odd to not just bump it as well. Not a blocker if someone else is going to follo
...
(https://github.com/bitcoin/bitcoin/pull/27483#issuecomment-1517765508)
> buster is EOL and unmaintained,
In this context, I don't think that makes any difference, as the container is just an interpreter, so as long as it's downloadable, it should work (no installing packages etc).
> I don't really understand why the lint Dockerfile isn't simply using the exact same distro and setup like the lint CI.
No idea. Maybe ask @jamesob.
I was mostly pointing it out because it seemed odd to not just bump it as well. Not a blocker if someone else is going to follo
...
💬 fanquake commented on pull request "build: use latest config.{guess,sub} in depends":
(https://github.com/bitcoin/bitcoin/pull/27508#issuecomment-1517769106)
Guix Build:
```bash
fef9152d593aa1cb3243f37b8c069ef863f4e270962e17918cfa83e18c9eac3a guix-build-4a3f1db4ea5f/output/aarch64-linux-gnu/SHA256SUMS.part
3fa8236cea2ba1a08d0caf677de80f798f2594cb208f10e5dfe0a9a71de7978d guix-build-4a3f1db4ea5f/output/aarch64-linux-gnu/bitcoin-4a3f1db4ea5f-aarch64-linux-gnu-debug.tar.gz
36409f4fa6acfb577d6e6a43c2fda2d81f1fb6fb4e5d90cbaa65a2dbb26d1c23 guix-build-4a3f1db4ea5f/output/aarch64-linux-gnu/bitcoin-4a3f1db4ea5f-aarch64-linux-gnu.tar.gz
02a62c4cc2ecb63b
...
(https://github.com/bitcoin/bitcoin/pull/27508#issuecomment-1517769106)
Guix Build:
```bash
fef9152d593aa1cb3243f37b8c069ef863f4e270962e17918cfa83e18c9eac3a guix-build-4a3f1db4ea5f/output/aarch64-linux-gnu/SHA256SUMS.part
3fa8236cea2ba1a08d0caf677de80f798f2594cb208f10e5dfe0a9a71de7978d guix-build-4a3f1db4ea5f/output/aarch64-linux-gnu/bitcoin-4a3f1db4ea5f-aarch64-linux-gnu-debug.tar.gz
36409f4fa6acfb577d6e6a43c2fda2d81f1fb6fb4e5d90cbaa65a2dbb26d1c23 guix-build-4a3f1db4ea5f/output/aarch64-linux-gnu/bitcoin-4a3f1db4ea5f-aarch64-linux-gnu.tar.gz
02a62c4cc2ecb63b
...
👍 fanquake approved a pull request: "Bump python minimum version to 3.8"
(https://github.com/bitcoin/bitcoin/pull/27483#pullrequestreview-1395687975)
ACK fac395e5eb2cd3210ba6345f777a586a9bec84e3
(https://github.com/bitcoin/bitcoin/pull/27483#pullrequestreview-1395687975)
ACK fac395e5eb2cd3210ba6345f777a586a9bec84e3
💬 MarcoFalke commented on pull request "Bump python minimum version to 3.8":
(https://github.com/bitcoin/bitcoin/pull/27483#issuecomment-1517774746)
> it should work (no apt installing packages etc).
It calls `RUN /install.sh`, which installs packages
(https://github.com/bitcoin/bitcoin/pull/27483#issuecomment-1517774746)
> it should work (no apt installing packages etc).
It calls `RUN /install.sh`, which installs packages
💬 fanquake commented on pull request "Bump python minimum version to 3.8":
(https://github.com/bitcoin/bitcoin/pull/27483#issuecomment-1517780543)
> It calls RUN /install.sh, which installs packages
Right. Although it doesn't actually need to do that, as all the packages we needs are already available in the base python3.8-buster image.
(https://github.com/bitcoin/bitcoin/pull/27483#issuecomment-1517780543)
> It calls RUN /install.sh, which installs packages
Right. Although it doesn't actually need to do that, as all the packages we needs are already available in the base python3.8-buster image.
💬 dergoegge commented on pull request "net: use interruptible async getaddrinfo wrapper from libevent for DNS":
(https://github.com/bitcoin/bitcoin/pull/27505#issuecomment-1517787932)
> Any suggestions?
The issue seems somewhat stale so maybe no need to fix? Judging by your last comment, you were also not able to reproduce? (https://github.com/bitcoin/bitcoin/issues/16778#issuecomment-1458423187)
(https://github.com/bitcoin/bitcoin/pull/27505#issuecomment-1517787932)
> Any suggestions?
The issue seems somewhat stale so maybe no need to fix? Judging by your last comment, you were also not able to reproduce? (https://github.com/bitcoin/bitcoin/issues/16778#issuecomment-1458423187)
💬 pinheadmz commented on pull request "net: use interruptible async getaddrinfo wrapper from libevent for DNS":
(https://github.com/bitcoin/bitcoin/pull/27505#issuecomment-1517793681)
I was able to somewhat reproduce -- by sending all DNS requests on my machine to a blackhole resolver, I observed a 30 second pause during shutdown. But I think that 30 seconds may be platform-specific, or whatever the local `getaddrinfo()` implementation is.
(https://github.com/bitcoin/bitcoin/pull/27505#issuecomment-1517793681)
I was able to somewhat reproduce -- by sending all DNS requests on my machine to a blackhole resolver, I observed a 30 second pause during shutdown. But I think that 30 seconds may be platform-specific, or whatever the local `getaddrinfo()` implementation is.
💬 pinheadmz commented on issue "Compiling a bitcoin core version that accepts transactions over 100vkb":
(https://github.com/bitcoin/bitcoin/issues/27490#issuecomment-1517797906)
If you're modifying the source code, you won't get much help with build errors here. I think we should close this issue.
(https://github.com/bitcoin/bitcoin/issues/27490#issuecomment-1517797906)
If you're modifying the source code, you won't get much help with build errors here. I think we should close this issue.
🚀 fanquake merged a pull request: "depends: reuse _config_opts for CMake options"
(https://github.com/bitcoin/bitcoin/pull/27496)
(https://github.com/bitcoin/bitcoin/pull/27496)
💬 dergoegge commented on pull request "net: use interruptible async getaddrinfo wrapper from libevent for DNS":
(https://github.com/bitcoin/bitcoin/pull/27505#discussion_r1173774847)
Wouldn't this also wait indefinitely for `getaddrinfo` to finish before the thread can join?
(https://github.com/bitcoin/bitcoin/pull/27505#discussion_r1173774847)
Wouldn't this also wait indefinitely for `getaddrinfo` to finish before the thread can join?
📝 vasild opened a pull request: "Relay own transactions only via short-lived Tor or I2P connections"
(https://github.com/bitcoin/bitcoin/pull/27509)
_This is an early draft to get some feedback on the design. It compiles, but some obvious things are missing._
Introduce a new connection type for relaying sensitive data (our own transactions) with the following properties:
* started whenever there are local unbroadcast transactions to be sent
* only opened to Tor or I2P peers
* opened regardless of max connections limits
* after handshake is completed one local transaction is pushed to the peer and the connection is closed
* ignore all
...
(https://github.com/bitcoin/bitcoin/pull/27509)
_This is an early draft to get some feedback on the design. It compiles, but some obvious things are missing._
Introduce a new connection type for relaying sensitive data (our own transactions) with the following properties:
* started whenever there are local unbroadcast transactions to be sent
* only opened to Tor or I2P peers
* opened regardless of max connections limits
* after handshake is completed one local transaction is pushed to the peer and the connection is closed
* ignore all
...