💬 murchandamus commented on pull request "miner: Reorg Testnet4 minimum difficulty blocks":
(https://github.com/bitcoin/bitcoin/pull/31117#issuecomment-2427321347)
In addition to the immediate minimum difficulty blocks after each full difficulty block, someone appears to have started bloating the UTXO set. They have created about 1.5 M UTXOs today so far: https://mempool.space/testnet4/address/tb1q8z0jcrdmfuhyafz06ukhyvfnx4vhcn5azv6jkr
(https://github.com/bitcoin/bitcoin/pull/31117#issuecomment-2427321347)
In addition to the immediate minimum difficulty blocks after each full difficulty block, someone appears to have started bloating the UTXO set. They have created about 1.5 M UTXOs today so far: https://mempool.space/testnet4/address/tb1q8z0jcrdmfuhyafz06ukhyvfnx4vhcn5azv6jkr
💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1809231705)
@sdaftuar this should do it if you think something like this is reasonable: https://github.com/instagibbs/bitcoin/commit/6007146613fe663f0af30c24c47a19792f8e691d
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1809231705)
@sdaftuar this should do it if you think something like this is reasonable: https://github.com/instagibbs/bitcoin/commit/6007146613fe663f0af30c24c47a19792f8e691d
💬 murchandamus commented on issue "Improve description of the `filename` parameter of `loadwallet` RPC":
(https://github.com/bitcoin/bitcoin/issues/30269#issuecomment-2427364404)
@paulmaleauxney: It looks like #30302 is getting pretty close to being merged
(https://github.com/bitcoin/bitcoin/issues/30269#issuecomment-2427364404)
@paulmaleauxney: It looks like #30302 is getting pretty close to being merged
💬 murchandamus commented on pull request "Fee Estimation via Fee rate Forecasters":
(https://github.com/bitcoin/bitcoin/pull/30157#issuecomment-2427370927)
Concept ACK! Thank you for working on this.
(https://github.com/bitcoin/bitcoin/pull/30157#issuecomment-2427370927)
Concept ACK! Thank you for working on this.
🤔 murchandamus reviewed a pull request: "Remove mempoolfullrbf"
(https://github.com/bitcoin/bitcoin/pull/30592#pullrequestreview-2382949737)
Concept ACK
(https://github.com/bitcoin/bitcoin/pull/30592#pullrequestreview-2382949737)
Concept ACK
💬 murchandamus commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1809262175)
This comment is outdated
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1809262175)
This comment is outdated
👍 laanwj approved a pull request: "wallet: Cleanup accidental encryption keys in watchonly wallets"
(https://github.com/bitcoin/bitcoin/pull/28724#pullrequestreview-2382986480)
Code review re-ACK 69e95c2b4f99eb4c2af6b2b6cc6a66abfea753df
(https://github.com/bitcoin/bitcoin/pull/28724#pullrequestreview-2382986480)
Code review re-ACK 69e95c2b4f99eb4c2af6b2b6cc6a66abfea753df
🤔 murchandamus reviewed a pull request: "Ephemeral Dust"
(https://github.com/bitcoin/bitcoin/pull/30239#pullrequestreview-2382979168)
Concept ACK
(https://github.com/bitcoin/bitcoin/pull/30239#pullrequestreview-2382979168)
Concept ACK
💬 murchandamus commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1809271898)
It seems to me that this would apply to any transaction with a dust output rather than just one that fulfills the criteria of "ephemeral dust".
```suggestion
throw JSONRPCError(RPC_INVALID_PARAMETER, "Priority is not supported for transactions with dust outputs.");
```
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1809271898)
It seems to me that this would apply to any transaction with a dust output rather than just one that fulfills the criteria of "ephemeral dust".
```suggestion
throw JSONRPCError(RPC_INVALID_PARAMETER, "Priority is not supported for transactions with dust outputs.");
```
💬 murchandamus commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1809279480)
```suggestion
dust output in a transaction, provided the transaction
```
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1809279480)
```suggestion
dust output in a transaction, provided the transaction
```
👍 laanwj approved a pull request: "rpc: net: follow-ups for #30062"
(https://github.com/bitcoin/bitcoin/pull/30183#pullrequestreview-2383023507)
thanks for updating !
re-ACK a16917fb5981d1465ffd4c036586f8729e683b73
(https://github.com/bitcoin/bitcoin/pull/30183#pullrequestreview-2383023507)
thanks for updating !
re-ACK a16917fb5981d1465ffd4c036586f8729e683b73
💬 hasti0073 commented on pull request "Add Signet and testnet4 launch shortcuts for Windows":
(https://github.com/bitcoin/bitcoin/pull/26334#issuecomment-2427467282)
1JjXPKN1yyPMxi2WvJv4BHVaJqqgzxSRGg
(https://github.com/bitcoin/bitcoin/pull/26334#issuecomment-2427467282)
1JjXPKN1yyPMxi2WvJv4BHVaJqqgzxSRGg
💬 instagibbs commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1809368084)
will fix if I touchup
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1809368084)
will fix if I touchup
💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1809451766)
done
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1809451766)
done
💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1809451807)
done
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1809451807)
done
💬 sdaftuar commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1809453084)
Hm, I I think that approach uses an extra 24 bytes per mempool entry, which strikes me as a bit heavy for what we need. Let's see if this is fast enough as-is and if so, call it a day.
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1809453084)
Hm, I I think that approach uses an extra 24 bytes per mempool entry, which strikes me as a bit heavy for what we need. Let's see if this is fast enough as-is and if so, call it a day.
💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1809480956)
Alternative is to store a bool, and use that to filter 99.9% of transactions that won't have dust, and then eat the O(num_outputs) cost to find the dust.
With 1000 inputs/outputs and a small number of dust outputs, I get:
```
| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 60,600.53 | 16,501.51 | 0.7% | 0.01 | `MempoolCheckEphemeralSpends`
```
When
...
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1809480956)
Alternative is to store a bool, and use that to filter 99.9% of transactions that won't have dust, and then eat the O(num_outputs) cost to find the dust.
With 1000 inputs/outputs and a small number of dust outputs, I get:
```
| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 60,600.53 | 16,501.51 | 0.7% | 0.01 | `MempoolCheckEphemeralSpends`
```
When
...
💬 hodlinator commented on pull request "Windows bitcoind stall debugging [NOMERGE, DRAFT]":
(https://github.com/bitcoin/bitcoin/pull/30956#issuecomment-2427711698)
Debugged a 3rd dump:
https://github.com/hodlinator/bitcoin/actions/runs/11414623090
Same stacks in threads and local function state in `RandAddSeedPerfmon()` was similar/same as observed in 2 previous dump files - `nSize = 843750` (250000 × (1.5^3)).
### Main thread
```
ntdll.dll!NtReleaseSemaphore() Unknown
KERNELBASE.dll!ReleaseSemaphore() Unknown
WmiApRpl.dll!WmiReverseGuard::LeaveRead(long) Unknown
WmiApRpl.dll!WmiReverseMemoryExt<class WmiReverseGuard>::Read(void *,uns
...
(https://github.com/bitcoin/bitcoin/pull/30956#issuecomment-2427711698)
Debugged a 3rd dump:
https://github.com/hodlinator/bitcoin/actions/runs/11414623090
Same stacks in threads and local function state in `RandAddSeedPerfmon()` was similar/same as observed in 2 previous dump files - `nSize = 843750` (250000 × (1.5^3)).
### Main thread
```
ntdll.dll!NtReleaseSemaphore() Unknown
KERNELBASE.dll!ReleaseSemaphore() Unknown
WmiApRpl.dll!WmiReverseGuard::LeaveRead(long) Unknown
WmiApRpl.dll!WmiReverseMemoryExt<class WmiReverseGuard>::Read(void *,uns
...
📝 COPILOT-WEB-ui opened a pull request: "Update README.md to Format Header Correctly"
(https://github.com/bitcoin/bitcoin/pull/31126)
This pull request updates the `README.md` file to improve its readability by formatting the first line as a markdown header. The change involves adding a hashtag at the beginning of the line, transforming "Bitcoin Core integration/staging tree" into "# Bitcoin Core integration/staging tree". This modification enhances the document structure, making it easier for users to identify the title at a glance.
No changes have been made to functions, global data structures, or external interfaces. Th
...
(https://github.com/bitcoin/bitcoin/pull/31126)
This pull request updates the `README.md` file to improve its readability by formatting the first line as a markdown header. The change involves adding a hashtag at the beginning of the line, transforming "Bitcoin Core integration/staging tree" into "# Bitcoin Core integration/staging tree". This modification enhances the document structure, making it easier for users to identify the title at a glance.
No changes have been made to functions, global data structures, or external interfaces. Th
...
✅ fanquake closed a pull request: "Update README.md to Format Header Correctly"
(https://github.com/bitcoin/bitcoin/pull/31126)
(https://github.com/bitcoin/bitcoin/pull/31126)