💬 rkrux commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1808131075)
Nice to see these checks going away!

👍 rkrux approved a pull request: "Package validation: accept packages of size 1"
(https://github.com/bitcoin/bitcoin/pull/31096#pullrequestreview-2381095095)
tACK https://github.com/bitcoin/bitcoin/commit/72872c7073e99da0828e788b25520dcecf721c1b
Would be great to have the docs updated as well.

Make and functional tests successful.

In regtest I manually created a PSBT, processed it and submitted a single transaction package with successful response.

```
➜ bitcoin git:(2024-10-submitpackage-singleton) ✗ bitcoincli submitpackage "[\"020000000001018e61beaa1f85daba48a46e6bef4e58d12f32768d347185cb077c988cc5af976b0000000000fdffffff02e60f10240100
...

💬 rkrux commented on pull request "Package validation: accept packages of size 1":
(https://github.com/bitcoin/bitcoin/pull/31096#discussion_r1808203711)
Worth updating RPC doc as well here? Informing that only child is also allowed.

https://github.com/bitcoin/bitcoin/blob/master/src/rpc/mempool.cpp#L926

👍 rkrux approved a pull request: "doc: replace `-?` with `-h` for bench_bitcoin help"
(https://github.com/bitcoin/bitcoin/pull/31118#pullrequestreview-2381221879)
tACK https://github.com/bitcoin/bitcoin/commit/f0130ab1a1e65583637b6a362b879ea3253e7bb7

I compiled `bench_bitcoin`, and ran the help command on Mac OS. `-h` works, `-?` doesn't.

Wondering why is `-h` a hidden argument. Do you think it's worth making it non-hidden with its own message just like `-?`?
https://github.com/bitcoin/bitcoin/blob/master/src/common/args.cpp#L692

💬 laanwj commented on pull request "doc: replace `-?` with `-h` for bench_bitcoin help":
(https://github.com/bitcoin/bitcoin/pull/31118#issuecomment-2425956873)
> Wondering why is -h a hidden argument. Do you think it's worth making it non-hidden with its own message just like -??

There's no reason to list both seperately. That would clutter the list. `-?` is the weird duck out in that it lists the short-name option as primary instead of the long one (`-help`). Might add the alternatives to the help message say,

```
-help
Print this help message and exit (also -h or -?)
```

👍 BrandonOdiwuor approved a pull request: "doc: replace `-?` with `-h` for bench_bitcoin help"
(https://github.com/bitcoin/bitcoin/pull/31118#pullrequestreview-2381328047)
ACK f0130ab1a1e65583637b6a362b879ea3253e7bb7, great catch

💬 fanquake commented on pull request "Windows bitcoind stall debugging [NOMERGE, DRAFT]":
(https://github.com/bitcoin/bitcoin/pull/30956#issuecomment-2426002132)
> The call to RegQueryValueExA in RandAddSeedPerfmon:

I think you can open a PR to just remove this entirely.

💬 cdecker commented on pull request "chainparams: Re-add seed.bitcoinstats.com":
(https://github.com/bitcoin/bitcoin/pull/31086#issuecomment-2426003595)
From what I can tell it is working as expected:

```
dig x9.seed.bitcoinstats.com. @1.1.1.1

; <<>> DiG 9.18.28-0ubuntu0.22.04.1-Ubuntu <<>> x9.seed.bitcoinstats.com. @1.1.1.1
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 28948
;; flags: qr rd ra; QUERY: 1, ANSWER: 24, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 1232
;; QUESTION SECTION:
;x9.seed.bitcoinstats.com. IN A

;; ANSWER SECTIO
...

💬 rkrux commented on pull request "doc: replace `-?` with `-h` for bench_bitcoin help":
(https://github.com/bitcoin/bitcoin/pull/31118#issuecomment-2426028146)
> > Wondering why is -h a hidden argument. Do you think it's worth making it non-hidden with its own message just like -??
>
> There's no reason to list both seperately. That would clutter the list. `-?` is the weird duck out in that it lists the short-name option as primary instead of the long one (`-help`). Might add the alternatives to the help message say,
>
> ```
> -help
> Print this help message and exit (also -h or -?)
> ```

@laanwj Yes, this^ seems better.

👍 fanquake approved a pull request: "Update libmultiprocess library"
(https://github.com/bitcoin/bitcoin/pull/31105#pullrequestreview-2381376853)
ACK 90b405516f7f3be522ced3e0c4d23b3892df0661

💬 sdaftuar commented on pull request "Add imbued v3 based on template-matching":
(https://github.com/bitcoin/bitcoin/pull/29427#issuecomment-2426055128)
I believe this PR is no longer relevant, so closing for now.

✅ sdaftuar closed a pull request: "Add imbued v3 based on template-matching"
(https://github.com/bitcoin/bitcoin/pull/29427)

💬 l0rinc commented on pull request "doc: replace `-?` with `-h` for bench_bitcoin help":
(https://github.com/bitcoin/bitcoin/pull/31118#issuecomment-2426061892)
I've pushed the default change in a separate commit, let me know if this is what you had in mind:
```bash
% build/src/bench/bench_bitcoin -h
[...]
-help
Print this help message and exit (also -h or -?)
```

💬 hodlinator commented on pull request "Windows bitcoind stall debugging [NOMERGE, DRAFT]":
(https://github.com/bitcoin/bitcoin/pull/30956#issuecomment-2426068240)
> I think you can open a PR to just remove this entirely.

On it. Will explore other possible fixes after publishing that PR.

💬 qk-santi commented on issue "estimateSmartFee error: "Insufficient data or no feerate found"":
(https://github.com/bitcoin/bitcoin/issues/31116#issuecomment-2426084727)
Hey @pinheadmz !

Thanks for answering

Since upgrading to v27 around April, we've been having estimation issues.

Just after upgrade to v27, we had incorrect estimations both on Testnet and Mainnet on all nodes.

On Mainnet, it estimates got stuck to ~300 sats for several days, while network was asking for ~50 sats.
We waited a bit to check if mempool had to refresh and get newer transactions to get the pulse of the network, just in case if it had any improper batch of txs that were sk
...

💬 laanwj commented on pull request "chainparams: Re-add seed.bitcoinstats.com":
(https://github.com/bitcoin/bitcoin/pull/31086#issuecomment-2426116973)
> From what I can tell it is working as expected:

Yes. When using `@1.1.1.1` it works. Without, i get the following. Apparently my ISP's DNS server is behaving funny.
```
; <<>> DiG 9.18.28-0ubuntu0.24.04.1-Ubuntu <<>> x9.seed.bitcoinstats.com.
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 30929
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 1, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 65494
;; QUESTION SE
...

🚀 fanquake merged a pull request: "lint: commit-script-check.sh: echo to stderr"
(https://github.com/bitcoin/bitcoin/pull/31063)

👍 TheCharlatan approved a pull request: "Update libmultiprocess library"
(https://github.com/bitcoin/bitcoin/pull/31105#pullrequestreview-2381512774)
ACK 90b405516f7f3be522ced3e0c4d23b3892df0661

🚀 fanquake merged a pull request: "Update libmultiprocess library"
(https://github.com/bitcoin/bitcoin/pull/31105)

💬 brunoerg commented on pull request "rpc: net: follow-ups for #30062":
(https://github.com/bitcoin/bitcoin/pull/30183#discussion_r1808467530)
I agree, but since we have some ACKs here, I can leave it for another PR or in case I need to touch it again.