💬 achow101 commented on pull request "Switch hardened derivation marker to h (in normalized descriptors and new wallets)":
(https://github.com/bitcoin/bitcoin/pull/26076#issuecomment-1516830236)
re-ACK bd13dc2f46ea10302a928fcf0f53b7aed77ad260

💬 achow101 commented on pull request "wallet: do not backdate locktime if it may lead to fingerprinting":
(https://github.com/bitcoin/bitcoin/pull/26902#discussion_r1173003117)
In e979f2ebc8a74474d2bdfee61fd64472e4c4b873 "wallet: do not backdate locktime if it may help wallet fingerprinting"

Each `coin` already has a `depth` member which will be 0 if it is an unconfirmed coin. We can use this instead of having to lookup the parent `CWalletTx`.

💬 achow101 commented on pull request "wallet: cache IsMine scriptPubKeys to improve performance of descriptor wallets":
(https://github.com/bitcoin/bitcoin/pull/26008#issuecomment-1516837867)
> I was looking into how to get rid of the callbacks and avoid duplicating the scriptpubkeys

I added the callback to also allow for other cases where we need to know that the scriptPubKey set has changed, such as with fast rescans with block filters.

💬 achow101 commented on pull request "contrib: add tool to convert compact-serialized UTXO set to SQLite database":
(https://github.com/bitcoin/bitcoin/pull/27432#issuecomment-1516857024)
> the resulting file has roughly 2x the size of the compact-serialized UTXO set (this is mostly due to encoding txids and scriptpubkeys as hex-strings rather than bytes)

What is the rationale for encoding as text rather than bytes? SQLite can store byte values as BLOBs.

👍 fanquake approved a pull request: "Bump to 25.99 and remove release note fragments"
(https://github.com/bitcoin/bitcoin/pull/27503#pullrequestreview-1394664513)
ACK 9c24826e7b58722d7b0ddb8f18f985ba6f17b106

🚀 fanquake merged a pull request: "Bump to 25.99 and remove release note fragments"
(https://github.com/bitcoin/bitcoin/pull/27503)

💬 fanquake commented on issue "Release schedule for 25.0":
(https://github.com/bitcoin/bitcoin/issues/26549#issuecomment-1516866543)
25.x has now been branched off: https://github.com/bitcoin/bitcoin/tree/25.x.

🚀 achow101 merged a pull request: "addrman: Enable selecting addresses by network"
(https://github.com/bitcoin/bitcoin/pull/27214)

💬 achow101 commented on pull request "Add pool based memory resource":
(https://github.com/bitcoin/bitcoin/pull/25325#issuecomment-1516886734)
re-ACK 9f947fc3d4b779f017332135323b34e8f216f613

🚀 achow101 merged a pull request: "Add pool based memory resource"
(https://github.com/bitcoin/bitcoin/pull/25325)

💬 achow101 commented on pull request "wallet: coin selection, don't return results that exceed the max allowed weight":
(https://github.com/bitcoin/bitcoin/pull/26720#issuecomment-1516902528)
ACK 25ab14712b9d80276016f9fc9bff7fb9c1d09635

📝 fanquake opened a pull request: "[25.x] Bump version to 25.0rc1"
(https://github.com/bitcoin/bitcoin/pull/27504)
Bump the version number.
Generate the man pages.
Generate example bitcoin.conf.
Point release-notes.md to the wiki: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/25.0-Release-Notes-Draft.
Bump the version number in bips.md.

💬 achow101 commented on pull request "[25.x] Bump version to 25.0rc1":
(https://github.com/bitcoin/bitcoin/pull/27504#issuecomment-1516909292)
ACK cf5850688d431e663e01a595b8547ff0d2902b69

💬 sipa commented on pull request "Add pool based memory resource":
(https://github.com/bitcoin/bitcoin/pull/25325#issuecomment-1516910306)
Posthumous utACK 9f947fc3d4b779f017332135323b34e8f216f613

🚀 achow101 merged a pull request: "wallet: coin selection, don't return results that exceed the max allowed weight"
(https://github.com/bitcoin/bitcoin/pull/26720)

👍 fanquake approved a pull request: "test: Remove unused sanitizer suppressions"
(https://github.com/bitcoin/bitcoin/pull/27498#pullrequestreview-1394726376)
ACK fa5af4d510a8f129157db8b69a9a387036efb206

🚀 achow101 merged a pull request: "[25.x] Bump version to 25.0rc1"
(https://github.com/bitcoin/bitcoin/pull/27504)

💬 theStack commented on pull request "contrib: add tool to convert compact-serialized UTXO set to SQLite database":
(https://github.com/bitcoin/bitcoin/pull/27432#issuecomment-1516922824)
> > the resulting file has roughly 2x the size of the compact-serialized UTXO set (this is mostly due to encoding txids and scriptpubkeys as hex-strings rather than bytes)
>
> What is the rationale for encoding as text rather than bytes? SQLite can store byte values as BLOBs.

Fair question. There was already some discussion in #24952 about whether to store txids/scriptPubKeys as TEXT or BLOB, see https://github.com/bitcoin/bitcoin/pull/24952#pullrequestreview-952102140, https://github.com/
...

💬 fanquake commented on pull request "ci: use LLVM/clang-16 in native_asan job":
(https://github.com/bitcoin/bitcoin/pull/27360#issuecomment-1516926753)
Ubuntu 23.04 has been released: https://lists.ubuntu.com/archives/ubuntu-announce/2023-April/000289.html. So the Google Cloud images should be available soon.

👋 fanquake's pull request is ready for review: "ci: use LLVM/clang-16 in native_asan job"
(https://github.com/bitcoin/bitcoin/pull/27360)