💬 danielabrozzoni commented on pull request "rest: Support transaction broadcast in REST interface":
(https://github.com/bitcoin/bitcoin/pull/31065#issuecomment-2417141803)
When building an electrum indexer, REST interface would be preferred over RPC as:
- it's easier to set up for users, since it doesn't require any form of authentication
- it's safer, since from the REST interface only a small subset of methods can be accessed, none of which interact with the wallet or can be a security concern. While you can use `rpcwhitelist` to limit access to the RPC, this requires an extra step of configuration from users, who may forget to set it or misuse it. For example
...

💬 maflcko commented on pull request "validation: Improve input script check error reporting":
(https://github.com/bitcoin/bitcoin/pull/31097#issuecomment-2417162877)
The test fails due to https://github.com/bitcoin/bitcoin/issues/30960

💬 maflcko commented on pull request "Fix -norpcwhitelist, -norpcallowip, and similar corner case behavior":
(https://github.com/bitcoin/bitcoin/pull/30529#issuecomment-2417171076)
Could rebase for fresh CI?

💬 maflcko commented on pull request "depends: Make default `host` and `build` comparable":
(https://github.com/bitcoin/bitcoin/pull/30584#issuecomment-2417171746)
Could rebase for fresh CI?

💬 maflcko commented on pull request "wallet: Ensure best block matches wallet scan state":
(https://github.com/bitcoin/bitcoin/pull/30221#issuecomment-2417197820)
Maybe mark as draft while CI is red?

💬 hebasto commented on pull request "depends: Make default `host` and `build` comparable":
(https://github.com/bitcoin/bitcoin/pull/30584#issuecomment-2417198013)
> Could rebase for fresh CI?

Done.

💬 maflcko commented on pull request "index: Fix coinstats overflow and introduce index versioning":
(https://github.com/bitcoin/bitcoin/pull/30469#issuecomment-2417206114)
Could rebase for fresh CI?

⚠️ maflcko opened an issue: "p2p_seednode.py intermittent issue: Expected messages "["Couldn't connect to peers from addrman after 10 seconds. Adding seednode (0.0.0.2) to addrfetch"]" does not partially match log:"
(https://github.com/bitcoin/bitcoin/issues/31103)
https://cirrus-ci.com/task/6359355052785664?logs=ci#L0

```
315/315 - [1mp2p_seednode.py [0m failed, Duration: 604 s
[16:31:19.298]
[16:31:19.298] [1mstdout:
[16:31:19.298] [0m2024-10-12T16:21:15.331000Z TestFramework (INFO): PRNG seed is: 5946564122551860139
[16:31:19.298] 2024-10-12T16:21:15.337000Z TestFramework (INFO): Initializing test directory /ci_container_base/ci/scratch/test_runner/test_runner_₿_🏃_20241012_160653/p2p_seednode_0
[16:31:19.298] 2024-10-12T16:31:16.422000Z Te
...

💬 maflcko commented on pull request "doc: update signet documentation related to build directories":
(https://github.com/bitcoin/bitcoin/pull/30996#issuecomment-2417217056)
lgtm ACK a647d4400d55558735f102988e84eedc39b3affa

CI failure is unrelated: https://github.com/bitcoin/bitcoin/issues/31103

💬 maflcko commented on pull request "test: Shut down framework cleanly on RPC connection failure":
(https://github.com/bitcoin/bitcoin/pull/30660#issuecomment-2417221839)
Could rebase for fresh CI?

👍 theuni approved a pull request: "depends: sqlite 3.46.1"
(https://github.com/bitcoin/bitcoin/pull/29991#pullrequestreview-2372922887)
Not opposed utACK def6dd0c597f2c7b0c55910792e646b8ff93e36c

📝 fanquake opened a pull request: "[28.x] Some backports"
(https://github.com/bitcoin/bitcoin/pull/31104)
Backports:
* #31007
* #31016
* #31035

💬 hebasto commented on pull request "build: Bump minimum supported macOS to 13.0":
(https://github.com/bitcoin/bitcoin/pull/31048#discussion_r1803386502)
> Do you plan to open a follow-up to apply the similar change to Windows?

Yes. When I find a proper way to specify the minimum required OS version. The currently used `--major-subsystem-version` and `--minor-subsystem-version` flags do not work for me. And Microsoft docs are not very helpful. So any hints are much appreciated.

💬 RCasatta commented on issue "Support transaction broadcast in REST interface":
(https://github.com/bitcoin/bitcoin/issues/31017#issuecomment-2417242064)
Please see https://github.com/bitcoin/bitcoin/pull/31065#issuecomment-2417141803 for details

💬 maflcko commented on pull request "build: Bump minimum supported macOS to 13.0":
(https://github.com/bitcoin/bitcoin/pull/31048#discussion_r1803389823)
If everything fails, just updating the docs would be fine as well. Users are always free to shoot themselves in the foot. If the binary works for them, fine, if not, there won't be any support?

🚀 fanquake merged a pull request: "doc: update signet documentation related to build directories"
(https://github.com/bitcoin/bitcoin/pull/30996)

💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1803408738)
sure, changed

💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1803408819)
done

💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1803408904)
done

💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1803409020)
yes, clarified