✅ Sjors closed a pull request: "Stratum v2 Transport"
(https://github.com/bitcoin/bitcoin/pull/30315)

💬 Sjors commented on pull request "Stratum v2 Transport":
(https://github.com/bitcoin/bitcoin/pull/30315#issuecomment-2416152718)
I moved this to https://github.com/Sjors/bitcoin/pull/67 so we can focus on building an interface for external applications to use, and getting multiprocess in a release.

💬 laanwj commented on pull request "test: extend the SOCKS5 Python proxy to actually connect to a destination":
(https://github.com/bitcoin/bitcoin/pull/29420#discussion_r1802670686)
Maybe factor this shovel-from-socketa-to-socketb loop out to a function in netutil as well.

💬 laanwj commented on pull request "test: extend the SOCKS5 Python proxy to actually connect to a destination":
(https://github.com/bitcoin/bitcoin/pull/29420#discussion_r1802683914)
i don't think `sendall` can be guaranteed with non-blocking sockets, it will fail if it gets EAGAIN
https://stackoverflow.com/questions/6240737/python-socket-sendall-function

💬 instagibbs commented on issue "Why does `submitpackage` require at least two transactions":
(https://github.com/bitcoin/bitcoin/issues/31085#issuecomment-2416189977)
I think it's reasonable to support. I'll take a look.

💬 laanwj commented on pull request "benchmark: Improve SipHash_32b accuracy to avoid potential optimization issues":
(https://github.com/bitcoin/bitcoin/pull/30349#discussion_r1802716839)
nit: please put multiple statements on multiple lines, this is pretty hard to read code as-is :sweat_smile:

💬 laanwj commented on pull request "benchmark: Improve SipHash_32b accuracy to avoid potential optimization issues":
(https://github.com/bitcoin/bitcoin/pull/30349#issuecomment-2416224594)
ACK on overall change, small nit

📝 instagibbs opened a pull request: "Package validation: accept packages of size 1"
(https://github.com/bitcoin/bitcoin/pull/31096)
There's no particular reason to restrict single transaction submissions with submitpackage. This change relaxes the RPC checks as well as the `IsChildWith*` checks to allow these cases, as well as return false rather than segfault with an empty package.

Resolves #31085

💬 instagibbs commented on issue "Why does `submitpackage` require at least two transactions":
(https://github.com/bitcoin/bitcoin/issues/31085#issuecomment-2416273464)
Opened #31096

💬 TheCharlatan commented on pull request "Package validation: accept packages of size 1":
(https://github.com/bitcoin/bitcoin/pull/31096#issuecomment-2416279768)
Cobcept ACK

💬 ryanofsky commented on issue "Error: specified data directory "\\IP.Ad.re.ss\release\Folder"does not exist":
(https://github.com/bitcoin/bitcoin/issues/25868#issuecomment-2416281089)
re: https://github.com/bitcoin/bitcoin/issues/25868#issuecomment-1235378136

> Looks like the issue is related to Windows native format implementation of [`QSettings`](https://doc.qt.io/qt-5/qsettings.html)...

@hebasto do you remember what this comment is referring to? I don't see how the qsettings implementation would affect this, since the setting seems like it is read successfully.

re: https://github.com/bitcoin/bitcoin/issues/25868#issuecomment-1476482356

> I wonder if this is rel
...

💬 laanwj commented on pull request "rpc: net: follow-ups for #30062":
(https://github.com/bitcoin/bitcoin/pull/30183#issuecomment-2416283036)
Code and doc review ACK b33eb137e39c434a7be69e1453a708b0c52553c4

📝 dergoegge opened a pull request: "validation: Improve input script check error reporting"
(https://github.com/bitcoin/bitcoin/pull/31097)
An input script might be invalid for multiple reasons. For example, it might fail both a standardness check and a consensus check, which can lead to a `mandatory-script-verify-flag-failed` error being reported that includes the script error string from the standardness failure (e.g. `mandatory-script-verify-flag-failed (Using OP_CODESEPARATOR in non-witness script)`), which is confusing.

💬 brunoerg commented on pull request "test: Assert that when we add the max orphan amount that we cannot add anymore and that a random orphan gets dropped":
(https://github.com/bitcoin/bitcoin/pull/31040#discussion_r1802780229)
nit
```suggestion
for _ in range(MAX_ORPHANS):
```

🤔 stickies-v reviewed a pull request: "Package validation: accept packages of size 1"
(https://github.com/bitcoin/bitcoin/pull/31096#pullrequestreview-2371892884)
Concept ACK

💬 stickies-v commented on pull request "Package validation: accept packages of size 1":
(https://github.com/bitcoin/bitcoin/pull/31096#discussion_r1802786666)
I think this check can be dropped, operation should be safe and no-op if package is empty? I'm fine with it either way, just simplifies the code a bit.

💬 stickies-v commented on pull request "Package validation: accept packages of size 1":
(https://github.com/bitcoin/bitcoin/pull/31096#discussion_r1802783016)
I wouldn't remove this, but rather update to:

```
// IsChildWithParents() guarantees the package is not empty.
assert(!package.empty());
```

After all, if the package is empty, we'd have UB a few lines down.

💬 brunoerg commented on pull request "test: Assert that when we add the max orphan amount that we cannot add anymore and that a random orphan gets dropped":
(https://github.com/bitcoin/bitcoin/pull/31040#discussion_r1802787555)
The comment here says that the first orphan has been dropped and the PR title says "a random orphan gets dropped". I don't know so much about it, what is the expected behavior?

💬 dergoegge commented on pull request "Introduce `g_fuzzing` global for fuzzing checks":
(https://github.com/bitcoin/bitcoin/pull/31093#issuecomment-2416333030)
The CI failure is a little puzzling:

```
[13:26:14.486] Run bitset with args ['/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/test/fuzz/fuzz', '-runs=1', PosixPath('/ci_container_base/ci/scratch/qa-assets/fuzz_corpora/bitset')]INFO: Running with entropic power schedule (0xFF, 100).
[13:26:14.486] INFO: Seed: 1575764882
[13:26:14.486] INFO: Loaded 1 modules (622699 inline 8-bit counters): 622699 [0x557b75e3b468, 0x557b75ed34d3),
[13:26:14.486] INFO: Loaded 1 PC tables (6226
...

💬 achow101 commented on pull request "descriptor: Add proper Clone function to miniscript::Node":
(https://github.com/bitcoin/bitcoin/pull/30866#discussion_r1802790813)
Not entirely sure either.