💬 achow101 commented on pull request "wallet: improve IBD sync time by skipping block scanning prior birth time":
(https://github.com/bitcoin/bitcoin/pull/27469#discussion_r1171720322)
In 1a9a349a026af2865e5446091f1e072b7a845819 "wallet: skip block scan if block was created before wallet birthday"

`m_birth_time` could be initialized with `std::numeric_limits<in64_t>::max()` which would remove the need to compare against `BLANK_BIRTH_TIME`.

💬 jamesob commented on pull request "assumeutxo: keep cache when flushing snapshot (#17487 followup)":
(https://github.com/bitcoin/bitcoin/pull/27008#issuecomment-1515221746)
@Sjors how did you detect that RAM *wasn't* being freed? Did you verify that the flush did not happen based on an absence of logs?

Measures of memory can be deceptive; I remember bitcoinperf spuriously detecting an increase in memory usage because once claimed, the process' resident set size (RSS) doesn't necessarily go down upon free.

💬 pinheadmz commented on issue "Improve transaction privacy / fungibility in Bitcoin Core and the Bitcoin system [meta tracking issues]":
(https://github.com/bitcoin/bitcoin/issues/6568#issuecomment-1515251239)
Privacy and fungibility are crucial, ongoing goals of the project. This meta tracking issue has gotten stale and I think it is safe to close. Almost all the recommendations in the OP have been developed or are in-progress such as silent payments, address groupings, and Taproot. 🚀

✅ pinheadmz closed an issue: "Improve transaction privacy / fungibility in Bitcoin Core and the Bitcoin system [meta tracking issues]"
(https://github.com/bitcoin/bitcoin/issues/6568)

💬 achow101 commented on pull request "net, contrib: Bugfix for checking bad dns seeds without casting in `makeseeds.py`":
(https://github.com/bitcoin/bitcoin/pull/26681#issuecomment-1515270617)
ACK 3cc989da5c750e740705131bed05bbf93bfdf169

💬 ryanofsky commented on pull request "RPC: Accept options as named-only parameters":
(https://github.com/bitcoin/bitcoin/pull/26485#issuecomment-1515315562)
Thanks, I added the check and flag you suggested in a new commit.

---

Added 1 commits 927a910cbe6c96d60c6a8b05baad179ef3f61f1c -> 284173937d156e1c0f291abe0b82274468d242e8 ([`pr/nonly.12`](https://github.com/ryanofsky/bitcoin/commits/pr/nonly.12) -> [`pr/nonly.13`](https://github.com/ryanofsky/bitcoin/commits/pr/nonly.13), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/nonly.12...pr/nonly.13))

💬 hebasto commented on pull request "build: Add CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/25797#issuecomment-1515397369)
Updated up to [pr25797.59](https://github.com/hebasto/bitcoin/commits/pr25797.59):

Rebased on the current [cmake-staging](https://github.com/hebasto/bitcoin/tree/cmake-staging) branch (first 25 out of a total of 75 commits).

All CI tasks are :green_circle:

Guix builds:
```
25a62ef8d51c07799b2fe3f687f2340b9f5cf2523079ed12cdc1bbac07b38188 guix-build-33b2db8e6f7c/output/aarch64-linux-gnu/SHA256SUMS.part
af60d9a558ed74492cdf2697d54c3a25aa236a29721269a0eaa35a37997724bd guix-build-33b2d
...

📝 theuni opened a pull request: "depends: reuse _config_opts for CMake options"
(https://github.com/bitcoin/bitcoin/pull/27496)
Context: I'm [currently experimenting with building our depends with CMake when possible](https://github.com/theuni/bitcoin/commits/depends-cmake) as part of our future transition to CMake. Specifically zmq, libevent, libnatpmp, and miniupnpc all have existing CMake buildsystems. Building them with CMake will allow us to drop several deps that we currently have (autoconf, automake, pkg-config, etc) which would be unfortunate to carry over after the switch-over.

But that's not relevant for thi
...

💬 theuni commented on pull request "depends: reuse _config_opts for CMake options":
(https://github.com/bitcoin/bitcoin/pull/27496#issuecomment-1515416038)
Ping @hebasto. This should be easy to review, only verifying that it's currently a no-op :)

💬 jonatack commented on pull request "net, contrib: Bugfix for checking bad dns seeds without casting in `makeseeds.py`":
(https://github.com/bitcoin/bitcoin/pull/26681#discussion_r1171880911)
It looks like this will never be true, unless a user manually adds `#` characters to the start of lines. It's not hit currently.

```diff
if line.startswith('#'):
# Ignore line that starts with comment
+ print(line.split(), file=sys.stderr)
return None
```

💬 jonatack commented on pull request "net, contrib: Bugfix for checking bad dns seeds without casting in `makeseeds.py`":
(https://github.com/bitcoin/bitcoin/pull/26681#discussion_r1171884500)
Verified that this fix works with the following diff:

```diff
# Skip bad results.
if int(sline[1]) == 0:
+ # print(line.split(), file=sys.stderr)
return None
```

The result of running the script:

before

```
Loading asmap database "asmap-filled.dat"…Done.
Loading and parsing DNS seeds…Done.
IPv4 IPv6 Onion Pass
99253 23129 0 Initial
99253 23129 0 Skip entries with invalid address
99
...

💬 fanquake commented on pull request "net, contrib: Bugfix for checking bad dns seeds without casting in `makeseeds.py`":
(https://github.com/bitcoin/bitcoin/pull/26681#discussion_r1171884989)
> It looks like this will never be true, unless a user manually adds # characters

The first line seeds_main.txt is # addresses, so it's going to be hit at least once.

👍 jonatack approved a pull request: "net, contrib: Bugfix for checking bad dns seeds without casting in `makeseeds.py`"
(https://github.com/bitcoin/bitcoin/pull/26681#pullrequestreview-1392930267)
ACK 3cc989da5c750e740705131bed05bbf93bfdf169

💬 achow101 commented on pull request "net, contrib: Bugfix for checking bad dns seeds without casting in `makeseeds.py`":
(https://github.com/bitcoin/bitcoin/pull/26681#discussion_r1171886146)
It catches the first line for me.

💬 jonatack commented on pull request "net, contrib: Bugfix for checking bad dns seeds without casting in `makeseeds.py`":
(https://github.com/bitcoin/bitcoin/pull/26681#discussion_r1171886252)
Yes. Updated my comment to mention the first line and result.

💬 jonatack commented on pull request "net, contrib: Bugfix for checking bad dns seeds without casting in `makeseeds.py`":
(https://github.com/bitcoin/bitcoin/pull/26681#discussion_r1171889143)
Actually, it may make more sense to leave the '#' conditional where it is, as it is only hit once, and instead do:

```diff
# Skip bad results.
- if int(sline[1]) == 0:
+ if sline[1] == '0':
return None
```

💬 hebasto commented on pull request "depends: reuse _config_opts for CMake options":
(https://github.com/bitcoin/bitcoin/pull/27496#issuecomment-1515432548)
Concept ACK.

🤔 mzumsande reviewed a pull request: "p2p: update hardcoded mainnet seeds for 25.x"
(https://github.com/bitcoin/bitcoin/pull/27488#pullrequestreview-1392969258)
ACK b330a6621d8801ec4c408dc0ca69ec2d02b88564

Not 100% sure how to best test this, but I did the following:

I followed the steps described in `contrib/seeds/README.md`, the overall result is similar.
There are some differences (~60 in total) - I guess that's expected due to changed input data and asmap data from sipa's seeder.

```
$ python3 makeseeds.py -a asmap-filled.dat -s seeds_main.txt > nodes_main.txt
Loading asmap database "asmap-filled.dat"…Done.
Loading and parsing DNS seeds
...

👍 hebasto approved a pull request: "depends: reuse _config_opts for CMake options"
(https://github.com/bitcoin/bitcoin/pull/27496#pullrequestreview-1392993005)
ACK 63c0c4ff10b2f6ed8510ef372a5b1f6a6494b179

This change allows to reuse this machinery: https://github.com/bitcoin/bitcoin/blob/d26a71a94ac4ae1b1a091f4412d390afba69b2f8/depends/funcs.mk#L128-L131

💬 jonatack commented on pull request "p2p: update hardcoded mainnet seeds for 25.x":
(https://github.com/bitcoin/bitcoin/pull/27488#issuecomment-1515510969)
> I think it's great that we now have a few more tor seeds than 11, which seemed rather low to me considering the large number of bitcoin nodes reachable via tor.

Credit to you, @mzumsande, for suggesting to me yesterday that we add more.

I've repushed after pulling in 3cc989da5c750e740705131bed05bbf93bfdf169 from #26681 and re-running the steps in `contrib/seeds/README.md`.