💬 achow101 commented on pull request "refactor: move util/pcp and util/netif to common/":
(https://github.com/bitcoin/bitcoin/pull/31011#issuecomment-2389797994)
ACK fd38711217cafbd62e8abd22d2b43f85fede8cde

💬 tdb3 commented on pull request "rpc: add getorphantxs":
(https://github.com/bitcoin/bitcoin/pull/30793#discussion_r1785316213)
Updated

💬 tdb3 commented on pull request "rpc: add getorphantxs":
(https://github.com/bitcoin/bitcoin/pull/30793#discussion_r1785316256)
Good point. Updated.

💬 tdb3 commented on pull request "rpc: add getorphantxs":
(https://github.com/bitcoin/bitcoin/pull/30793#discussion_r1785316316)
Agreed. Updated

💬 tdb3 commented on pull request "rpc: add getorphantxs":
(https://github.com/bitcoin/bitcoin/pull/30793#discussion_r1785316368)
Good point. Test added.

💬 tdb3 commented on pull request "rpc: add getorphantxs":
(https://github.com/bitcoin/bitcoin/pull/30793#issuecomment-2389805371)
Updated to address comments from @glozow

Removed default argument from `ParseVerbosity()`, cleaned up comments, and updated the functional test to check negative verbosity.

```
git range-diff fc642c33ef28829eda0119a0fe39fd9bc4b84051..b6368fc285bf00b3033061dcd4e29298b227c6df fc642c33ef28829eda0119a0fe39fd9bc4b84051..98c1536852d1de9a978b11046e7414e79ed40b46
```

🚀 achow101 merged a pull request: "refactor: move util/pcp and util/netif to common/"
(https://github.com/bitcoin/bitcoin/pull/31011)

💬 tdb3 commented on pull request "rpc: add getorphantxs":
(https://github.com/bitcoin/bitcoin/pull/30793#issuecomment-2389806502)
> Ran Doxygen and inspected `ParseVerbosity` docs to confirm `[in]`-parameters were handled well etc.
Much appreciated

💬 achow101 commented on pull request "log: Enforce trailing newline":
(https://github.com/bitcoin/bitcoin/pull/30929#issuecomment-2389837346)
ACK fa2b7d8d6b3f8d53199921e1e542072441b26fab

🚀 achow101 merged a pull request: "log: Enforce trailing newline"
(https://github.com/bitcoin/bitcoin/pull/30929)

👍 tdb3 approved a pull request: "netinfo: add peer services column and outbound-only peers list"
(https://github.com/bitcoin/bitcoin/pull/30930#pullrequestreview-2344305697)
code review and light test ACK 683b558a020f1632b0a3cbdaa165adbd1423281c

Good catch with age/services

👍 tdb3 approved a pull request: "test: Treat exclude list warning as failure in CI"
(https://github.com/bitcoin/bitcoin/pull/31018#pullrequestreview-2344350147)
ACK fa6d14eacb2a8c1c3243e3075254dfdebaa9290e

Lightly tested with:
```
$ build/test/functional/test_runner.py --ci rpc_users.py --exclude not_in_list
Temporary test directory at /tmp/test_runner_₿_🏃_20241002_194128
WARNING! Test 'not_in_list' not found in current test list. Check the --exclude list.
$ echo $?
1
```

🚀 glozow merged a pull request: "fuzz: fix bug in p2p_headers_presync harness"
(https://github.com/bitcoin/bitcoin/pull/30980)

💬 glozow commented on pull request "rpc: add getorphantxs":
(https://github.com/bitcoin/bitcoin/pull/30793#issuecomment-2390343863)
reACK 98c1536852d

💬 luisschwab commented on issue "bitcoin.service issue for a noob like me":
(https://github.com/bitcoin/bitcoin/issues/31021#issuecomment-2390367910)
FWIW, this is my `bitcoind.service` config, running on Ubuntu 24.04:
```service
[Unit]
Description=Bitcoin Core Daemon
After=network-online.target

[Service]
User=bitcoin
Type=simple
Restart=on-failure
ExecStart=/usr/local/bin/bitcoind

[Install]
WantedBy=multi-user.target
```

Then I enabled it:
```shell
~$ sudo systemctl enable bitcoind.service
```

Never had any issues with it.

💬 usuarrio-id81214293 commented on issue "Intermittent failure in feature_fee_estimation.py in sanity_check_rbf_estimates: est_feerate = node.estimatesmartfee(2)["feerate"] (KeyError: 'feerate')":
(https://github.com/bitcoin/bitcoin/issues/30640#issuecomment-2390373539)
cmake -B build -DWITH_ZMQ=ON -DREDUCE_EXPORTS=ON -DCMAKE_C_FLAGS="-g0 -O2 -funsigned-char" -DCMAKE_CXX_FLAGS="-g0 -O2 -funsigned-char -DBOOST_MULTI_INDEX_ENABLE_SAFE_MODE"

💬 luisschwab commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2390376610)
Concept ACK.

Great feature, not being able to do this is a PITA.

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1785630298)
This code in `CConnman::ThreadOpenConnections()` is not checking whether private broadcast is enabled because it is just a servant, its logic is: "if there is a request to open private broadcast connections, then I will open them". The higher level code is making the decision (currently in RPC only, but eventually in the wallet as well) - "if private broadcast is enabled, then open such connections because I am now broadcasting a transaction (and don't put it in the mempool)". This is why there
...

✅ nulladoses closed an issue: "bitcoin.service issue for a noob like me"
(https://github.com/bitcoin/bitcoin/issues/31021)

💬 nulladoses commented on issue "bitcoin.service issue for a noob like me":
(https://github.com/bitcoin/bitcoin/issues/31021#issuecomment-2390575627)
thank you for your answer. i found also this looking around

[Unit]
Description=Bitcoin Daemon
After=network.target
[Service]
User=ubuntu
PIDFile=/home/ubuntu/.bitcoin/bitcoind.pid
ExecStart=/usr/local/bin/bitcoind
Restart=always
TimeoutSec=120
RestartSec=30
[Install]
WantedBy=multi-user.target

and give me one error when i boot the pc but restart anyway and then is ok
thank you
``